update_client reports service packs in the OS version |
|||
Issue descriptionIn some cases update_client will report <os version="6.1 SP1">; strictly, it ought to represent this as <os version="6.1" sp="SP1">. https://github.com/google/omaha/blob/master/doc/ServerProtocolV3.md#os
,
Sep 23 2016
,
Sep 27 2016
,
Sep 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/435a1b4f0d12145d7f34c7645bb4e8bfb946f484 commit 435a1b4f0d12145d7f34c7645bb4e8bfb946f484 Author: sorin <sorin@chromium.org> Date: Tue Sep 27 19:34:05 2016 Component updater: report the Windows OS and Service Pack separately. The current implementation of base::SysInfo().OperatingSystemVersion() for Windows joins the version of the OS with some representation of the Service Pack. That created a server configuration issue in the past where a rule had been written assuming a dotted version string for the OS. Since then, the authors of configuration files have learned to write rules that consider the possibility that OS versions may not be dotted strings. Traditionally, Omaha expected the OS version and Service Pack as serparate entities in the Omaha protocol. Other platforms but Windows and Linux use dotted version strings currently. They have no Service Packs. The Linux does not provide an implementation for base::SysInfo::OperatingSystemVersionNumbers(). Linux versions could include relevant information that does not fit the typical dotted string version. In conclusion, this change is a minor improvement for the Windows OS metadata and leaves the rest, including Linux, the same as before. BUG= 642476 Review-Url: https://codereview.chromium.org/2365523004 Cr-Commit-Position: refs/heads/master@{#421296} [modify] https://crrev.com/435a1b4f0d12145d7f34c7645bb4e8bfb946f484/base/win/windows_version.cc [modify] https://crrev.com/435a1b4f0d12145d7f34c7645bb4e8bfb946f484/base/win/windows_version.h [modify] https://crrev.com/435a1b4f0d12145d7f34c7645bb4e8bfb946f484/components/update_client/utils.cc |
|||
►
Sign in to add a comment |
|||
Comment 1 by sorin@chromium.org
, Aug 30 2016