See go/GNumGP
This plugin should validate commit position footers the chromium way (see go/gnumbd for details) as proposed in go/GNumGP
Plugin source: https://chromium.googlesource.com/infra/gerrit-plugins/git-number-verifier
See CLs https://chromium-review.googlesource.com/q/project:infra%252Fgerrit-plugins%252Fgit-number-verifier
The following revision refers to this bug: https://chromium.googlesource.com/infra/gerrit-plugins/git-number-verifier/+/78bb470e7ff035dbdce5ad2e8c1fe591f0726487 commit 78bb470e7ff035dbdce5ad2e8c1fe591f0726487 Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Tue Oct 25 20:23:15 2016 Add basic readme and codereview.settings. R=sergiyb@chromium.org BUG= 642466 Change-Id: I6a40405a83c3ba74d4c04a72520a3905c8bbdba3 [add] https://crrev.com/78bb470e7ff035dbdce5ad2e8c1fe591f0726487/codereview.settings [add] https://crrev.com/78bb470e7ff035dbdce5ad2e8c1fe591f0726487/README.md
The following revision refers to this bug: https://chromium.googlesource.com/infra/gerrit-plugins/git-number-verifier/+/4c25be5251e9d4a683f5bc3e171274aa9485fdb5 commit 4c25be5251e9d4a683f5bc3e171274aa9485fdb5 Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Tue Oct 25 20:30:39 2016 Add skeleton files. Bug: chromium:642466 Change-Id: I05e9cfbe0c31f956a2d06d58ec5f7a9b5a1e098e [add] https://crrev.com/4c25be5251e9d4a683f5bc3e171274aa9485fdb5/BUCK [add] https://crrev.com/4c25be5251e9d4a683f5bc3e171274aa9485fdb5/LICENSE [add] https://crrev.com/4c25be5251e9d4a683f5bc3e171274aa9485fdb5/src/test/java/com/googlesource/chromium/plugins/gitnumber/verifier/GitNumberFooterVerifierTestIT.java [add] https://crrev.com/4c25be5251e9d4a683f5bc3e171274aa9485fdb5/src/main/java/com/googlesource/chromium/plugins/gitnumber/verifier/GitNumberFooterVerifier.java [add] https://crrev.com/4c25be5251e9d4a683f5bc3e171274aa9485fdb5/.gitignore [add] https://crrev.com/4c25be5251e9d4a683f5bc3e171274aa9485fdb5/.buckconfig [add] https://crrev.com/4c25be5251e9d4a683f5bc3e171274aa9485fdb5/src/main/java/com/googlesource/chromium/plugins/gitnumber/verifier/Module.java [modify] https://crrev.com/4c25be5251e9d4a683f5bc3e171274aa9485fdb5/README.md
Extra gerrit change https://chromium-review.googlesource.com/c/403871/4
OOps. Gerrit chagne is this one: https://gerrit-review.googlesource.com/c/90210/
The following revision refers to this bug: https://chromium.googlesource.com/infra/gerrit-plugins/git-number-verifier/+/c0cd74db41668c85a72771d70f21ed4b8529d375 commit c0cd74db41668c85a72771d70f21ed4b8529d375 Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Thu Oct 27 20:09:14 2016 Add parsing of relevant footers except cherry-pick commits. Cherry-Pick commits had their original footers copied with '-Original' inserted into footer names and that is not implemented yet. This does NOT generate footers, but merely parses them. Bug: chromium:642466 Change-Id: I6ded6005aa6fef725a2870002b8713c6404ca843 [add] https://crrev.com/c0cd74db41668c85a72771d70f21ed4b8529d375/src/main/java/com/googlesource/chromium/plugins/gitnumber/verifier/CommitPositionValue.java [add] https://crrev.com/c0cd74db41668c85a72771d70f21ed4b8529d375/src/main/java/com/googlesource/chromium/plugins/gitnumber/verifier/PositionFooters.java [add] https://crrev.com/c0cd74db41668c85a72771d70f21ed4b8529d375/src/main/java/com/googlesource/chromium/plugins/gitnumber/verifier/BranchedFromValue.java [add] https://crrev.com/c0cd74db41668c85a72771d70f21ed4b8529d375/src/test/java/com/googlesource/chromium/plugins/gitnumber/verifier/PositionFootersIT.java [delete] https://crrev.com/4c25be5251e9d4a683f5bc3e171274aa9485fdb5/src/test/java/com/googlesource/chromium/plugins/gitnumber/verifier/GitNumberFooterVerifierTestIT.java
The following revision refers to this bug: https://chromium.googlesource.com/infra/gerrit-plugins/git-number-verifier/+/9eda4b34d639027d0955a17f0dd2fcfd7e99d884 commit 9eda4b34d639027d0955a17f0dd2fcfd7e99d884 Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Wed Nov 02 12:39:31 2016 Add single commit validator. Covered decently with tests % merged commit case. Bug: chromium:642466 Change-Id: I2e808b3e08689cb82820cff5b75a2351a1ddadce [add] https://crrev.com/9eda4b34d639027d0955a17f0dd2fcfd7e99d884/src/test/java/com/googlesource/chromium/plugins/gitnumber/verifier/ValidatorIT.java [modify] https://crrev.com/9eda4b34d639027d0955a17f0dd2fcfd7e99d884/src/test/java/com/googlesource/chromium/plugins/gitnumber/verifier/PositionFootersIT.java [add] https://crrev.com/9eda4b34d639027d0955a17f0dd2fcfd7e99d884/src/main/java/com/googlesource/chromium/plugins/gitnumber/verifier/GitNumberValidationError.java [modify] https://crrev.com/9eda4b34d639027d0955a17f0dd2fcfd7e99d884/src/main/java/com/googlesource/chromium/plugins/gitnumber/verifier/PositionFooters.java [add] https://crrev.com/9eda4b34d639027d0955a17f0dd2fcfd7e99d884/src/main/java/com/googlesource/chromium/plugins/gitnumber/verifier/Validator.java [modify] https://crrev.com/9eda4b34d639027d0955a17f0dd2fcfd7e99d884/src/main/java/com/googlesource/chromium/plugins/gitnumber/verifier/CommitPositionValue.java [modify] https://crrev.com/9eda4b34d639027d0955a17f0dd2fcfd7e99d884/src/main/java/com/googlesource/chromium/plugins/gitnumber/verifier/BranchedFromValue.java
The following revision refers to this bug: https://chromium.googlesource.com/infra/gerrit-plugins/git-number-verifier/+/ce2c08d7d8be443fb4c06fc7c263aef3ae712678 commit ce2c08d7d8be443fb4c06fc7c263aef3ae712678 Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Wed Nov 02 16:45:26 2016 Add plugin config. Bug: chromium:642466 Change-Id: Ie62994424ce098b1eb601ca2cb00cac4f4fcd59c [add] https://crrev.com/ce2c08d7d8be443fb4c06fc7c263aef3ae712678/src/test/java/com/googlesource/chromium/plugins/gitnumber/verifier/ConfigTest.java [modify] https://crrev.com/ce2c08d7d8be443fb4c06fc7c263aef3ae712678/src/main/java/com/googlesource/chromium/plugins/gitnumber/verifier/GitNumberFooterVerifier.java [add] https://crrev.com/ce2c08d7d8be443fb4c06fc7c263aef3ae712678/src/main/java/com/googlesource/chromium/plugins/gitnumber/verifier/ConfigMatcher.java [modify] https://crrev.com/ce2c08d7d8be443fb4c06fc7c263aef3ae712678/src/main/java/com/googlesource/chromium/plugins/gitnumber/verifier/Module.java [add] https://crrev.com/ce2c08d7d8be443fb4c06fc7c263aef3ae712678/src/main/resources/Documentation/config.md
I've submitted the plugin to Google's gerrit deployment (internal CLs: http://cl/138118481 and http://cl/138115491). What's next? Actually deploying it to a specific host such as chromium.googlesource.com.
The following revision refers to this bug: https://chromium.googlesource.com/infra/gerrit-plugins/git-number-verifier/+/5fcca9f54498ec94e3de4ed27608c5421fec68dc commit 5fcca9f54498ec94e3de4ed27608c5421fec68dc Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Thu Nov 03 17:14:25 2016 Actually validate pushes and merges. Bug: chromium:642466 Change-Id: I10ce856bbdb14dd7c5daef48dbc88167808fa5f6 [modify] https://crrev.com/5fcca9f54498ec94e3de4ed27608c5421fec68dc/BUCK [modify] https://crrev.com/5fcca9f54498ec94e3de4ed27608c5421fec68dc/src/test/java/com/googlesource/chromium/plugins/gitnumber/verifier/ValidatorIT.java [modify] https://crrev.com/5fcca9f54498ec94e3de4ed27608c5421fec68dc/src/test/java/com/googlesource/chromium/plugins/gitnumber/verifier/PositionFootersIT.java [modify] https://crrev.com/5fcca9f54498ec94e3de4ed27608c5421fec68dc/src/main/java/com/googlesource/chromium/plugins/gitnumber/verifier/GitNumberFooterVerifier.java [modify] https://crrev.com/5fcca9f54498ec94e3de4ed27608c5421fec68dc/src/main/java/com/googlesource/chromium/plugins/gitnumber/verifier/PositionFooters.java [modify] https://crrev.com/5fcca9f54498ec94e3de4ed27608c5421fec68dc/src/main/java/com/googlesource/chromium/plugins/gitnumber/verifier/Validator.java [add] https://crrev.com/5fcca9f54498ec94e3de4ed27608c5421fec68dc/src/test/java/com/googlesource/chromium/plugins/gitnumber/verifier/GitNumberFooterVerfierIT.java [modify] https://crrev.com/5fcca9f54498ec94e3de4ed27608c5421fec68dc/src/main/java/com/googlesource/chromium/plugins/gitnumber/verifier/CommitPositionValue.java [modify] https://crrev.com/5fcca9f54498ec94e3de4ed27608c5421fec68dc/src/main/java/com/googlesource/chromium/plugins/gitnumber/verifier/BranchedFromValue.java [modify] https://crrev.com/5fcca9f54498ec94e3de4ed27608c5421fec68dc/src/test/java/com/googlesource/chromium/plugins/gitnumber/verifier/ConfigTest.java [modify] https://crrev.com/5fcca9f54498ec94e3de4ed27608c5421fec68dc/src/main/java/com/googlesource/chromium/plugins/gitnumber/verifier/Module.java
The following revision refers to this bug: https://chromium.googlesource.com/infra/gerrit-plugins/git-numberer/+/48b048b8873f240dffbb84c6c42030da66205783 commit 48b048b8873f240dffbb84c6c42030da66205783 Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Mon Nov 07 15:18:57 2016 Update README.md after plugin renaming. I decided to merge plugins to share libraries without having the same code compiled into two jars, as apparently that's the way Gerrit build system currently works. R=machenbach@chromium.org,agable@chromium.org BUG= chromium:642466 Change-Id: Ia141e4dccc16a790108dd6375d099f61645b7aaf Reviewed-on: https://chromium-review.googlesource.com/408137 Reviewed-by: Andrew Bonventre <andybons@chromium.org> [modify] https://crrev.com/48b048b8873f240dffbb84c6c42030da66205783/README.md
The following revision refers to this bug: https://chromium.googlesource.com/infra/gerrit-plugins/git-numberer/+/b57450cc596a7efcd139eeaaca76165fb5ef6623 commit b57450cc596a7efcd139eeaaca76165fb5ef6623 Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Tue Nov 08 15:54:55 2016 Rename the plugin and its main Module. R=agable@chromium.org,andybons@chromium.org BUG= chromium:642466 Change-Id: I723f1fd1c4f473cc1e61b9ee638e035622e98247 Reviewed-on: https://chromium-review.googlesource.com/408097 Reviewed-by: Aaron Gable <agable@chromium.org> Reviewed-by: Andrew Bonventre <andybons@chromium.org> [modify] https://crrev.com/b57450cc596a7efcd139eeaaca76165fb5ef6623/BUCK [rename] https://crrev.com/b57450cc596a7efcd139eeaaca76165fb5ef6623/src/main/java/com/googlesource/chromium/plugins/gitnumberer/BranchedFromValue.java [rename] https://crrev.com/b57450cc596a7efcd139eeaaca76165fb5ef6623/src/test/java/com/googlesource/chromium/plugins/gitnumberer/PositionFootersIT.java [rename] https://crrev.com/b57450cc596a7efcd139eeaaca76165fb5ef6623/src/test/java/com/googlesource/chromium/plugins/gitnumberer/ConfigTest.java [rename] https://crrev.com/b57450cc596a7efcd139eeaaca76165fb5ef6623/src/main/java/com/googlesource/chromium/plugins/gitnumberer/PositionFooters.java [rename] https://crrev.com/b57450cc596a7efcd139eeaaca76165fb5ef6623/src/main/java/com/googlesource/chromium/plugins/gitnumberer/ConfigMatcher.java [rename] https://crrev.com/b57450cc596a7efcd139eeaaca76165fb5ef6623/src/main/java/com/googlesource/chromium/plugins/gitnumberer/GitNumbererModule.java [rename] https://crrev.com/b57450cc596a7efcd139eeaaca76165fb5ef6623/src/test/java/com/googlesource/chromium/plugins/gitnumberer/ValidatorIT.java [rename] https://crrev.com/b57450cc596a7efcd139eeaaca76165fb5ef6623/src/main/java/com/googlesource/chromium/plugins/gitnumberer/GitNumberValidationError.java [rename] https://crrev.com/b57450cc596a7efcd139eeaaca76165fb5ef6623/src/main/java/com/googlesource/chromium/plugins/gitnumberer/Validator.java [rename] https://crrev.com/b57450cc596a7efcd139eeaaca76165fb5ef6623/src/test/java/com/googlesource/chromium/plugins/gitnumberer/GitNumberFooterVerfierIT.java [rename] https://crrev.com/b57450cc596a7efcd139eeaaca76165fb5ef6623/src/main/java/com/googlesource/chromium/plugins/gitnumberer/CommitPositionValue.java [rename] https://crrev.com/b57450cc596a7efcd139eeaaca76165fb5ef6623/src/main/java/com/googlesource/chromium/plugins/gitnumberer/GitNumberFooterVerifier.java
The following revision refers to this bug: https://chromium.googlesource.com/infra/gerrit-plugins/git-numberer/+/a6b189b7af54be6ebc70f3895b3da6b82a0c9e86 commit a6b189b7af54be6ebc70f3895b3da6b82a0c9e86 Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Tue Nov 08 15:56:50 2016 Refactor config to support generator and verifier. R=ekempin@google.com BUG= chromium:642466 Change-Id: If0a0024fd665942d95f54d08205680d200d284a2 Reviewed-on: https://chromium-review.googlesource.com/408098 Reviewed-by: Aaron Gable <agable@chromium.org> [modify] https://crrev.com/a6b189b7af54be6ebc70f3895b3da6b82a0c9e86/src/main/java/com/googlesource/chromium/plugins/gitnumberer/GitNumbererModule.java [modify] https://crrev.com/a6b189b7af54be6ebc70f3895b3da6b82a0c9e86/src/test/java/com/googlesource/chromium/plugins/gitnumberer/ConfigTest.java [modify] https://crrev.com/a6b189b7af54be6ebc70f3895b3da6b82a0c9e86/src/main/resources/Documentation/config.md [add] https://crrev.com/a6b189b7af54be6ebc70f3895b3da6b82a0c9e86/src/main/java/com/googlesource/chromium/plugins/gitnumberer/ConfigFields.java [modify] https://crrev.com/a6b189b7af54be6ebc70f3895b3da6b82a0c9e86/src/main/java/com/googlesource/chromium/plugins/gitnumberer/Validator.java [modify] https://crrev.com/a6b189b7af54be6ebc70f3895b3da6b82a0c9e86/src/test/java/com/googlesource/chromium/plugins/gitnumberer/GitNumberFooterVerfierIT.java
The plugin has been installed on GoB chromium host and successfully configured for v8's master branch. Thus is complete, but deployment itself is handled elsewhere.
Comment 1 by tandrii@chromium.org
, Aug 30 2016