New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 642465 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Aug 2017
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Feature



Sign in to add a comment

Implement CrOS side of WallpaperManagerService

Project Member Reported by muyuanli@chromium.org, Aug 30 2016

Issue description

ARC++ needs to support Android WallpaperManager API, which needs to be hooked up with CrOS side.

See b/29589509
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/533be7ef1063d285008913c9784d8d852055c8bd

commit 533be7ef1063d285008913c9784d8d852055c8bd
Author: muyuanli <muyuanli@chromium.org>
Date: Thu Sep 08 22:58:57 2016

cheets: implement cros side of WallpaperManagerService.

Rename ArcWallpaperHandler to ArcWallpaperService and implement it as an ArcService, which handles WallpaperManager API from Android.

Test=Manually open PickMyWallpaper app and set wallpaper
Test=run cts android.content.cts.ContextWrapperTest

Bug= 642465 

Review-Url: https://codereview.chromium.org/2264743002
Cr-Commit-Position: refs/heads/master@{#417428}

[modify] https://crrev.com/533be7ef1063d285008913c9784d8d852055c8bd/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/533be7ef1063d285008913c9784d8d852055c8bd/chrome/browser/chromeos/arc/arc_service_launcher.cc
[delete] https://crrev.com/14ce7d174f87288a351c4eee7a511bd7ba526fc9/chrome/browser/chromeos/arc/arc_wallpaper_handler.cc
[delete] https://crrev.com/14ce7d174f87288a351c4eee7a511bd7ba526fc9/chrome/browser/chromeos/arc/arc_wallpaper_handler.h
[add] https://crrev.com/533be7ef1063d285008913c9784d8d852055c8bd/chrome/browser/chromeos/arc/arc_wallpaper_service.cc
[add] https://crrev.com/533be7ef1063d285008913c9784d8d852055c8bd/chrome/browser/chromeos/arc/arc_wallpaper_service.h
[modify] https://crrev.com/533be7ef1063d285008913c9784d8d852055c8bd/components/arc/BUILD.gn
[modify] https://crrev.com/533be7ef1063d285008913c9784d8d852055c8bd/components/arc/arc_bridge_host_impl.cc
[modify] https://crrev.com/533be7ef1063d285008913c9784d8d852055c8bd/components/arc/arc_bridge_host_impl.h
[modify] https://crrev.com/533be7ef1063d285008913c9784d8d852055c8bd/components/arc/arc_bridge_service.h
[modify] https://crrev.com/533be7ef1063d285008913c9784d8d852055c8bd/components/arc/common/arc_bridge.mojom
[add] https://crrev.com/533be7ef1063d285008913c9784d8d852055c8bd/components/arc/common/wallpaper.mojom
[modify] https://crrev.com/533be7ef1063d285008913c9784d8d852055c8bd/components/arc/intent_helper/arc_intent_helper_bridge.cc
[modify] https://crrev.com/533be7ef1063d285008913c9784d8d852055c8bd/components/arc/intent_helper/arc_intent_helper_bridge.h
[modify] https://crrev.com/533be7ef1063d285008913c9784d8d852055c8bd/components/arc/set_wallpaper_delegate.h

Project Member

Comment 2 by bugdroid1@chromium.org, Sep 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9aea000394714d2fbb20850021f6204f2256b9cf

commit 9aea000394714d2fbb20850021f6204f2256b9cf
Author: kbr <kbr@chromium.org>
Date: Thu Sep 08 23:28:13 2016

Revert of cheets: implement cros side of WallpaperManagerService. (patchset #16 id:300001 of https://codereview.chromium.org/2264743002/ )

Reason for revert:
Broke the build. Not sure how this made it past the CQ:
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Builder/builds/45818

Original issue's description:
> cheets: implement cros side of WallpaperManagerService.
>
> Rename ArcWallpaperHandler to ArcWallpaperService and implement it as an ArcService, which handles WallpaperManager API from Android.
>
> Test=Manually open PickMyWallpaper app and set wallpaper
> Test=run cts android.content.cts.ContextWrapperTest
>
> Bug= 642465 
>
> Committed: https://crrev.com/533be7ef1063d285008913c9784d8d852055c8bd
> Cr-Commit-Position: refs/heads/master@{#417428}

TBR=xiaohuic@chromium.org,xiyuan@chromium.org,nya@chromium.org,lhchavez@chromium.org,hidehiko@chromium.org,dcheng@chromium.org,yusukes@chromium.org,muyuanli@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Bug= 642465 

Review-Url: https://codereview.chromium.org/2320323002
Cr-Commit-Position: refs/heads/master@{#417431}

[modify] https://crrev.com/9aea000394714d2fbb20850021f6204f2256b9cf/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/9aea000394714d2fbb20850021f6204f2256b9cf/chrome/browser/chromeos/arc/arc_service_launcher.cc
[add] https://crrev.com/9aea000394714d2fbb20850021f6204f2256b9cf/chrome/browser/chromeos/arc/arc_wallpaper_handler.cc
[add] https://crrev.com/9aea000394714d2fbb20850021f6204f2256b9cf/chrome/browser/chromeos/arc/arc_wallpaper_handler.h
[delete] https://crrev.com/8ccc7ad89e21c857ab2b317a4875c881cf4fcf35/chrome/browser/chromeos/arc/arc_wallpaper_service.cc
[delete] https://crrev.com/8ccc7ad89e21c857ab2b317a4875c881cf4fcf35/chrome/browser/chromeos/arc/arc_wallpaper_service.h
[modify] https://crrev.com/9aea000394714d2fbb20850021f6204f2256b9cf/components/arc/BUILD.gn
[modify] https://crrev.com/9aea000394714d2fbb20850021f6204f2256b9cf/components/arc/arc_bridge_host_impl.cc
[modify] https://crrev.com/9aea000394714d2fbb20850021f6204f2256b9cf/components/arc/arc_bridge_host_impl.h
[modify] https://crrev.com/9aea000394714d2fbb20850021f6204f2256b9cf/components/arc/arc_bridge_service.h
[modify] https://crrev.com/9aea000394714d2fbb20850021f6204f2256b9cf/components/arc/common/arc_bridge.mojom
[delete] https://crrev.com/8ccc7ad89e21c857ab2b317a4875c881cf4fcf35/components/arc/common/wallpaper.mojom
[modify] https://crrev.com/9aea000394714d2fbb20850021f6204f2256b9cf/components/arc/intent_helper/arc_intent_helper_bridge.cc
[modify] https://crrev.com/9aea000394714d2fbb20850021f6204f2256b9cf/components/arc/intent_helper/arc_intent_helper_bridge.h
[modify] https://crrev.com/9aea000394714d2fbb20850021f6204f2256b9cf/components/arc/set_wallpaper_delegate.h

Project Member

Comment 3 by bugdroid1@chromium.org, Sep 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf98813246a297671602f6aaf435a9c0a43141a7

commit bf98813246a297671602f6aaf435a9c0a43141a7
Author: muyuanli <muyuanli@chromium.org>
Date: Fri Sep 09 17:38:45 2016

[Reland] cheets: implement cros side of WallpaperManager API.

This reverts "Revert of cheets: implement cros side of
WallpaperManagerService."
commit 9aea000394714d2fbb20850021f6204f2256b9cf.

This fixes build for (patchset 16 id:300001 of
https://codereview.chromium.org/2264743002/ ) which was broken due to
commit queue conflict.

TBR=xiaohuic@chromium.org,xiyuan@chromium.org,nya@chromium.org,lhchavez@chromium.org,hidehiko@chromium.org,dcheng@chromium.org,yusukes@chromium.org,muyuanli@chromium.org
BUG= 642465 

Review-Url: https://codereview.chromium.org/2328903002
Cr-Commit-Position: refs/heads/master@{#417618}

[modify] https://crrev.com/bf98813246a297671602f6aaf435a9c0a43141a7/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/bf98813246a297671602f6aaf435a9c0a43141a7/chrome/browser/chromeos/arc/arc_service_launcher.cc
[delete] https://crrev.com/784074ddf233db0252f47717636452e34e3d84ec/chrome/browser/chromeos/arc/arc_wallpaper_handler.cc
[delete] https://crrev.com/784074ddf233db0252f47717636452e34e3d84ec/chrome/browser/chromeos/arc/arc_wallpaper_handler.h
[add] https://crrev.com/bf98813246a297671602f6aaf435a9c0a43141a7/chrome/browser/chromeos/arc/arc_wallpaper_service.cc
[add] https://crrev.com/bf98813246a297671602f6aaf435a9c0a43141a7/chrome/browser/chromeos/arc/arc_wallpaper_service.h
[modify] https://crrev.com/bf98813246a297671602f6aaf435a9c0a43141a7/components/arc/BUILD.gn
[modify] https://crrev.com/bf98813246a297671602f6aaf435a9c0a43141a7/components/arc/arc_bridge_host_impl.cc
[modify] https://crrev.com/bf98813246a297671602f6aaf435a9c0a43141a7/components/arc/arc_bridge_host_impl.h
[modify] https://crrev.com/bf98813246a297671602f6aaf435a9c0a43141a7/components/arc/arc_bridge_service.h
[modify] https://crrev.com/bf98813246a297671602f6aaf435a9c0a43141a7/components/arc/common/arc_bridge.mojom
[add] https://crrev.com/bf98813246a297671602f6aaf435a9c0a43141a7/components/arc/common/wallpaper.mojom
[modify] https://crrev.com/bf98813246a297671602f6aaf435a9c0a43141a7/components/arc/intent_helper/arc_intent_helper_bridge.cc
[modify] https://crrev.com/bf98813246a297671602f6aaf435a9c0a43141a7/components/arc/intent_helper/arc_intent_helper_bridge.h
[modify] https://crrev.com/bf98813246a297671602f6aaf435a9c0a43141a7/components/arc/set_wallpaper_delegate.h

Project Member

Comment 4 by bugdroid1@chromium.org, Sep 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/063754cbba42aaa1f7ea51e16328c5d60971127d

commit 063754cbba42aaa1f7ea51e16328c5d60971127d
Author: muyuanli <muyuanli@chromium.org>
Date: Fri Sep 16 22:30:10 2016

cheets: add wallpaper observer to arc_wallpaper_service.

ArcWallpaperService now observes wallpaper change
and notifies Android, which will use it to broadcast
ACTION_WALLPAPER_CHANGED.

Test=Change wallpaper with CrOS wallpaper picker
  and verify with Android app that listens wallpaper
  changed broadcast.

Bug= 642465 

Review-Url: https://codereview.chromium.org/2345153002
Cr-Commit-Position: refs/heads/master@{#419303}

[modify] https://crrev.com/063754cbba42aaa1f7ea51e16328c5d60971127d/chrome/browser/chromeos/arc/arc_wallpaper_service.cc
[modify] https://crrev.com/063754cbba42aaa1f7ea51e16328c5d60971127d/chrome/browser/chromeos/arc/arc_wallpaper_service.h
[modify] https://crrev.com/063754cbba42aaa1f7ea51e16328c5d60971127d/components/arc/common/wallpaper.mojom

Project Member

Comment 5 by bugdroid1@chromium.org, Sep 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d84782e1c6feb94dd33da0914c4b67f70e80e3cf

commit d84782e1c6feb94dd33da0914c4b67f70e80e3cf
Author: muyuanli <muyuanli@chromium.org>
Date: Thu Sep 22 20:19:10 2016

cheets: switch arc wallpaper layout to CENTER_CROPPED.

Android wallpapers seem to be always center cropped that
when wallpaper dimensions differ from the current
workspace dimensions, it resizes to fill the screen
while preserving aspect ratio and letting part of it to
be cropped. This avoids bugs like b/31653316.

BUG= 642465 
Test=Setting wallpaper functions as expected.

Review-Url: https://codereview.chromium.org/2359043002
Cr-Commit-Position: refs/heads/master@{#420441}

[modify] https://crrev.com/d84782e1c6feb94dd33da0914c4b67f70e80e3cf/chrome/browser/chromeos/arc/arc_wallpaper_service.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Sep 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d84782e1c6feb94dd33da0914c4b67f70e80e3cf

commit d84782e1c6feb94dd33da0914c4b67f70e80e3cf
Author: muyuanli <muyuanli@chromium.org>
Date: Thu Sep 22 20:19:10 2016

cheets: switch arc wallpaper layout to CENTER_CROPPED.

Android wallpapers seem to be always center cropped that
when wallpaper dimensions differ from the current
workspace dimensions, it resizes to fill the screen
while preserving aspect ratio and letting part of it to
be cropped. This avoids bugs like b/31653316.

BUG= 642465 
Test=Setting wallpaper functions as expected.

Review-Url: https://codereview.chromium.org/2359043002
Cr-Commit-Position: refs/heads/master@{#420441}

[modify] https://crrev.com/d84782e1c6feb94dd33da0914c4b67f70e80e3cf/chrome/browser/chromeos/arc/arc_wallpaper_service.cc

Status: Fixed (was: Assigned)

Comment 8 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment