New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 642460 link

Starred by 1 user
Status: Fixed
Owner:
█ robhogan@chromium.org
Use other robhogan account instead.
Closed: Feb 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

Don't select ellipsis

Reported by laukst...@gmail.com, Aug 30 2016 
UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/52.0.2743.116 Safari/537.36

Steps to reproduce the problem:
1. Test-case https://output.jsbin.com/rorafa/quiet
2. Ctr+A
Related  Issue #634445 .

What is the expected behavior?
Be consistent with other browsers and don't select text ellipsis.

Webkit/Blink seems the only engines that on selecting text selects also ellipsis, Firefox, Edge and IE since early days don't select ellipsis.
Don't select ellipsis approach is reasonable in order to avoid user think/confuse that text (ellipsis) Copy would copy the ellipsis itself - it instead copies the text behind it.

What went wrong?
Ellipsis mustn't be selected.

Did this work before? No 

Chrome version: 55.0.2844.0  Channel: canary
OS Version: 10.0
Flash Version: Shockwave Flash 22.0 r0
selected-ellipsis.png
127 KB View Download

Comment 1 by robho...@gmail.com, Aug 30 2016

Owner: robhogan@chromium.org
Status: Assigned (was: Unconfirmed)
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 17 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b066a99dbd93ff5ceed0f9488a2e9737138434d4

commit b066a99dbd93ff5ceed0f9488a2e9737138434d4
Author: robhogan <robhogan@gmail.com>
Date: Sat Sep 17 19:43:28 2016

Don't paint ellipsis selection

FF and Edge don't paint a selection on the ellipsis.

BUG= 642460 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2340533002
Cr-Commit-Position: refs/heads/master@{#419379}

[modify] https://crrev.com/b066a99dbd93ff5ceed0f9488a2e9737138434d4/third_party/WebKit/LayoutTests/fast/css/text-overflow-ellipsis-vertical-select-expected.html
[modify] https://crrev.com/b066a99dbd93ff5ceed0f9488a2e9737138434d4/third_party/WebKit/LayoutTests/platform/linux/editing/selection/select-text-overflow-ellipsis-expected.png
[modify] https://crrev.com/b066a99dbd93ff5ceed0f9488a2e9737138434d4/third_party/WebKit/LayoutTests/platform/linux/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-expected.png
[modify] https://crrev.com/b066a99dbd93ff5ceed0f9488a2e9737138434d4/third_party/WebKit/LayoutTests/platform/linux/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-expected.png
[modify] https://crrev.com/b066a99dbd93ff5ceed0f9488a2e9737138434d4/third_party/WebKit/LayoutTests/platform/mac/editing/selection/select-text-overflow-ellipsis-expected.png
[modify] https://crrev.com/b066a99dbd93ff5ceed0f9488a2e9737138434d4/third_party/WebKit/LayoutTests/platform/mac/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-expected.png
[modify] https://crrev.com/b066a99dbd93ff5ceed0f9488a2e9737138434d4/third_party/WebKit/LayoutTests/platform/mac/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-expected.png
[modify] https://crrev.com/b066a99dbd93ff5ceed0f9488a2e9737138434d4/third_party/WebKit/LayoutTests/platform/win/editing/selection/select-text-overflow-ellipsis-expected.png
[modify] https://crrev.com/b066a99dbd93ff5ceed0f9488a2e9737138434d4/third_party/WebKit/LayoutTests/platform/win/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-expected.png
[modify] https://crrev.com/b066a99dbd93ff5ceed0f9488a2e9737138434d4/third_party/WebKit/LayoutTests/platform/win/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-expected.png
[modify] https://crrev.com/b066a99dbd93ff5ceed0f9488a2e9737138434d4/third_party/WebKit/Source/core/paint/EllipsisBoxPainter.cpp
[modify] https://crrev.com/b066a99dbd93ff5ceed0f9488a2e9737138434d4/third_party/WebKit/Source/core/paint/EllipsisBoxPainter.h

Comment 3 by laukst...@gmail.com, Sep 25 2016 

Now sometimes the first dot of ellipsis is selected too, while whole ellipsis mustn't be selected. See the attached screenshot.

In additional I noticed that often is displayed 2 dots ellipsis instead of 3 "...", open  Issue #650083  for it.

Tested on Chrome canary 55.0.2870.0 64-bit
select-ellipsis.png
41.9 KB View Download

Comment 4 by laukst...@gmail.com, Sep 25 2016 

It seems to be related to  Issue #642454 , still actual to this  Issue #642460  too.
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 4 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8691b058b8f8570128d24b4af3c43b3e2c0151e4

commit 8691b058b8f8570128d24b4af3c43b3e2c0151e4
Author: robhogan <robhogan@gmail.com>
Date: Wed Jan 04 22:21:01 2017

Don't paint underline or selections over ellipsis in mixed-flow contexts

Also, ensure the selected text is painted correctly when an ellipsis is present
in a mixed-flow context (e.g. ltr text in an rtl container).

BUG= 642454 ,  642450 ,  642460 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2594983002
Cr-Commit-Position: refs/heads/master@{#441486}

[modify] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-expected.png
[add] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-expected.txt
[add] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-ltr-mixed-expected.png
[add] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-ltr-mixed-expected.txt
[add] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-ltr-mixed.html
[add] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-expected.png
[add] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-expected.txt
[add] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-mixed-expected.png
[add] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-mixed-expected.txt
[add] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-mixed.html
[add] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl.html
[add] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping.html
[add] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-2-expected.png
[add] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-2-expected.txt
[add] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-2.html
[add] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-2-expected.png
[add] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-2-expected.txt
[add] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-2.html
[add] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-2-expected.png
[add] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-2-expected.txt
[add] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-2.html
[add] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-rtl-flow-underline-2-expected.png
[add] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-rtl-flow-underline-2-expected.txt
[add] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-rtl-flow-underline-2.html
[modify] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/LayoutTests/platform/linux/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-expected.png
[modify] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/LayoutTests/platform/linux/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-expected.png
[modify] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp
[modify] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/Source/core/paint/TextPainter.cpp
[modify] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/Source/core/paint/TextPainter.h
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1142d494094d29842cf057bf032c0f3985d7060d

commit 1142d494094d29842cf057bf032c0f3985d7060d
Author: loyso <loyso@chromium.org>
Date: Thu Jan 05 06:31:03 2017

Revert of Don't paint underline or selections over ellipsis in mixed-flow contexts (patchset #3 id:40001 of https://codereview.chromium.org/2594983002/ )

Reason for revert:
Causes test failures on Win10 Win7 bots:
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win10/builds/18739

webkit_tests webkit_tests

unexpected_failures:
fast/forms/select/menulist-appearance-basic.html
fast/forms/select/menulist-style-color.html
fast/forms/select/select-selected.html
fast/forms/select/menulist-width-change.html
fast/forms/select/option-text-clip.html
fast/forms/select/option-script.html
fast/forms/select/option-strip-whitespace.html
fast/forms/color/input-appearance-color.html
fast/forms/select/select-dirty-parent-pref-widths.html
fast/forms/select/select-initial-position.html
fast/forms/select/menulist-deselect-update.html
fast/forms/select/select-change-listbox-to-popup.html
fast/forms/select/select-background-none.html
fast/forms/select/menulist-update-text-popup.html
fast/forms/select/select-baseline.html

Original issue's description:
> Don't paint underline or selections over ellipsis in mixed-flow contexts
>
> Also, ensure the selected text is painted correctly when an ellipsis is present
> in a mixed-flow context (e.g. ltr text in an rtl container).
>
> BUG= 642454 ,  642450 ,  642460 
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
>
> Committed: https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4
> Cr-Commit-Position: refs/heads/master@{#441486}

TBR=eae@chromium.org,szager@chromium.org,robhogan@gmail.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 642454 ,  642450 ,  642460 

Review-Url: https://codereview.chromium.org/2615843002
Cr-Commit-Position: refs/heads/master@{#441599}

[modify] https://crrev.com/1142d494094d29842cf057bf032c0f3985d7060d/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-expected.png
[delete] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-expected.txt
[delete] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-ltr-mixed-expected.png
[delete] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-ltr-mixed-expected.txt
[delete] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-ltr-mixed.html
[delete] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-expected.png
[delete] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-expected.txt
[delete] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-mixed-expected.png
[delete] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-mixed-expected.txt
[delete] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-mixed.html
[delete] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl.html
[delete] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping.html
[delete] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-2-expected.png
[delete] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-2-expected.txt
[delete] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-2.html
[delete] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-2-expected.png
[delete] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-2-expected.txt
[delete] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-2.html
[delete] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-2-expected.png
[delete] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-2-expected.txt
[delete] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-2.html
[delete] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-rtl-flow-underline-2-expected.png
[delete] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-rtl-flow-underline-2-expected.txt
[delete] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-rtl-flow-underline-2.html
[modify] https://crrev.com/1142d494094d29842cf057bf032c0f3985d7060d/third_party/WebKit/LayoutTests/platform/linux/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-expected.png
[modify] https://crrev.com/1142d494094d29842cf057bf032c0f3985d7060d/third_party/WebKit/LayoutTests/platform/linux/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-expected.png
[modify] https://crrev.com/1142d494094d29842cf057bf032c0f3985d7060d/third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp
[modify] https://crrev.com/1142d494094d29842cf057bf032c0f3985d7060d/third_party/WebKit/Source/core/paint/TextPainter.cpp
[modify] https://crrev.com/1142d494094d29842cf057bf032c0f3985d7060d/third_party/WebKit/Source/core/paint/TextPainter.h
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/495d8354acfb5558725043afc033074934d4fd04

commit 495d8354acfb5558725043afc033074934d4fd04
Author: robhogan <robhogan@gmail.com>
Date: Thu Jan 05 22:49:31 2017

Reland of Don't paint underline or selections over ellipsis in mixed-flow contexts (patchset #1 id:1 of https://codereview.chromium.org/2615843002/ )

Reason for revert:
This patch was not the culprit for the layout test failures.

Original issue's description:
> Revert of Don't paint underline or selections over ellipsis in mixed-flow contexts (patchset #3 id:40001 of https://codereview.chromium.org/2594983002/ )
>
> Reason for revert:
> Causes test failures on Win10 Win7 bots:
> https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win10/builds/18739
>
> webkit_tests webkit_tests
>
> unexpected_failures:
> fast/forms/select/menulist-appearance-basic.html
> fast/forms/select/menulist-style-color.html
> fast/forms/select/select-selected.html
> fast/forms/select/menulist-width-change.html
> fast/forms/select/option-text-clip.html
> fast/forms/select/option-script.html
> fast/forms/select/option-strip-whitespace.html
> fast/forms/color/input-appearance-color.html
> fast/forms/select/select-dirty-parent-pref-widths.html
> fast/forms/select/select-initial-position.html
> fast/forms/select/menulist-deselect-update.html
> fast/forms/select/select-change-listbox-to-popup.html
> fast/forms/select/select-background-none.html
> fast/forms/select/menulist-update-text-popup.html
> fast/forms/select/select-baseline.html
>
> Original issue's description:
> > Don't paint underline or selections over ellipsis in mixed-flow contexts
> >
> > Also, ensure the selected text is painted correctly when an ellipsis is present
> > in a mixed-flow context (e.g. ltr text in an rtl container).
> >
> > BUG= 642454 ,  642450 ,  642460 
> > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> >
> > Committed: https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4
> > Cr-Commit-Position: refs/heads/master@{#441486}
>
> TBR=eae@chromium.org,szager@chromium.org,robhogan@gmail.com
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG= 642454 ,  642450 ,  642460 
>
> Committed: https://crrev.com/1142d494094d29842cf057bf032c0f3985d7060d
> Cr-Commit-Position: refs/heads/master@{#441599}

TBR=eae@chromium.org,szager@chromium.org,loyso@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 642454 ,  642450 ,  642460 

Review-Url: https://codereview.chromium.org/2611233002
Cr-Commit-Position: refs/heads/master@{#441775}

[modify] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-expected.png
[add] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-expected.txt
[add] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-ltr-mixed-expected.png
[add] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-ltr-mixed-expected.txt
[add] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-ltr-mixed.html
[add] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-expected.png
[add] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-expected.txt
[add] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-mixed-expected.png
[add] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-mixed-expected.txt
[add] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-mixed.html
[add] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl.html
[add] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping.html
[add] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-2-expected.png
[add] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-2-expected.txt
[add] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-2.html
[add] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-2-expected.png
[add] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-2-expected.txt
[add] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-2.html
[add] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-2-expected.png
[add] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-2-expected.txt
[add] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-2.html
[add] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-rtl-flow-underline-2-expected.png
[add] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-rtl-flow-underline-2-expected.txt
[add] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-rtl-flow-underline-2.html
[modify] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/LayoutTests/platform/linux/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-expected.png
[modify] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/LayoutTests/platform/linux/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-expected.png
[modify] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp
[modify] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/Source/core/paint/TextPainter.cpp
[modify] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/Source/core/paint/TextPainter.h

Comment 8 by robhogan@chromium.org, Feb 18 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment