UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/52.0.2743.116 Safari/537.36 Steps to reproduce the problem: 1. Test-case https://output.jsbin.com/rorafa/quiet Related Issue #634445 . What is the expected behavior? The select background-color must remain the same color - doesn't depend first or last character, etc. What went wrong? Select background-color Did this work before? Yes Chrome 52.0.2722.0 Chrome version: 55.0.2844.0 Channel: canary OS Version: 10.0 Flash Version: Shockwave Flash 22.0 r0 Bug since Chrome 52.0.2723.0 CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/2aaedda2430ecad19a8ac4427c145d1b093f3df9..11d39c1b27d7c35d9196edbfc7e82a3551c9eec8
We don't select the ellipsis anymore, so remaining work will be tracked under 642640.
642460 rather.
This issue isn't jet fixed, instead the first dot "." is selected once. Please reopen it and take a look more carefully, see the attachment. By selecting trough Ctr+A, some ellipsis first dot is still selected (same mentioned in https://bugs.chromium.org/p/chromium/issues/detail?id=642460#c3). Test-case https://output.jsbin.com/rorafa/quiet Tested on Chrome canary 57.0.2951.0
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8691b058b8f8570128d24b4af3c43b3e2c0151e4 commit 8691b058b8f8570128d24b4af3c43b3e2c0151e4 Author: robhogan <robhogan@gmail.com> Date: Wed Jan 04 22:21:01 2017 Don't paint underline or selections over ellipsis in mixed-flow contexts Also, ensure the selected text is painted correctly when an ellipsis is present in a mixed-flow context (e.g. ltr text in an rtl container). BUG= 642454 , 642450 , 642460 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2594983002 Cr-Commit-Position: refs/heads/master@{#441486} [modify] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/LayoutTests/TestExpectations [add] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-expected.png [add] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-expected.txt [add] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-ltr-mixed-expected.png [add] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-ltr-mixed-expected.txt [add] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-ltr-mixed.html [add] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-expected.png [add] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-expected.txt [add] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-mixed-expected.png [add] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-mixed-expected.txt [add] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-mixed.html [add] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl.html [add] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping.html [add] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-2-expected.png [add] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-2-expected.txt [add] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-2.html [add] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-2-expected.png [add] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-2-expected.txt [add] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-2.html [add] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-2-expected.png [add] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-2-expected.txt [add] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-2.html [add] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-rtl-flow-underline-2-expected.png [add] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-rtl-flow-underline-2-expected.txt [add] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-rtl-flow-underline-2.html [modify] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/LayoutTests/platform/linux/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-expected.png [modify] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/LayoutTests/platform/linux/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-expected.png [modify] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp [modify] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/Source/core/paint/TextPainter.cpp [modify] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/Source/core/paint/TextPainter.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/271ddcb0b4d431af6af349464f7c3a852c970efd commit 271ddcb0b4d431af6af349464f7c3a852c970efd Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org> Date: Thu Jan 05 03:37:01 2017 Auto-rebaseline for r441486 https://chromium.googlesource.com/chromium/src/+/8691b058b8f85 BUG= 642454 TBR=robhogan@gmail.com Review-Url: https://codereview.chromium.org/2612653004 . Cr-Commit-Position: refs/heads/master@{#441571} [modify] https://crrev.com/271ddcb0b4d431af6af349464f7c3a852c970efd/third_party/WebKit/LayoutTests/TestExpectations [rename] https://crrev.com/271ddcb0b4d431af6af349464f7c3a852c970efd/third_party/WebKit/LayoutTests/platform/linux/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-expected.png [rename] https://crrev.com/271ddcb0b4d431af6af349464f7c3a852c970efd/third_party/WebKit/LayoutTests/platform/linux/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-expected.txt [rename] https://crrev.com/271ddcb0b4d431af6af349464f7c3a852c970efd/third_party/WebKit/LayoutTests/platform/linux/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-ltr-mixed-expected.png [rename] https://crrev.com/271ddcb0b4d431af6af349464f7c3a852c970efd/third_party/WebKit/LayoutTests/platform/linux/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-ltr-mixed-expected.txt [rename] https://crrev.com/271ddcb0b4d431af6af349464f7c3a852c970efd/third_party/WebKit/LayoutTests/platform/linux/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-expected.png [rename] https://crrev.com/271ddcb0b4d431af6af349464f7c3a852c970efd/third_party/WebKit/LayoutTests/platform/linux/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-expected.txt [rename] https://crrev.com/271ddcb0b4d431af6af349464f7c3a852c970efd/third_party/WebKit/LayoutTests/platform/linux/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-mixed-expected.png [rename] https://crrev.com/271ddcb0b4d431af6af349464f7c3a852c970efd/third_party/WebKit/LayoutTests/platform/linux/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-mixed-expected.txt [rename] https://crrev.com/271ddcb0b4d431af6af349464f7c3a852c970efd/third_party/WebKit/LayoutTests/platform/linux/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-2-expected.png [rename] https://crrev.com/271ddcb0b4d431af6af349464f7c3a852c970efd/third_party/WebKit/LayoutTests/platform/linux/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-2-expected.txt [rename] https://crrev.com/271ddcb0b4d431af6af349464f7c3a852c970efd/third_party/WebKit/LayoutTests/platform/linux/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-2-expected.png [rename] https://crrev.com/271ddcb0b4d431af6af349464f7c3a852c970efd/third_party/WebKit/LayoutTests/platform/linux/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-2-expected.txt [rename] https://crrev.com/271ddcb0b4d431af6af349464f7c3a852c970efd/third_party/WebKit/LayoutTests/platform/linux/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-2-expected.png [rename] https://crrev.com/271ddcb0b4d431af6af349464f7c3a852c970efd/third_party/WebKit/LayoutTests/platform/linux/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-2-expected.txt [rename] https://crrev.com/271ddcb0b4d431af6af349464f7c3a852c970efd/third_party/WebKit/LayoutTests/platform/linux/fast/text/ellipsis-mixed-text-in-rtl-flow-underline-2-expected.png [rename] https://crrev.com/271ddcb0b4d431af6af349464f7c3a852c970efd/third_party/WebKit/LayoutTests/platform/linux/fast/text/ellipsis-mixed-text-in-rtl-flow-underline-2-expected.txt [add] https://crrev.com/271ddcb0b4d431af6af349464f7c3a852c970efd/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-2-expected.png [modify] https://crrev.com/271ddcb0b4d431af6af349464f7c3a852c970efd/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-expected.png [add] https://crrev.com/271ddcb0b4d431af6af349464f7c3a852c970efd/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/text/ellipsis-mixed-text-in-rtl-flow-underline-2-expected.png [add] https://crrev.com/271ddcb0b4d431af6af349464f7c3a852c970efd/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-2-expected.png [modify] https://crrev.com/271ddcb0b4d431af6af349464f7c3a852c970efd/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-expected.png [add] https://crrev.com/271ddcb0b4d431af6af349464f7c3a852c970efd/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/text/ellipsis-mixed-text-in-rtl-flow-underline-2-expected.png [add] https://crrev.com/271ddcb0b4d431af6af349464f7c3a852c970efd/third_party/WebKit/LayoutTests/platform/mac/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-expected.png [add] https://crrev.com/271ddcb0b4d431af6af349464f7c3a852c970efd/third_party/WebKit/LayoutTests/platform/mac/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-expected.txt [add] https://crrev.com/271ddcb0b4d431af6af349464f7c3a852c970efd/third_party/WebKit/LayoutTests/platform/mac/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-ltr-mixed-expected.png [add] https://crrev.com/271ddcb0b4d431af6af349464f7c3a852c970efd/third_party/WebKit/LayoutTests/platform/mac/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-ltr-mixed-expected.txt [add] https://crrev.com/271ddcb0b4d431af6af349464f7c3a852c970efd/third_party/WebKit/LayoutTests/platform/mac/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-expected.png [add] https://crrev.com/271ddcb0b4d431af6af349464f7c3a852c970efd/third_party/WebKit/LayoutTests/platform/mac/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-expected.txt [add] https://crrev.com/271ddcb0b4d431af6af349464f7c3a852c970efd/third_party/WebKit/LayoutTests/platform/mac/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-mixed-expected.png [add] https://crrev.com/271ddcb0b4d431af6af349464f7c3a852c970efd/third_party/WebKit/LayoutTests/platform/mac/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-mixed-expected.txt [add] https://crrev.com/271ddcb0b4d431af6af349464f7c3a852c970efd/third_party/WebKit/LayoutTests/platform/mac/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-2-expected.png [add] https://crrev.com/271ddcb0b4d431af6af349464f7c3a852c970efd/third_party/WebKit/LayoutTests/platform/mac/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-2-expected.txt [modify] https://crrev.com/271ddcb0b4d431af6af349464f7c3a852c970efd/third_party/WebKit/LayoutTests/platform/mac/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-expected.png [add] https://crrev.com/271ddcb0b4d431af6af349464f7c3a852c970efd/third_party/WebKit/LayoutTests/platform/mac/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-2-expected.png [add] https://crrev.com/271ddcb0b4d431af6af349464f7c3a852c970efd/third_party/WebKit/LayoutTests/platform/mac/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-2-expected.txt [modify] https://crrev.com/271ddcb0b4d431af6af349464f7c3a852c970efd/third_party/WebKit/LayoutTests/platform/mac/fast/css/text-overflow-ellipsis-expected.png [modify] https://crrev.com/271ddcb0b4d431af6af349464f7c3a852c970efd/third_party/WebKit/LayoutTests/platform/mac/fast/css/text-overflow-ellipsis-strict-expected.png [add] https://crrev.com/271ddcb0b4d431af6af349464f7c3a852c970efd/third_party/WebKit/LayoutTests/platform/mac/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-2-expected.png [add] https://crrev.com/271ddcb0b4d431af6af349464f7c3a852c970efd/third_party/WebKit/LayoutTests/platform/mac/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-2-expected.txt [modify] https://crrev.com/271ddcb0b4d431af6af349464f7c3a852c970efd/third_party/WebKit/LayoutTests/platform/mac/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-expected.png [add] https://crrev.com/271ddcb0b4d431af6af349464f7c3a852c970efd/third_party/WebKit/LayoutTests/platform/mac/fast/text/ellipsis-mixed-text-in-rtl-flow-underline-2-expected.png [add] https://crrev.com/271ddcb0b4d431af6af349464f7c3a852c970efd/third_party/WebKit/LayoutTests/platform/mac/fast/text/ellipsis-mixed-text-in-rtl-flow-underline-2-expected.txt [add] https://crrev.com/271ddcb0b4d431af6af349464f7c3a852c970efd/third_party/WebKit/LayoutTests/platform/win/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-expected.png [add] https://crrev.com/271ddcb0b4d431af6af349464f7c3a852c970efd/third_party/WebKit/LayoutTests/platform/win/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-expected.txt [add] https://crrev.com/271ddcb0b4d431af6af349464f7c3a852c970efd/third_party/WebKit/LayoutTests/platform/win/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-ltr-mixed-expected.png [add] https://crrev.com/271ddcb0b4d431af6af349464f7c3a852c970efd/third_party/WebKit/LayoutTests/platform/win/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-ltr-mixed-expected.txt [add] https://crrev.com/271ddcb0b4d431af6af349464f7c3a852c970efd/third_party/WebKit/LayoutTests/platform/win/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-expected.png [add] https://crrev.com/271ddcb0b4d431af6af349464f7c3a852c970efd/third_party/WebKit/LayoutTests/platform/win/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-expected.txt [add] https://crrev.com/271ddcb0b4d431af6af349464f7c3a852c970efd/third_party/WebKit/LayoutTests/platform/win/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-mixed-expected.png [add] https://crrev.com/271ddcb0b4d431af6af349464f7c3a852c970efd/third_party/WebKit/LayoutTests/platform/win/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-mixed-expected.txt [add] https://crrev.com/271ddcb0b4d431af6af349464f7c3a852c970efd/third_party/WebKit/LayoutTests/platform/win/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-2-expected.png [add] https://crrev.com/271ddcb0b4d431af6af349464f7c3a852c970efd/third_party/WebKit/LayoutTests/platform/win/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-2-expected.txt [modify] https://crrev.com/271ddcb0b4d431af6af349464f7c3a852c970efd/third_party/WebKit/LayoutTests/platform/win/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-expected.png [add] https://crrev.com/271ddcb0b4d431af6af349464f7c3a852c970efd/third_party/WebKit/LayoutTests/platform/win/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-2-expected.png [add] https://crrev.com/271ddcb0b4d431af6af349464f7c3a852c970efd/third_party/WebKit/LayoutTests/platform/win/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-2-expected.txt [modify] https://crrev.com/271ddcb0b4d431af6af349464f7c3a852c970efd/third_party/WebKit/LayoutTests/platform/win/fast/css/text-overflow-ellipsis-expected.png [modify] https://crrev.com/271ddcb0b4d431af6af349464f7c3a852c970efd/third_party/WebKit/LayoutTests/platform/win/fast/css/text-overflow-ellipsis-strict-expected.png [add] https://crrev.com/271ddcb0b4d431af6af349464f7c3a852c970efd/third_party/WebKit/LayoutTests/platform/win/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-2-expected.png [add] https://crrev.com/271ddcb0b4d431af6af349464f7c3a852c970efd/third_party/WebKit/LayoutTests/platform/win/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-2-expected.txt [modify] https://crrev.com/271ddcb0b4d431af6af349464f7c3a852c970efd/third_party/WebKit/LayoutTests/platform/win/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-expected.png [add] https://crrev.com/271ddcb0b4d431af6af349464f7c3a852c970efd/third_party/WebKit/LayoutTests/platform/win/fast/text/ellipsis-mixed-text-in-rtl-flow-underline-2-expected.png [add] https://crrev.com/271ddcb0b4d431af6af349464f7c3a852c970efd/third_party/WebKit/LayoutTests/platform/win/fast/text/ellipsis-mixed-text-in-rtl-flow-underline-2-expected.txt
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30 commit 9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30 Author: loyso <loyso@chromium.org> Date: Thu Jan 05 06:29:04 2017 Revert of Auto-rebaseline for r441486 (patchset #1 id:1 of https://codereview.chromium.org/2612653004/ ) Reason for revert: Causes test failures on Win10 Win7 bots: https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win10/builds/18739 webkit_tests webkit_tests unexpected_failures: fast/forms/select/menulist-appearance-basic.html fast/forms/select/menulist-style-color.html fast/forms/select/select-selected.html fast/forms/select/menulist-width-change.html fast/forms/select/option-text-clip.html fast/forms/select/option-script.html fast/forms/select/option-strip-whitespace.html fast/forms/color/input-appearance-color.html fast/forms/select/select-dirty-parent-pref-widths.html fast/forms/select/select-initial-position.html fast/forms/select/menulist-deselect-update.html fast/forms/select/select-change-listbox-to-popup.html fast/forms/select/select-background-none.html fast/forms/select/menulist-update-text-popup.html fast/forms/select/select-baseline.html. Original issue's description: > Auto-rebaseline for r441486 > > https://chromium.googlesource.com/chromium/src/+/8691b058b8f85 > > BUG= 642454 > TBR=robhogan@gmail.com > > Committed: https://chromium.googlesource.com/chromium/src/+/271ddcb0b4d431af6af349464f7c3a852c970efd TBR=robhogan@gmail.com,blink-rebaseline-bot@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 642454 Review-Url: https://codereview.chromium.org/2615603004 Cr-Commit-Position: refs/heads/master@{#441598} [modify] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/TestExpectations [rename] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-expected.png [rename] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-expected.txt [rename] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-ltr-mixed-expected.png [rename] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-ltr-mixed-expected.txt [rename] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-expected.png [rename] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-expected.txt [rename] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-mixed-expected.png [rename] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-mixed-expected.txt [rename] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-2-expected.png [rename] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-2-expected.txt [rename] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-2-expected.png [rename] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-2-expected.txt [rename] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-2-expected.png [rename] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-2-expected.txt [rename] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-rtl-flow-underline-2-expected.png [rename] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-rtl-flow-underline-2-expected.txt [delete] https://crrev.com/b141b2dbaf241b4b9da254954a008f4ad2340172/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-2-expected.png [modify] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-expected.png [delete] https://crrev.com/b141b2dbaf241b4b9da254954a008f4ad2340172/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/text/ellipsis-mixed-text-in-rtl-flow-underline-2-expected.png [delete] https://crrev.com/b141b2dbaf241b4b9da254954a008f4ad2340172/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-2-expected.png [modify] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-expected.png [delete] https://crrev.com/b141b2dbaf241b4b9da254954a008f4ad2340172/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/text/ellipsis-mixed-text-in-rtl-flow-underline-2-expected.png [delete] https://crrev.com/b141b2dbaf241b4b9da254954a008f4ad2340172/third_party/WebKit/LayoutTests/platform/mac/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-expected.png [delete] https://crrev.com/b141b2dbaf241b4b9da254954a008f4ad2340172/third_party/WebKit/LayoutTests/platform/mac/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-expected.txt [delete] https://crrev.com/b141b2dbaf241b4b9da254954a008f4ad2340172/third_party/WebKit/LayoutTests/platform/mac/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-ltr-mixed-expected.png [delete] https://crrev.com/b141b2dbaf241b4b9da254954a008f4ad2340172/third_party/WebKit/LayoutTests/platform/mac/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-ltr-mixed-expected.txt [delete] https://crrev.com/b141b2dbaf241b4b9da254954a008f4ad2340172/third_party/WebKit/LayoutTests/platform/mac/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-expected.png [delete] https://crrev.com/b141b2dbaf241b4b9da254954a008f4ad2340172/third_party/WebKit/LayoutTests/platform/mac/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-expected.txt [delete] https://crrev.com/b141b2dbaf241b4b9da254954a008f4ad2340172/third_party/WebKit/LayoutTests/platform/mac/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-mixed-expected.png [delete] https://crrev.com/b141b2dbaf241b4b9da254954a008f4ad2340172/third_party/WebKit/LayoutTests/platform/mac/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-mixed-expected.txt [delete] https://crrev.com/b141b2dbaf241b4b9da254954a008f4ad2340172/third_party/WebKit/LayoutTests/platform/mac/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-2-expected.png [delete] https://crrev.com/b141b2dbaf241b4b9da254954a008f4ad2340172/third_party/WebKit/LayoutTests/platform/mac/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-2-expected.txt [modify] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/platform/mac/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-expected.png [delete] https://crrev.com/b141b2dbaf241b4b9da254954a008f4ad2340172/third_party/WebKit/LayoutTests/platform/mac/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-2-expected.png [delete] https://crrev.com/b141b2dbaf241b4b9da254954a008f4ad2340172/third_party/WebKit/LayoutTests/platform/mac/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-2-expected.txt [modify] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/platform/mac/fast/css/text-overflow-ellipsis-expected.png [modify] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/platform/mac/fast/css/text-overflow-ellipsis-strict-expected.png [delete] https://crrev.com/b141b2dbaf241b4b9da254954a008f4ad2340172/third_party/WebKit/LayoutTests/platform/mac/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-2-expected.png [delete] https://crrev.com/b141b2dbaf241b4b9da254954a008f4ad2340172/third_party/WebKit/LayoutTests/platform/mac/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-2-expected.txt [modify] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/platform/mac/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-expected.png [delete] https://crrev.com/b141b2dbaf241b4b9da254954a008f4ad2340172/third_party/WebKit/LayoutTests/platform/mac/fast/text/ellipsis-mixed-text-in-rtl-flow-underline-2-expected.png [delete] https://crrev.com/b141b2dbaf241b4b9da254954a008f4ad2340172/third_party/WebKit/LayoutTests/platform/mac/fast/text/ellipsis-mixed-text-in-rtl-flow-underline-2-expected.txt [delete] https://crrev.com/b141b2dbaf241b4b9da254954a008f4ad2340172/third_party/WebKit/LayoutTests/platform/win/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-expected.png [delete] https://crrev.com/b141b2dbaf241b4b9da254954a008f4ad2340172/third_party/WebKit/LayoutTests/platform/win/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-expected.txt [delete] https://crrev.com/b141b2dbaf241b4b9da254954a008f4ad2340172/third_party/WebKit/LayoutTests/platform/win/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-ltr-mixed-expected.png [delete] https://crrev.com/b141b2dbaf241b4b9da254954a008f4ad2340172/third_party/WebKit/LayoutTests/platform/win/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-ltr-mixed-expected.txt [delete] https://crrev.com/b141b2dbaf241b4b9da254954a008f4ad2340172/third_party/WebKit/LayoutTests/platform/win/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-expected.png [delete] https://crrev.com/b141b2dbaf241b4b9da254954a008f4ad2340172/third_party/WebKit/LayoutTests/platform/win/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-expected.txt [delete] https://crrev.com/b141b2dbaf241b4b9da254954a008f4ad2340172/third_party/WebKit/LayoutTests/platform/win/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-mixed-expected.png [delete] https://crrev.com/b141b2dbaf241b4b9da254954a008f4ad2340172/third_party/WebKit/LayoutTests/platform/win/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-mixed-expected.txt [delete] https://crrev.com/b141b2dbaf241b4b9da254954a008f4ad2340172/third_party/WebKit/LayoutTests/platform/win/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-2-expected.png [delete] https://crrev.com/b141b2dbaf241b4b9da254954a008f4ad2340172/third_party/WebKit/LayoutTests/platform/win/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-2-expected.txt [modify] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/platform/win/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-expected.png [delete] https://crrev.com/b141b2dbaf241b4b9da254954a008f4ad2340172/third_party/WebKit/LayoutTests/platform/win/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-2-expected.png [delete] https://crrev.com/b141b2dbaf241b4b9da254954a008f4ad2340172/third_party/WebKit/LayoutTests/platform/win/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-2-expected.txt [modify] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/platform/win/fast/css/text-overflow-ellipsis-expected.png [modify] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/platform/win/fast/css/text-overflow-ellipsis-strict-expected.png [delete] https://crrev.com/b141b2dbaf241b4b9da254954a008f4ad2340172/third_party/WebKit/LayoutTests/platform/win/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-2-expected.png [delete] https://crrev.com/b141b2dbaf241b4b9da254954a008f4ad2340172/third_party/WebKit/LayoutTests/platform/win/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-2-expected.txt [modify] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/platform/win/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-expected.png [delete] https://crrev.com/b141b2dbaf241b4b9da254954a008f4ad2340172/third_party/WebKit/LayoutTests/platform/win/fast/text/ellipsis-mixed-text-in-rtl-flow-underline-2-expected.png [delete] https://crrev.com/b141b2dbaf241b4b9da254954a008f4ad2340172/third_party/WebKit/LayoutTests/platform/win/fast/text/ellipsis-mixed-text-in-rtl-flow-underline-2-expected.txt
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1142d494094d29842cf057bf032c0f3985d7060d commit 1142d494094d29842cf057bf032c0f3985d7060d Author: loyso <loyso@chromium.org> Date: Thu Jan 05 06:31:03 2017 Revert of Don't paint underline or selections over ellipsis in mixed-flow contexts (patchset #3 id:40001 of https://codereview.chromium.org/2594983002/ ) Reason for revert: Causes test failures on Win10 Win7 bots: https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win10/builds/18739 webkit_tests webkit_tests unexpected_failures: fast/forms/select/menulist-appearance-basic.html fast/forms/select/menulist-style-color.html fast/forms/select/select-selected.html fast/forms/select/menulist-width-change.html fast/forms/select/option-text-clip.html fast/forms/select/option-script.html fast/forms/select/option-strip-whitespace.html fast/forms/color/input-appearance-color.html fast/forms/select/select-dirty-parent-pref-widths.html fast/forms/select/select-initial-position.html fast/forms/select/menulist-deselect-update.html fast/forms/select/select-change-listbox-to-popup.html fast/forms/select/select-background-none.html fast/forms/select/menulist-update-text-popup.html fast/forms/select/select-baseline.html Original issue's description: > Don't paint underline or selections over ellipsis in mixed-flow contexts > > Also, ensure the selected text is painted correctly when an ellipsis is present > in a mixed-flow context (e.g. ltr text in an rtl container). > > BUG= 642454 , 642450 , 642460 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > > Committed: https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4 > Cr-Commit-Position: refs/heads/master@{#441486} TBR=eae@chromium.org,szager@chromium.org,robhogan@gmail.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 642454 , 642450 , 642460 Review-Url: https://codereview.chromium.org/2615843002 Cr-Commit-Position: refs/heads/master@{#441599} [modify] https://crrev.com/1142d494094d29842cf057bf032c0f3985d7060d/third_party/WebKit/LayoutTests/TestExpectations [delete] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-expected.png [delete] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-expected.txt [delete] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-ltr-mixed-expected.png [delete] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-ltr-mixed-expected.txt [delete] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-ltr-mixed.html [delete] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-expected.png [delete] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-expected.txt [delete] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-mixed-expected.png [delete] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-mixed-expected.txt [delete] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-mixed.html [delete] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl.html [delete] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping.html [delete] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-2-expected.png [delete] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-2-expected.txt [delete] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-2.html [delete] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-2-expected.png [delete] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-2-expected.txt [delete] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-2.html [delete] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-2-expected.png [delete] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-2-expected.txt [delete] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-2.html [delete] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-rtl-flow-underline-2-expected.png [delete] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-rtl-flow-underline-2-expected.txt [delete] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-rtl-flow-underline-2.html [modify] https://crrev.com/1142d494094d29842cf057bf032c0f3985d7060d/third_party/WebKit/LayoutTests/platform/linux/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-expected.png [modify] https://crrev.com/1142d494094d29842cf057bf032c0f3985d7060d/third_party/WebKit/LayoutTests/platform/linux/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-expected.png [modify] https://crrev.com/1142d494094d29842cf057bf032c0f3985d7060d/third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp [modify] https://crrev.com/1142d494094d29842cf057bf032c0f3985d7060d/third_party/WebKit/Source/core/paint/TextPainter.cpp [modify] https://crrev.com/1142d494094d29842cf057bf032c0f3985d7060d/third_party/WebKit/Source/core/paint/TextPainter.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/495d8354acfb5558725043afc033074934d4fd04 commit 495d8354acfb5558725043afc033074934d4fd04 Author: robhogan <robhogan@gmail.com> Date: Thu Jan 05 22:49:31 2017 Reland of Don't paint underline or selections over ellipsis in mixed-flow contexts (patchset #1 id:1 of https://codereview.chromium.org/2615843002/ ) Reason for revert: This patch was not the culprit for the layout test failures. Original issue's description: > Revert of Don't paint underline or selections over ellipsis in mixed-flow contexts (patchset #3 id:40001 of https://codereview.chromium.org/2594983002/ ) > > Reason for revert: > Causes test failures on Win10 Win7 bots: > https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win10/builds/18739 > > webkit_tests webkit_tests > > unexpected_failures: > fast/forms/select/menulist-appearance-basic.html > fast/forms/select/menulist-style-color.html > fast/forms/select/select-selected.html > fast/forms/select/menulist-width-change.html > fast/forms/select/option-text-clip.html > fast/forms/select/option-script.html > fast/forms/select/option-strip-whitespace.html > fast/forms/color/input-appearance-color.html > fast/forms/select/select-dirty-parent-pref-widths.html > fast/forms/select/select-initial-position.html > fast/forms/select/menulist-deselect-update.html > fast/forms/select/select-change-listbox-to-popup.html > fast/forms/select/select-background-none.html > fast/forms/select/menulist-update-text-popup.html > fast/forms/select/select-baseline.html > > Original issue's description: > > Don't paint underline or selections over ellipsis in mixed-flow contexts > > > > Also, ensure the selected text is painted correctly when an ellipsis is present > > in a mixed-flow context (e.g. ltr text in an rtl container). > > > > BUG= 642454 , 642450 , 642460 > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > > > > Committed: https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4 > > Cr-Commit-Position: refs/heads/master@{#441486} > > TBR=eae@chromium.org,szager@chromium.org,robhogan@gmail.com > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG= 642454 , 642450 , 642460 > > Committed: https://crrev.com/1142d494094d29842cf057bf032c0f3985d7060d > Cr-Commit-Position: refs/heads/master@{#441599} TBR=eae@chromium.org,szager@chromium.org,loyso@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 642454 , 642450 , 642460 Review-Url: https://codereview.chromium.org/2611233002 Cr-Commit-Position: refs/heads/master@{#441775} [modify] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/LayoutTests/TestExpectations [add] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-expected.png [add] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-expected.txt [add] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-ltr-mixed-expected.png [add] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-ltr-mixed-expected.txt [add] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-ltr-mixed.html [add] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-expected.png [add] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-expected.txt [add] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-mixed-expected.png [add] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-mixed-expected.txt [add] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-mixed.html [add] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl.html [add] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping.html [add] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-2-expected.png [add] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-2-expected.txt [add] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-2.html [add] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-2-expected.png [add] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-2-expected.txt [add] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-2.html [add] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-2-expected.png [add] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-2-expected.txt [add] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-2.html [add] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-rtl-flow-underline-2-expected.png [add] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-rtl-flow-underline-2-expected.txt [add] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-rtl-flow-underline-2.html [modify] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/LayoutTests/platform/linux/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-expected.png [modify] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/LayoutTests/platform/linux/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-expected.png [modify] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp [modify] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/Source/core/paint/TextPainter.cpp [modify] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/Source/core/paint/TextPainter.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/71fa7ea8f3180d43e48c6fa7425baa7b6231e66a commit 71fa7ea8f3180d43e48c6fa7425baa7b6231e66a Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org> Date: Fri Jan 06 01:04:13 2017 Auto-rebaseline for r441775 https://chromium.googlesource.com/chromium/src/+/495d8354acfb5 BUG= 642454 TBR=robhogan@gmail.com Review-Url: https://codereview.chromium.org/2613153004 . Cr-Commit-Position: refs/heads/master@{#441777} [modify] https://crrev.com/71fa7ea8f3180d43e48c6fa7425baa7b6231e66a/third_party/WebKit/LayoutTests/TestExpectations [rename] https://crrev.com/71fa7ea8f3180d43e48c6fa7425baa7b6231e66a/third_party/WebKit/LayoutTests/platform/linux/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-expected.png [rename] https://crrev.com/71fa7ea8f3180d43e48c6fa7425baa7b6231e66a/third_party/WebKit/LayoutTests/platform/linux/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-expected.txt [rename] https://crrev.com/71fa7ea8f3180d43e48c6fa7425baa7b6231e66a/third_party/WebKit/LayoutTests/platform/linux/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-ltr-mixed-expected.png [rename] https://crrev.com/71fa7ea8f3180d43e48c6fa7425baa7b6231e66a/third_party/WebKit/LayoutTests/platform/linux/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-ltr-mixed-expected.txt [rename] https://crrev.com/71fa7ea8f3180d43e48c6fa7425baa7b6231e66a/third_party/WebKit/LayoutTests/platform/linux/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-expected.png [rename] https://crrev.com/71fa7ea8f3180d43e48c6fa7425baa7b6231e66a/third_party/WebKit/LayoutTests/platform/linux/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-expected.txt [rename] https://crrev.com/71fa7ea8f3180d43e48c6fa7425baa7b6231e66a/third_party/WebKit/LayoutTests/platform/linux/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-mixed-expected.png [rename] https://crrev.com/71fa7ea8f3180d43e48c6fa7425baa7b6231e66a/third_party/WebKit/LayoutTests/platform/linux/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-mixed-expected.txt [rename] https://crrev.com/71fa7ea8f3180d43e48c6fa7425baa7b6231e66a/third_party/WebKit/LayoutTests/platform/linux/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-2-expected.png [rename] https://crrev.com/71fa7ea8f3180d43e48c6fa7425baa7b6231e66a/third_party/WebKit/LayoutTests/platform/linux/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-2-expected.txt [rename] https://crrev.com/71fa7ea8f3180d43e48c6fa7425baa7b6231e66a/third_party/WebKit/LayoutTests/platform/linux/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-2-expected.png [rename] https://crrev.com/71fa7ea8f3180d43e48c6fa7425baa7b6231e66a/third_party/WebKit/LayoutTests/platform/linux/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-2-expected.txt [rename] https://crrev.com/71fa7ea8f3180d43e48c6fa7425baa7b6231e66a/third_party/WebKit/LayoutTests/platform/linux/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-2-expected.png [rename] https://crrev.com/71fa7ea8f3180d43e48c6fa7425baa7b6231e66a/third_party/WebKit/LayoutTests/platform/linux/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-2-expected.txt [rename] https://crrev.com/71fa7ea8f3180d43e48c6fa7425baa7b6231e66a/third_party/WebKit/LayoutTests/platform/linux/fast/text/ellipsis-mixed-text-in-rtl-flow-underline-2-expected.png [rename] https://crrev.com/71fa7ea8f3180d43e48c6fa7425baa7b6231e66a/third_party/WebKit/LayoutTests/platform/linux/fast/text/ellipsis-mixed-text-in-rtl-flow-underline-2-expected.txt [add] https://crrev.com/71fa7ea8f3180d43e48c6fa7425baa7b6231e66a/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-2-expected.png [modify] https://crrev.com/71fa7ea8f3180d43e48c6fa7425baa7b6231e66a/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-expected.png [add] https://crrev.com/71fa7ea8f3180d43e48c6fa7425baa7b6231e66a/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/text/ellipsis-mixed-text-in-rtl-flow-underline-2-expected.png [add] https://crrev.com/71fa7ea8f3180d43e48c6fa7425baa7b6231e66a/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-2-expected.png [modify] https://crrev.com/71fa7ea8f3180d43e48c6fa7425baa7b6231e66a/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-expected.png [add] https://crrev.com/71fa7ea8f3180d43e48c6fa7425baa7b6231e66a/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/text/ellipsis-mixed-text-in-rtl-flow-underline-2-expected.png [add] https://crrev.com/71fa7ea8f3180d43e48c6fa7425baa7b6231e66a/third_party/WebKit/LayoutTests/platform/mac/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-expected.png [add] https://crrev.com/71fa7ea8f3180d43e48c6fa7425baa7b6231e66a/third_party/WebKit/LayoutTests/platform/mac/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-expected.txt [add] https://crrev.com/71fa7ea8f3180d43e48c6fa7425baa7b6231e66a/third_party/WebKit/LayoutTests/platform/mac/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-ltr-mixed-expected.png [add] https://crrev.com/71fa7ea8f3180d43e48c6fa7425baa7b6231e66a/third_party/WebKit/LayoutTests/platform/mac/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-ltr-mixed-expected.txt [add] https://crrev.com/71fa7ea8f3180d43e48c6fa7425baa7b6231e66a/third_party/WebKit/LayoutTests/platform/mac/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-expected.png [add] https://crrev.com/71fa7ea8f3180d43e48c6fa7425baa7b6231e66a/third_party/WebKit/LayoutTests/platform/mac/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-expected.txt [add] https://crrev.com/71fa7ea8f3180d43e48c6fa7425baa7b6231e66a/third_party/WebKit/LayoutTests/platform/mac/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-mixed-expected.png [add] https://crrev.com/71fa7ea8f3180d43e48c6fa7425baa7b6231e66a/third_party/WebKit/LayoutTests/platform/mac/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-mixed-expected.txt [add] https://crrev.com/71fa7ea8f3180d43e48c6fa7425baa7b6231e66a/third_party/WebKit/LayoutTests/platform/mac/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-2-expected.png [add] https://crrev.com/71fa7ea8f3180d43e48c6fa7425baa7b6231e66a/third_party/WebKit/LayoutTests/platform/mac/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-2-expected.txt [modify] https://crrev.com/71fa7ea8f3180d43e48c6fa7425baa7b6231e66a/third_party/WebKit/LayoutTests/platform/mac/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-expected.png [add] https://crrev.com/71fa7ea8f3180d43e48c6fa7425baa7b6231e66a/third_party/WebKit/LayoutTests/platform/mac/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-2-expected.png [add] https://crrev.com/71fa7ea8f3180d43e48c6fa7425baa7b6231e66a/third_party/WebKit/LayoutTests/platform/mac/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-2-expected.txt [modify] https://crrev.com/71fa7ea8f3180d43e48c6fa7425baa7b6231e66a/third_party/WebKit/LayoutTests/platform/mac/fast/css/text-overflow-ellipsis-expected.png [modify] https://crrev.com/71fa7ea8f3180d43e48c6fa7425baa7b6231e66a/third_party/WebKit/LayoutTests/platform/mac/fast/css/text-overflow-ellipsis-strict-expected.png [add] https://crrev.com/71fa7ea8f3180d43e48c6fa7425baa7b6231e66a/third_party/WebKit/LayoutTests/platform/mac/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-2-expected.png [add] https://crrev.com/71fa7ea8f3180d43e48c6fa7425baa7b6231e66a/third_party/WebKit/LayoutTests/platform/mac/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-2-expected.txt [modify] https://crrev.com/71fa7ea8f3180d43e48c6fa7425baa7b6231e66a/third_party/WebKit/LayoutTests/platform/mac/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-expected.png [add] https://crrev.com/71fa7ea8f3180d43e48c6fa7425baa7b6231e66a/third_party/WebKit/LayoutTests/platform/mac/fast/text/ellipsis-mixed-text-in-rtl-flow-underline-2-expected.png [add] https://crrev.com/71fa7ea8f3180d43e48c6fa7425baa7b6231e66a/third_party/WebKit/LayoutTests/platform/mac/fast/text/ellipsis-mixed-text-in-rtl-flow-underline-2-expected.txt [add] https://crrev.com/71fa7ea8f3180d43e48c6fa7425baa7b6231e66a/third_party/WebKit/LayoutTests/platform/win/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-expected.png [add] https://crrev.com/71fa7ea8f3180d43e48c6fa7425baa7b6231e66a/third_party/WebKit/LayoutTests/platform/win/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-expected.txt [add] https://crrev.com/71fa7ea8f3180d43e48c6fa7425baa7b6231e66a/third_party/WebKit/LayoutTests/platform/win/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-ltr-mixed-expected.png [add] https://crrev.com/71fa7ea8f3180d43e48c6fa7425baa7b6231e66a/third_party/WebKit/LayoutTests/platform/win/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-ltr-mixed-expected.txt [add] https://crrev.com/71fa7ea8f3180d43e48c6fa7425baa7b6231e66a/third_party/WebKit/LayoutTests/platform/win/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-expected.png [add] https://crrev.com/71fa7ea8f3180d43e48c6fa7425baa7b6231e66a/third_party/WebKit/LayoutTests/platform/win/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-expected.txt [add] https://crrev.com/71fa7ea8f3180d43e48c6fa7425baa7b6231e66a/third_party/WebKit/LayoutTests/platform/win/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-mixed-expected.png [add] https://crrev.com/71fa7ea8f3180d43e48c6fa7425baa7b6231e66a/third_party/WebKit/LayoutTests/platform/win/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-mixed-expected.txt [add] https://crrev.com/71fa7ea8f3180d43e48c6fa7425baa7b6231e66a/third_party/WebKit/LayoutTests/platform/win/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-2-expected.png [add] https://crrev.com/71fa7ea8f3180d43e48c6fa7425baa7b6231e66a/third_party/WebKit/LayoutTests/platform/win/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-2-expected.txt [modify] https://crrev.com/71fa7ea8f3180d43e48c6fa7425baa7b6231e66a/third_party/WebKit/LayoutTests/platform/win/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-expected.png [add] https://crrev.com/71fa7ea8f3180d43e48c6fa7425baa7b6231e66a/third_party/WebKit/LayoutTests/platform/win/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-2-expected.png [add] https://crrev.com/71fa7ea8f3180d43e48c6fa7425baa7b6231e66a/third_party/WebKit/LayoutTests/platform/win/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-2-expected.txt [modify] https://crrev.com/71fa7ea8f3180d43e48c6fa7425baa7b6231e66a/third_party/WebKit/LayoutTests/platform/win/fast/css/text-overflow-ellipsis-expected.png [modify] https://crrev.com/71fa7ea8f3180d43e48c6fa7425baa7b6231e66a/third_party/WebKit/LayoutTests/platform/win/fast/css/text-overflow-ellipsis-strict-expected.png [add] https://crrev.com/71fa7ea8f3180d43e48c6fa7425baa7b6231e66a/third_party/WebKit/LayoutTests/platform/win/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-2-expected.png [add] https://crrev.com/71fa7ea8f3180d43e48c6fa7425baa7b6231e66a/third_party/WebKit/LayoutTests/platform/win/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-2-expected.txt [modify] https://crrev.com/71fa7ea8f3180d43e48c6fa7425baa7b6231e66a/third_party/WebKit/LayoutTests/platform/win/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-expected.png [add] https://crrev.com/71fa7ea8f3180d43e48c6fa7425baa7b6231e66a/third_party/WebKit/LayoutTests/platform/win/fast/text/ellipsis-mixed-text-in-rtl-flow-underline-2-expected.png [add] https://crrev.com/71fa7ea8f3180d43e48c6fa7425baa7b6231e66a/third_party/WebKit/LayoutTests/platform/win/fast/text/ellipsis-mixed-text-in-rtl-flow-underline-2-expected.txt
Comment 1 by robho...@gmail.com
, Aug 30 2016Status: Assigned (was: Unconfirmed)