New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 642450 link

Starred by 1 user
Status: Fixed
Owner:
█ robhogan@chromium.org
Use other robhogan account instead.
Closed: Feb 2017
Cc:
laukst...@gmail.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

Selected Hebrew text appears in black, expected to be white

Reported by laukst...@gmail.com, Aug 30 2016 
UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/52.0.2743.116 Safari/537.36

Steps to reproduce the problem:
1. Test-case https://output.jsbin.com/rorafa/quiet
Related  Issue #634445 .

What is the expected behavior?

What went wrong?
On selecting text, the text color by default expected to appear white.
Since Chrome 52.0.2723.0 selected English text appears white and Hebrew black (while expected to be white too).

Did this work before? Yes Chrome 52.0.2722.0

Chrome version: 55.0.2844.0  Channel: canary
OS Version: 10.0
Flash Version: Shockwave Flash 22.0 r0

CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/2aaedda2430ecad19a8ac4427c145d1b093f3df9..11d39c1b27d7c35d9196edbfc7e82a3551c9eec8
color-diff.png
207 KB View Download

Comment 1 by robho...@gmail.com, Aug 30 2016

Owner: robhogan@chromium.org
Status: Assigned (was: Unconfirmed)
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 4 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8691b058b8f8570128d24b4af3c43b3e2c0151e4

commit 8691b058b8f8570128d24b4af3c43b3e2c0151e4
Author: robhogan <robhogan@gmail.com>
Date: Wed Jan 04 22:21:01 2017

Don't paint underline or selections over ellipsis in mixed-flow contexts

Also, ensure the selected text is painted correctly when an ellipsis is present
in a mixed-flow context (e.g. ltr text in an rtl container).

BUG= 642454 ,  642450 ,  642460 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2594983002
Cr-Commit-Position: refs/heads/master@{#441486}

[modify] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-expected.png
[add] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-expected.txt
[add] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-ltr-mixed-expected.png
[add] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-ltr-mixed-expected.txt
[add] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-ltr-mixed.html
[add] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-expected.png
[add] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-expected.txt
[add] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-mixed-expected.png
[add] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-mixed-expected.txt
[add] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-mixed.html
[add] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl.html
[add] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping.html
[add] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-2-expected.png
[add] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-2-expected.txt
[add] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-2.html
[add] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-2-expected.png
[add] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-2-expected.txt
[add] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-2.html
[add] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-2-expected.png
[add] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-2-expected.txt
[add] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-2.html
[add] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-rtl-flow-underline-2-expected.png
[add] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-rtl-flow-underline-2-expected.txt
[add] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-rtl-flow-underline-2.html
[modify] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/LayoutTests/platform/linux/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-expected.png
[modify] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/LayoutTests/platform/linux/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-expected.png
[modify] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp
[modify] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/Source/core/paint/TextPainter.cpp
[modify] https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4/third_party/WebKit/Source/core/paint/TextPainter.h
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1142d494094d29842cf057bf032c0f3985d7060d

commit 1142d494094d29842cf057bf032c0f3985d7060d
Author: loyso <loyso@chromium.org>
Date: Thu Jan 05 06:31:03 2017

Revert of Don't paint underline or selections over ellipsis in mixed-flow contexts (patchset #3 id:40001 of https://codereview.chromium.org/2594983002/ )

Reason for revert:
Causes test failures on Win10 Win7 bots:
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win10/builds/18739

webkit_tests webkit_tests

unexpected_failures:
fast/forms/select/menulist-appearance-basic.html
fast/forms/select/menulist-style-color.html
fast/forms/select/select-selected.html
fast/forms/select/menulist-width-change.html
fast/forms/select/option-text-clip.html
fast/forms/select/option-script.html
fast/forms/select/option-strip-whitespace.html
fast/forms/color/input-appearance-color.html
fast/forms/select/select-dirty-parent-pref-widths.html
fast/forms/select/select-initial-position.html
fast/forms/select/menulist-deselect-update.html
fast/forms/select/select-change-listbox-to-popup.html
fast/forms/select/select-background-none.html
fast/forms/select/menulist-update-text-popup.html
fast/forms/select/select-baseline.html

Original issue's description:
> Don't paint underline or selections over ellipsis in mixed-flow contexts
>
> Also, ensure the selected text is painted correctly when an ellipsis is present
> in a mixed-flow context (e.g. ltr text in an rtl container).
>
> BUG= 642454 ,  642450 ,  642460 
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
>
> Committed: https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4
> Cr-Commit-Position: refs/heads/master@{#441486}

TBR=eae@chromium.org,szager@chromium.org,robhogan@gmail.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 642454 ,  642450 ,  642460 

Review-Url: https://codereview.chromium.org/2615843002
Cr-Commit-Position: refs/heads/master@{#441599}

[modify] https://crrev.com/1142d494094d29842cf057bf032c0f3985d7060d/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-expected.png
[delete] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-expected.txt
[delete] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-ltr-mixed-expected.png
[delete] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-ltr-mixed-expected.txt
[delete] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-ltr-mixed.html
[delete] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-expected.png
[delete] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-expected.txt
[delete] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-mixed-expected.png
[delete] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-mixed-expected.txt
[delete] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-mixed.html
[delete] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl.html
[delete] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping.html
[delete] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-2-expected.png
[delete] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-2-expected.txt
[delete] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-2.html
[delete] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-2-expected.png
[delete] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-2-expected.txt
[delete] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-2.html
[delete] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-2-expected.png
[delete] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-2-expected.txt
[delete] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-2.html
[delete] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-rtl-flow-underline-2-expected.png
[delete] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-rtl-flow-underline-2-expected.txt
[delete] https://crrev.com/9e9f926fd4ad11c7aec7a8c4e20b0fbade491d30/third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-rtl-flow-underline-2.html
[modify] https://crrev.com/1142d494094d29842cf057bf032c0f3985d7060d/third_party/WebKit/LayoutTests/platform/linux/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-expected.png
[modify] https://crrev.com/1142d494094d29842cf057bf032c0f3985d7060d/third_party/WebKit/LayoutTests/platform/linux/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-expected.png
[modify] https://crrev.com/1142d494094d29842cf057bf032c0f3985d7060d/third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp
[modify] https://crrev.com/1142d494094d29842cf057bf032c0f3985d7060d/third_party/WebKit/Source/core/paint/TextPainter.cpp
[modify] https://crrev.com/1142d494094d29842cf057bf032c0f3985d7060d/third_party/WebKit/Source/core/paint/TextPainter.h
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/495d8354acfb5558725043afc033074934d4fd04

commit 495d8354acfb5558725043afc033074934d4fd04
Author: robhogan <robhogan@gmail.com>
Date: Thu Jan 05 22:49:31 2017

Reland of Don't paint underline or selections over ellipsis in mixed-flow contexts (patchset #1 id:1 of https://codereview.chromium.org/2615843002/ )

Reason for revert:
This patch was not the culprit for the layout test failures.

Original issue's description:
> Revert of Don't paint underline or selections over ellipsis in mixed-flow contexts (patchset #3 id:40001 of https://codereview.chromium.org/2594983002/ )
>
> Reason for revert:
> Causes test failures on Win10 Win7 bots:
> https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win10/builds/18739
>
> webkit_tests webkit_tests
>
> unexpected_failures:
> fast/forms/select/menulist-appearance-basic.html
> fast/forms/select/menulist-style-color.html
> fast/forms/select/select-selected.html
> fast/forms/select/menulist-width-change.html
> fast/forms/select/option-text-clip.html
> fast/forms/select/option-script.html
> fast/forms/select/option-strip-whitespace.html
> fast/forms/color/input-appearance-color.html
> fast/forms/select/select-dirty-parent-pref-widths.html
> fast/forms/select/select-initial-position.html
> fast/forms/select/menulist-deselect-update.html
> fast/forms/select/select-change-listbox-to-popup.html
> fast/forms/select/select-background-none.html
> fast/forms/select/menulist-update-text-popup.html
> fast/forms/select/select-baseline.html
>
> Original issue's description:
> > Don't paint underline or selections over ellipsis in mixed-flow contexts
> >
> > Also, ensure the selected text is painted correctly when an ellipsis is present
> > in a mixed-flow context (e.g. ltr text in an rtl container).
> >
> > BUG= 642454 ,  642450 ,  642460 
> > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> >
> > Committed: https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4
> > Cr-Commit-Position: refs/heads/master@{#441486}
>
> TBR=eae@chromium.org,szager@chromium.org,robhogan@gmail.com
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG= 642454 ,  642450 ,  642460 
>
> Committed: https://crrev.com/1142d494094d29842cf057bf032c0f3985d7060d
> Cr-Commit-Position: refs/heads/master@{#441599}

TBR=eae@chromium.org,szager@chromium.org,loyso@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 642454 ,  642450 ,  642460 

Review-Url: https://codereview.chromium.org/2611233002
Cr-Commit-Position: refs/heads/master@{#441775}

[modify] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-expected.png
[add] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-expected.txt
[add] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-ltr-mixed-expected.png
[add] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-ltr-mixed-expected.txt
[add] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-ltr-mixed.html
[add] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-expected.png
[add] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-expected.txt
[add] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-mixed-expected.png
[add] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-mixed-expected.txt
[add] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-mixed.html
[add] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl.html
[add] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping.html
[add] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-2-expected.png
[add] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-2-expected.txt
[add] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-2.html
[add] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-2-expected.png
[add] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-2-expected.txt
[add] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-2.html
[add] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-2-expected.png
[add] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-2-expected.txt
[add] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-2.html
[add] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-rtl-flow-underline-2-expected.png
[add] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-rtl-flow-underline-2-expected.txt
[add] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-rtl-flow-underline-2.html
[modify] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/LayoutTests/platform/linux/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-expected.png
[modify] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/LayoutTests/platform/linux/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-expected.png
[modify] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp
[modify] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/Source/core/paint/TextPainter.cpp
[modify] https://crrev.com/495d8354acfb5558725043afc033074934d4fd04/third_party/WebKit/Source/core/paint/TextPainter.h

Comment 5 by robhogan@chromium.org, Jan 25 2017

Cc: laukst...@gmail.com
laukstein@ - how are we doing on this one now? Can I close? Are there any other rtl/ellipsis bugs out there I should look at?

Comment 6 by laukst...@gmail.com, Jan 25 2017 

@robhogan, well done, thanks!
It now sometimes crops the ellipsis last dot in the middle (see attached screenshot and test case https://output.jsbin.com/biputasusi/1/quiet). Will you cover it in  Issue #642450  or need to open new issue for that?

Here is still open related  Issue #645938 .

Good luck!
grabilla.Ya2548.png
38.5 KB View Download

Comment 7 by robhogan@chromium.org, Jan 26 2017 

I don't get that on Linux - you're on Mac right?

I'm progressing a patch for  issue 645938 .

Comment 8 by laukst...@gmail.com, Jan 26 2017 

@robhogan, it was tested on Win10 64bit.

Comment 9 by laukst...@gmail.com, Feb 6 2017 

@robhogan, I just open probably related bug  Issue #688957 , noticed on latest Chrome Canary.

Comment 10 by robhogan@chromium.org, Feb 18 2017

Status: Fixed (was: Assigned)

Comment 11 by laukst...@gmail.com, Feb 18 2017 

@robhogan, this still hasn't been fixed.
See attached screenshot of Chrome 58.0.3016.0 (Official Build) canary (64-bit), on Windows 10 64-bit.
grabilla.Ya6492.png
31.5 KB View Download

Comment 12 by laukst...@gmail.com, Feb 18 2017 

This issue ( Issue #642450 ) probably needs to be ReOpen.

Comment 13 by robhogan@chromium.org, Feb 18 2017 

Let's open a new one for it - it appears to be Win specific.
►

Sign in to add a comment