New issue
Advanced search Search tips

Issue 642436 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Small fixes for quick unlock settings

Project Member Reported by jdufault@chromium.org, Aug 30 2016

Issue description

This CL landed after m54 branch and needs to be merged: 
https://codereview.chromium.org/2277993002.

It contains some various UI and accessibility fixes for the quick unlock settings.
 
Labels: -Merge-Request-53 Merge-Request-54

Comment 2 by dimu@chromium.org, Aug 31 2016

Labels: -Merge-Request-54 Merge-Approved-54 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M54 (branch: 2840)
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 2 2016

Labels: -merge-approved-54 merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc22493708f3d7437334ad553241ce3e05e61ef0

commit bc22493708f3d7437334ad553241ce3e05e61ef0
Author: Jacob Dufault <jdufault@google.com>
Date: Fri Sep 02 23:15:04 2016

Small fixes for the lock screen md-settings page.

BUG= 642436 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2277993002
Cr-Commit-Position: refs/heads/master@{#414608}
(cherry picked from commit 09c7ebf5c8d47e2f1335f593e3abb47e013cd58d)

Review URL: https://codereview.chromium.org/2308903002 .

Cr-Commit-Position: refs/branch-heads/2840@{#134}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/bc22493708f3d7437334ad553241ce3e05e61ef0/chrome/app/generated_resources.grd
[modify] https://crrev.com/bc22493708f3d7437334ad553241ce3e05e61ef0/chrome/app/settings_strings.grdp
[modify] https://crrev.com/bc22493708f3d7437334ad553241ce3e05e61ef0/chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html
[modify] https://crrev.com/bc22493708f3d7437334ad553241ce3e05e61ef0/chrome/browser/resources/settings/people_page/password_prompt_dialog.html
[modify] https://crrev.com/bc22493708f3d7437334ad553241ce3e05e61ef0/chrome/browser/resources/settings/people_page/password_prompt_dialog.js
[modify] https://crrev.com/bc22493708f3d7437334ad553241ce3e05e61ef0/chrome/browser/resources/settings/people_page/setup_pin_dialog.js

Status: Fixed (was: Started)
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc22493708f3d7437334ad553241ce3e05e61ef0

commit bc22493708f3d7437334ad553241ce3e05e61ef0
Author: Jacob Dufault <jdufault@google.com>
Date: Fri Sep 02 23:15:04 2016

Small fixes for the lock screen md-settings page.

BUG= 642436 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2277993002
Cr-Commit-Position: refs/heads/master@{#414608}
(cherry picked from commit 09c7ebf5c8d47e2f1335f593e3abb47e013cd58d)

Review URL: https://codereview.chromium.org/2308903002 .

Cr-Commit-Position: refs/branch-heads/2840@{#134}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/bc22493708f3d7437334ad553241ce3e05e61ef0/chrome/app/generated_resources.grd
[modify] https://crrev.com/bc22493708f3d7437334ad553241ce3e05e61ef0/chrome/app/settings_strings.grdp
[modify] https://crrev.com/bc22493708f3d7437334ad553241ce3e05e61ef0/chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html
[modify] https://crrev.com/bc22493708f3d7437334ad553241ce3e05e61ef0/chrome/browser/resources/settings/people_page/password_prompt_dialog.html
[modify] https://crrev.com/bc22493708f3d7437334ad553241ce3e05e61ef0/chrome/browser/resources/settings/people_page/password_prompt_dialog.js
[modify] https://crrev.com/bc22493708f3d7437334ad553241ce3e05e61ef0/chrome/browser/resources/settings/people_page/setup_pin_dialog.js

Sign in to add a comment