New issue
Advanced search Search tips

Issue 642432 link

Starred by 1 user
Status: Fixed
Owner:
alph@chromium.org
Closed: Aug 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug
M54



Sign in to add a comment

CPU profiler runs two samplers for pages with service workers.

Project Member Reported by alph@chromium.org, Aug 30 2016 
The profiling is started twice for such pages. One for main page and another for service worker page.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 30 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/56fa67e4c3a979ce739ffd72fa52c498aa3713b8

commit 56fa67e4c3a979ce739ffd72fa52c498aa3713b8
Author: alph <alph@chromium.org>
Date: Tue Aug 30 22:15:01 2016

DevTools: Do not run CPU profiler on targets with no JS capability.

BUG= 642432 

Review-Url: https://codereview.chromium.org/2297813002
Cr-Commit-Position: refs/heads/master@{#415454}

[modify] https://crrev.com/56fa67e4c3a979ce739ffd72fa52c498aa3713b8/third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js

Comment 2 by alph@chromium.org, Aug 30 2016

Labels: M54 Merge-Request-54

Comment 3 by dimu@chromium.org, Aug 31 2016

Labels: -Merge-Request-54 Merge-Approved-54 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M54 (branch: 2840)
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 31 2016

Labels: -merge-approved-54 merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d712cc731ab213a6cb845f18fdcd334dad1e7d09

commit d712cc731ab213a6cb845f18fdcd334dad1e7d09
Author: Alexei Filippov <alph@chromium.org>
Date: Wed Aug 31 22:36:42 2016

DevTools: Do not run CPU profiler on targets with no JS capability.

BUG= 642432 

Review-Url: https://codereview.chromium.org/2297813002
Cr-Commit-Position: refs/heads/master@{#415454}
(cherry picked from commit 56fa67e4c3a979ce739ffd72fa52c498aa3713b8)

Review URL: https://codereview.chromium.org/2296363002 .

Cr-Commit-Position: refs/branch-heads/2840@{#86}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/d712cc731ab213a6cb845f18fdcd334dad1e7d09/third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js

Comment 5 by alph@chromium.org, Aug 31 2016

Status: Fixed (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d712cc731ab213a6cb845f18fdcd334dad1e7d09

commit d712cc731ab213a6cb845f18fdcd334dad1e7d09
Author: Alexei Filippov <alph@chromium.org>
Date: Wed Aug 31 22:36:42 2016

DevTools: Do not run CPU profiler on targets with no JS capability.

BUG= 642432 

Review-Url: https://codereview.chromium.org/2297813002
Cr-Commit-Position: refs/heads/master@{#415454}
(cherry picked from commit 56fa67e4c3a979ce739ffd72fa52c498aa3713b8)

Review URL: https://codereview.chromium.org/2296363002 .

Cr-Commit-Position: refs/branch-heads/2840@{#86}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/d712cc731ab213a6cb845f18fdcd334dad1e7d09/third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js
►

Sign in to add a comment