Bisect: https://build.chromium.org/p/tryserver.chromium.perf/builders/win_8_perf_bisect/builds/2166

=== Auto-CCing suspected CL author siggi@chromium.org ===

Hi siggi@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Hook memory tracing into Windows heap shim.
Author  : siggi
Commit description:
  
Note for perf sheriffs
----------------------
This CL will cause a data stoppage on the "winheap" metric on
the memory benchmark. It is safe to ignore it as this CL is
renaming it to "malloc".

R=primiano@chromium.org
BUG=550886

Review-Url: https://codereview.chromium.org/2273703003
Cr-Commit-Position: refs/heads/master@{#414523}
Commit  : 7bec59a0644964141c9078d6f17307fdcbe628aa
Date    : Thu Aug 25 20:24:01 2016


===== TESTED REVISIONS =====
Revision         Mean         Std Dev   N  Good?
chromium@414471  89637630     992907    5  good
chromium@414500  89268762     1806368   5  good
chromium@414515  89560743     1346813   5  good
chromium@414522  88982430     1160472   5  good
chromium@414523  10148801887  48378242  5  bad    <--
chromium@414524  10149589184  49627564  5  bad
chromium@414526  10184678301  74348257  5  bad
chromium@414529  10114549775  1729747   5  bad

Bisect job ran on: win_8_perf_bisect
Bug ID: 642417

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests system_health.memory_desktop
Test Metric: memory:chrome:all_processes:reported_by_chrome:effective_size_avg/memory:chrome:all_processes:reported_by_chrome:effective_size_avg
Relative Change: 11183.82%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/win_8_perf_bisect/builds/2166
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9002881196191585600


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5806486414950400

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!

Temporary workaround (https://codereview.chromium.org/2292963003);

(cd third_party/catapult && git cl patch 2292963003)

Yeah, looks like I dunnit. Looking to see how I dunnit.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/52114f27ab25db9aa6a1e635ff29e59e293d09b1

commit 52114f27ab25db9aa6a1e635ff29e59e293d09b1
Author: siggi <siggi@chromium.org>
Date: Wed Aug 31 23:51:30 2016

Fix misspelling of object counts affecting Windows.

BUG= 642417 

Review-Url: https://codereview.chromium.org/2298383002
Cr-Commit-Position: refs/heads/master@{#415809}

[modify] https://crrev.com/52114f27ab25db9aa6a1e635ff29e59e293d09b1/base/trace_event/malloc_dump_provider.cc

Keeping opened and assigned to me just for the merge.
/me was expecting the message "this change is auto-approved for merge".

Your change meets the bar and is auto-approved for M54 (branch: 2840)

> Your change meets the bar and is auto-approved for M54 (branch: 2840)
That's what I like to hear :) merging.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/73ef7bbfcd9e2880d7d6fbe693b1af99890c468f

commit 73ef7bbfcd9e2880d7d6fbe693b1af99890c468f
Author: Primiano Tucci <primiano@chromium.org>
Date: Fri Sep 02 07:39:28 2016

Fix misspelling of object counts affecting Windows.

BUG= 642417 

Review-Url: https://codereview.chromium.org/2298383002
Cr-Commit-Position: refs/heads/master@{#415809}
(cherry picked from commit 52114f27ab25db9aa6a1e635ff29e59e293d09b1)

Review URL: https://codereview.chromium.org/2307773002 .

Cr-Commit-Position: refs/branch-heads/2840@{#121}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/73ef7bbfcd9e2880d7d6fbe693b1af99890c468f/base/trace_event/malloc_dump_provider.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/73ef7bbfcd9e2880d7d6fbe693b1af99890c468f

commit 73ef7bbfcd9e2880d7d6fbe693b1af99890c468f
Author: Primiano Tucci <primiano@chromium.org>
Date: Fri Sep 02 07:39:28 2016

Fix misspelling of object counts affecting Windows.

BUG= 642417 

Review-Url: https://codereview.chromium.org/2298383002
Cr-Commit-Position: refs/heads/master@{#415809}
(cherry picked from commit 52114f27ab25db9aa6a1e635ff29e59e293d09b1)

Review URL: https://codereview.chromium.org/2307773002 .

Cr-Commit-Position: refs/branch-heads/2840@{#121}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/73ef7bbfcd9e2880d7d6fbe693b1af99890c468f/base/trace_event/malloc_dump_provider.cc