New issue
Advanced search Search tips

Issue 642387 link

Starred by 1 user
Status: Fixed
Owner:
chfremer@chromium.org
Closed: May 2017
Cc:
emir...@chromium.org
mcasas@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Consider using Mojo type mapping instead of conversion methods in video_capture_device_proxy_impl.h

Project Member Reported by chfremer@chromium.org, Aug 30 2016 
In file services/video_capture/video_capture_device_proxy_impl.h, we use a set of static conversion methods to convert from a Mojo struct to an existing type in the media namespace. 

This could be done more elegantly using Mojo type mappings.
See also https://www.chromium.org/developers/design-documents/mojo/type-mapping

Comment 1 by yini...@chromium.org, Sep 6 2016

Status: Assigned (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 5 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc81eb705628fbf68ee9b714c1a1a979b42c623c

commit fc81eb705628fbf68ee9b714c1a1a979b42c623c
Author: mcasas <mcasas@chromium.org>
Date: Wed Oct 05 01:45:20 2016

Video Capture Service: typemap video_capture's and media's VideoCaptureFormat

This CL introduces type mapping (via StructTraits) between
video_capture::mojom::VideoCaptureFormatDataView and
media::VideoCaptureFormat and adapts the code in
services/video_capture accordingly. This is needed to
progress in the migration of Video Capture messages between
renderer and browser being tracked in the mentioned bug.

BUG= 651897 ,  642387 
TEST= video_capture_unittests working.

Review-Url: https://codereview.chromium.org/2379253003
Cr-Commit-Position: refs/heads/master@{#423046}

[modify] https://crrev.com/fc81eb705628fbf68ee9b714c1a1a979b42c623c/mojo/public/tools/bindings/chromium_bindings_configuration.gni
[modify] https://crrev.com/fc81eb705628fbf68ee9b714c1a1a979b42c623c/services/video_capture/DEPS
[modify] https://crrev.com/fc81eb705628fbf68ee9b714c1a1a979b42c623c/services/video_capture/fake_device_descriptor_unittest.cc
[modify] https://crrev.com/fc81eb705628fbf68ee9b714c1a1a979b42c623c/services/video_capture/fake_device_unittest.cc
[modify] https://crrev.com/fc81eb705628fbf68ee9b714c1a1a979b42c623c/services/video_capture/mock_device_video_capture_service_test.cc
[modify] https://crrev.com/fc81eb705628fbf68ee9b714c1a1a979b42c623c/services/video_capture/mock_device_video_capture_service_test.h
[modify] https://crrev.com/fc81eb705628fbf68ee9b714c1a1a979b42c623c/services/video_capture/mock_device_video_capture_service_unittest.cc
[modify] https://crrev.com/fc81eb705628fbf68ee9b714c1a1a979b42c623c/services/video_capture/mojo_media_conversions.cc
[modify] https://crrev.com/fc81eb705628fbf68ee9b714c1a1a979b42c623c/services/video_capture/mojo_media_conversions.h
[add] https://crrev.com/fc81eb705628fbf68ee9b714c1a1a979b42c623c/services/video_capture/public/interfaces/typemaps.gni
[add] https://crrev.com/fc81eb705628fbf68ee9b714c1a1a979b42c623c/services/video_capture/public/interfaces/video_capture_format.typemap
[add] https://crrev.com/fc81eb705628fbf68ee9b714c1a1a979b42c623c/services/video_capture/public/interfaces/video_capture_format_traits.cc
[add] https://crrev.com/fc81eb705628fbf68ee9b714c1a1a979b42c623c/services/video_capture/public/interfaces/video_capture_format_traits.h
[modify] https://crrev.com/fc81eb705628fbf68ee9b714c1a1a979b42c623c/services/video_capture/video_capture_device_proxy_impl.cc
[modify] https://crrev.com/fc81eb705628fbf68ee9b714c1a1a979b42c623c/services/video_capture/video_capture_device_proxy_impl.h

Comment 3 by chfremer@chromium.org, May 23 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment