This is a tracking bug for enabling Skia's screenspace tessellating path renderer in Chrome. This is a new approach which should improve performance in cases where we don't have MSAA (e.g., 2D <canvas>, GPU rasterization on Intel).
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3c65d519f8f19505948edf5aed3714d440df040d commit 3c65d519f8f19505948edf5aed3714d440df040d Author: senorblanco <senorblanco@chromium.org> Date: Tue Aug 30 18:59:36 2016 Add a #define to protect an upcoming Skia change. BUG= 642376 Review-Url: https://codereview.chromium.org/2289193002 Cr-Commit-Position: refs/heads/master@{#415380} [modify] https://crrev.com/3c65d519f8f19505948edf5aed3714d440df040d/skia/config/SkUserConfig.h
The following revision refers to this bug: https://skia.googlesource.com/skia.git/+/7370e0d7bd3ac00301e516191683b37fc34b7b49 commit 7370e0d7bd3ac00301e516191683b37fc34b7b49 Author: senorblanco <senorblanco@chromium.org> Date: Thu Sep 01 15:22:58 2016 Enable the screenspace AA tessellating path renderer. This will enable the new path renderer in Skia. It is still disabled in Chrome, to protect layout test results. Note: this will cause minor pixel diffs in a number of GMs' GPU results, including drawregionmodes, dstreadshuffle, smallarc, path-reverse, bug339297 , parsedpaths, zero_control_stroke, strokedlines, smallpaths, circular_arcs_stroke_round, concavepaths, circular_arcs_stroke_square, clipcubic, arcto, persp_shaders_aa, complexclip3_complex, circular_arcs_stroke_and_fill_butt, complexclip_aa, complexclip_aa_layer, complexclip_aa_invert, complexclip3_simple, complexclip_aa_layer_invert, shadertext, shadertext2, convex-lineonly-paths-stroke-and-fill, poly2poly, glyph_pos_h_b, glyph_pos_h_f, glyph_pos_n_f, and glyph_pos_n_s. Note: it also "fixes" crbug_640176, or more accurately, hides the failure, since the default path renderer likely still has the bug. BUG= 642376 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2303743002 Review-Url: https://codereview.chromium.org/2303743002 [modify] https://crrev.com/7370e0d7bd3ac00301e516191683b37fc34b7b49/src/gpu/batches/GrTessellatingPathRenderer.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/frecon/+/71fbe2dfcf6efb2f03f9392d8a2b011cd6ee0255 commit 71fbe2dfcf6efb2f03f9392d8a2b011cd6ee0255 Author: Mike Frysinger <vapier@chromium.org> Date: Wed Aug 31 20:34:04 2016 README: convert to markdown This makes the page much more readable via the web interface. BUG= chromium:345165 TEST=None Change-Id: Id1f9bc2eec269546e8ec765b2f97367542c78381 Reviewed-on: https://chromium-review.googlesource.com/379296 Reviewed-by: Stéphane Marchesin <marcheu@chromium.org> Reviewed-by: Dominik Behr <dbehr@chromium.org> Tested-by: Mike Frysinger <vapier@chromium.org> [delete] https://crrev.com/beca2db09d2800d7679fef9d54e500dae6475c55/README [add] https://crrev.com/71fbe2dfcf6efb2f03f9392d8a2b011cd6ee0255/README.md
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0ad079ddaea6dedf8656bf374b5c0cd8a601da98 commit 0ad079ddaea6dedf8656bf374b5c0cd8a601da98 Author: senorblanco <senorblanco@chromium.org> Date: Tue Feb 07 22:29:37 2017 Add MotionMark's <canvas> fill and stroke tests to telemetry. Add the "Fill shapes" and "Stroke shapes" <canvas> tests, constrained to run with a fixed complexity of 1000. Also assign display names to the pages, so Telemetry doesn't just use a truncated URL. BUG= 642376 Review-Url: https://codereview.chromium.org/2680763003 Cr-Commit-Position: refs/heads/master@{#448746} [modify] https://crrev.com/0ad079ddaea6dedf8656bf374b5c0cd8a601da98/tools/perf/page_sets/data/tough_path_rendering_cases.json [add] https://crrev.com/0ad079ddaea6dedf8656bf374b5c0cd8a601da98/tools/perf/page_sets/data/tough_path_rendering_cases_002.wpr.sha1 [modify] https://crrev.com/0ad079ddaea6dedf8656bf374b5c0cd8a601da98/tools/perf/page_sets/tough_path_rendering_cases.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4fa27c5c19dadb9b737cb004c8ad176e8cb45422 commit 4fa27c5c19dadb9b737cb004c8ad176e8cb45422 Author: senorblanco <senorblanco@chromium.org> Date: Wed Feb 08 20:35:40 2017 Enable Skia's edge-antialiasing tessellating path renderer. This will affect all concave paths rendered in 2D canvas, and in SVG content with five concave paths or fewer. SVG content with >5 five paths will continue to be vetoed to MSAA if available, or software rasterization if not. BUG= 642376 Review-Url: https://codereview.chromium.org/2680003002 Cr-Commit-Position: refs/heads/master@{#449081} [modify] https://crrev.com/4fa27c5c19dadb9b737cb004c8ad176e8cb45422/skia/config/SkUserConfig.h [modify] https://crrev.com/4fa27c5c19dadb9b737cb004c8ad176e8cb45422/third_party/WebKit/LayoutTests/TestExpectations
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/60bc0c792b41d99d4ac3dc7af26b45a5a6483f74 commit 60bc0c792b41d99d4ac3dc7af26b45a5a6483f74 Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org> Date: Wed Feb 08 22:39:53 2017 Auto-rebaseline for r449081 Build: https://build.chromium.org/p/chromium.infra.cron/builders/rebaseline-o-matic/builds/599256 https://chromium.googlesource.com/chromium/src/+/4fa27c5c19dad BUG= 642376 TBR=senorblanco@chromium.org Review-Url: https://codereview.chromium.org/2683883003 . Cr-Commit-Position: refs/heads/master@{#449113} [modify] https://crrev.com/60bc0c792b41d99d4ac3dc7af26b45a5a6483f74/third_party/WebKit/LayoutTests/TestExpectations [add] https://crrev.com/60bc0c792b41d99d4ac3dc7af26b45a5a6483f74/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu/fast/canvas/canvas-arc-circumference-fill-expected.png [modify] https://crrev.com/60bc0c792b41d99d4ac3dc7af26b45a5a6483f74/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu/fast/canvas/canvas-incremental-repaint-expected.png [add] https://crrev.com/60bc0c792b41d99d4ac3dc7af26b45a5a6483f74/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu/fast/canvas/canvas-arc-circumference-fill-expected.png [modify] https://crrev.com/60bc0c792b41d99d4ac3dc7af26b45a5a6483f74/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu/fast/canvas/canvas-incremental-repaint-expected.png [add] https://crrev.com/60bc0c792b41d99d4ac3dc7af26b45a5a6483f74/third_party/WebKit/LayoutTests/platform/win/virtual/gpu/fast/canvas/canvas-arc-circumference-fill-expected.png [modify] https://crrev.com/60bc0c792b41d99d4ac3dc7af26b45a5a6483f74/third_party/WebKit/LayoutTests/platform/win/virtual/gpu/fast/canvas/canvas-incremental-repaint-expected.png [modify] https://crrev.com/60bc0c792b41d99d4ac3dc7af26b45a5a6483f74/third_party/WebKit/LayoutTests/virtual/gpu/fast/canvas/canvas-arc-circumference-expected.png [delete] https://crrev.com/280885a8ab97723e5f1c4bb6f9fdb1bda1418b2a/third_party/WebKit/LayoutTests/virtual/gpu/fast/canvas/canvas-arc-circumference-fill-expected.png [modify] https://crrev.com/60bc0c792b41d99d4ac3dc7af26b45a5a6483f74/third_party/WebKit/LayoutTests/virtual/gpu/fast/canvas/canvas-ellipse-circumference-expected.png [modify] https://crrev.com/60bc0c792b41d99d4ac3dc7af26b45a5a6483f74/third_party/WebKit/LayoutTests/virtual/gpu/fast/canvas/canvas-ellipse-circumference-fill-expected.png
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f5e1caa227f7d458748a92f45938811e87c1f43b commit f5e1caa227f7d458748a92f45938811e87c1f43b Author: senorblanco <senorblanco@chromium.org> Date: Thu Mar 02 15:40:17 2017 Suppress some layout test failures for an upcoming Skia roll. BUG= 642376 TBR=junov NOTRY=true Review-Url: https://codereview.chromium.org/2726803004 Cr-Commit-Position: refs/heads/master@{#454268} [modify] https://crrev.com/f5e1caa227f7d458748a92f45938811e87c1f43b/third_party/WebKit/LayoutTests/TestExpectations
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c5572dcc109df1bd1568efb6dbc79716f698e438 commit c5572dcc109df1bd1568efb6dbc79716f698e438 Author: senorblanco <senorblanco@chromium.org> Date: Mon Mar 06 14:15:43 2017 Mark some canvas GPU layout tests as NeedsRebaseline. BUG= 642376 TBR=junov@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2730373002 Cr-Commit-Position: refs/heads/master@{#454863} [modify] https://crrev.com/c5572dcc109df1bd1568efb6dbc79716f698e438/third_party/WebKit/LayoutTests/TestExpectations
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8b71f3062ca32c718723c3cdc4edc8d7ed0ffbad commit 8b71f3062ca32c718723c3cdc4edc8d7ed0ffbad Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org> Date: Mon Mar 06 15:59:23 2017 Auto-rebaseline for r454863 Build: https://build.chromium.org/p/chromium.infra.cron/builders/rebaseline-o-matic/builds/624467 https://chromium.googlesource.com/chromium/src/+/c5572dcc109df BUG= 642376 TBR=senorblanco@chromium.org Review-Url: https://codereview.chromium.org/2737543002 . Cr-Commit-Position: refs/heads/master@{#454870} [modify] https://crrev.com/8b71f3062ca32c718723c3cdc4edc8d7ed0ffbad/third_party/WebKit/LayoutTests/TestExpectations [add] https://crrev.com/8b71f3062ca32c718723c3cdc4edc8d7ed0ffbad/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu/fast/canvas/canvas-arc-circumference-expected.png [delete] https://crrev.com/da91c38e1326ffcb6b61e0b236a2f2dba584967b/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu/fast/canvas/canvas-arc-circumference-fill-expected.png [modify] https://crrev.com/8b71f3062ca32c718723c3cdc4edc8d7ed0ffbad/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu/fast/canvas/canvas-incremental-repaint-expected.png [add] https://crrev.com/8b71f3062ca32c718723c3cdc4edc8d7ed0ffbad/third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/gpu/fast/canvas/canvas-arc-circumference-expected.png [add] https://crrev.com/8b71f3062ca32c718723c3cdc4edc8d7ed0ffbad/third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/gpu/fast/canvas/canvas-arc-circumference-fill-expected.png [add] https://crrev.com/8b71f3062ca32c718723c3cdc4edc8d7ed0ffbad/third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/gpu/fast/canvas/canvas-ellipse-circumference-expected.png [add] https://crrev.com/8b71f3062ca32c718723c3cdc4edc8d7ed0ffbad/third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/gpu/fast/canvas/canvas-ellipse-circumference-fill-expected.png [add] https://crrev.com/8b71f3062ca32c718723c3cdc4edc8d7ed0ffbad/third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/gpu/fast/canvas/canvas-incremental-repaint-expected.png [add] https://crrev.com/8b71f3062ca32c718723c3cdc4edc8d7ed0ffbad/third_party/WebKit/LayoutTests/platform/mac-retina/virtual/gpu/fast/canvas/canvas-arc-circumference-expected.png [add] https://crrev.com/8b71f3062ca32c718723c3cdc4edc8d7ed0ffbad/third_party/WebKit/LayoutTests/platform/mac-retina/virtual/gpu/fast/canvas/canvas-arc-circumference-fill-expected.png [add] https://crrev.com/8b71f3062ca32c718723c3cdc4edc8d7ed0ffbad/third_party/WebKit/LayoutTests/platform/mac-retina/virtual/gpu/fast/canvas/canvas-ellipse-circumference-expected.png [add] https://crrev.com/8b71f3062ca32c718723c3cdc4edc8d7ed0ffbad/third_party/WebKit/LayoutTests/platform/mac-retina/virtual/gpu/fast/canvas/canvas-ellipse-circumference-fill-expected.png [add] https://crrev.com/8b71f3062ca32c718723c3cdc4edc8d7ed0ffbad/third_party/WebKit/LayoutTests/platform/mac-retina/virtual/gpu/fast/canvas/canvas-incremental-repaint-expected.png [add] https://crrev.com/8b71f3062ca32c718723c3cdc4edc8d7ed0ffbad/third_party/WebKit/LayoutTests/platform/win/virtual/gpu/fast/canvas/canvas-arc-circumference-expected.png [modify] https://crrev.com/8b71f3062ca32c718723c3cdc4edc8d7ed0ffbad/third_party/WebKit/LayoutTests/platform/win/virtual/gpu/fast/canvas/canvas-arc-circumference-fill-expected.png [add] https://crrev.com/8b71f3062ca32c718723c3cdc4edc8d7ed0ffbad/third_party/WebKit/LayoutTests/platform/win/virtual/gpu/fast/canvas/canvas-ellipse-circumference-expected.png [add] https://crrev.com/8b71f3062ca32c718723c3cdc4edc8d7ed0ffbad/third_party/WebKit/LayoutTests/platform/win/virtual/gpu/fast/canvas/canvas-ellipse-circumference-fill-expected.png [modify] https://crrev.com/8b71f3062ca32c718723c3cdc4edc8d7ed0ffbad/third_party/WebKit/LayoutTests/platform/win/virtual/gpu/fast/canvas/canvas-incremental-repaint-expected.png
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/503179bd89d59248061754ac2d49e4de13a23094 commit 503179bd89d59248061754ac2d49e4de13a23094 Author: senorblanco <senorblanco@chromium.org> Date: Mon Mar 13 18:23:26 2017 Suppress some layout test failures for upcoming Skia change. NOTRY=true BUG= 642376 TBR=junov@chromium.org Review-Url: https://codereview.chromium.org/2749613002 Cr-Commit-Position: refs/heads/master@{#456434} [modify] https://crrev.com/503179bd89d59248061754ac2d49e4de13a23094/third_party/WebKit/LayoutTests/TestExpectations
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3182feed58c8d7838cf85f3f4b620606ea06f7a5 commit 3182feed58c8d7838cf85f3f4b620606ea06f7a5 Author: schenney <schenney@chromium.org> Date: Thu Apr 20 20:51:57 2017 Update TestExpectations and rebase some tests. Try reducing flakes for images/color-profile-reflection.html by switching to runAfterLayoutAndPaint. Rebaseline canvas drawing tests after path tesselation patch landed. Remove expectations for no-longer-failing images/color-profile-reflection.html and virtual/gpu/fast/canvas/canvas-ImageData-neutered-source.html TBR=junov@chromium.org BUG= 642376 , 706375 ,713049, 713462 Review-Url: https://codereview.chromium.org/2831953002 Cr-Commit-Position: refs/heads/master@{#466120} [modify] https://crrev.com/3182feed58c8d7838cf85f3f4b620606ea06f7a5/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/3182feed58c8d7838cf85f3f4b620606ea06f7a5/third_party/WebKit/LayoutTests/images/color-profile-reflection.html [modify] https://crrev.com/3182feed58c8d7838cf85f3f4b620606ea06f7a5/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu/fast/canvas/canvas-arc-circumference-expected.png [modify] https://crrev.com/3182feed58c8d7838cf85f3f4b620606ea06f7a5/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu/fast/canvas/canvas-incremental-repaint-expected.png [delete] https://crrev.com/e8227a0e1c5fc7f230fe575086e1816a4e9fa6ae/third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/gpu/fast/canvas/canvas-arc-circumference-expected.png [delete] https://crrev.com/e8227a0e1c5fc7f230fe575086e1816a4e9fa6ae/third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/gpu/fast/canvas/canvas-arc-circumference-fill-expected.png [delete] https://crrev.com/e8227a0e1c5fc7f230fe575086e1816a4e9fa6ae/third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/gpu/fast/canvas/canvas-ellipse-circumference-expected.png [delete] https://crrev.com/e8227a0e1c5fc7f230fe575086e1816a4e9fa6ae/third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/gpu/fast/canvas/canvas-ellipse-circumference-fill-expected.png [delete] https://crrev.com/e8227a0e1c5fc7f230fe575086e1816a4e9fa6ae/third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/gpu/fast/canvas/canvas-incremental-repaint-expected.png [delete] https://crrev.com/e8227a0e1c5fc7f230fe575086e1816a4e9fa6ae/third_party/WebKit/LayoutTests/platform/mac-retina/virtual/gpu/fast/canvas/canvas-arc-circumference-expected.png [delete] https://crrev.com/e8227a0e1c5fc7f230fe575086e1816a4e9fa6ae/third_party/WebKit/LayoutTests/platform/mac-retina/virtual/gpu/fast/canvas/canvas-arc-circumference-fill-expected.png [delete] https://crrev.com/e8227a0e1c5fc7f230fe575086e1816a4e9fa6ae/third_party/WebKit/LayoutTests/platform/mac-retina/virtual/gpu/fast/canvas/canvas-ellipse-circumference-expected.png [delete] https://crrev.com/e8227a0e1c5fc7f230fe575086e1816a4e9fa6ae/third_party/WebKit/LayoutTests/platform/mac-retina/virtual/gpu/fast/canvas/canvas-ellipse-circumference-fill-expected.png [delete] https://crrev.com/e8227a0e1c5fc7f230fe575086e1816a4e9fa6ae/third_party/WebKit/LayoutTests/platform/mac-retina/virtual/gpu/fast/canvas/canvas-incremental-repaint-expected.png [add] https://crrev.com/3182feed58c8d7838cf85f3f4b620606ea06f7a5/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu/fast/canvas/canvas-arc-circumference-expected.png [delete] https://crrev.com/e8227a0e1c5fc7f230fe575086e1816a4e9fa6ae/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu/fast/canvas/canvas-arc-circumference-fill-expected.png [modify] https://crrev.com/3182feed58c8d7838cf85f3f4b620606ea06f7a5/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu/fast/canvas/canvas-incremental-repaint-expected.png [modify] https://crrev.com/3182feed58c8d7838cf85f3f4b620606ea06f7a5/third_party/WebKit/LayoutTests/platform/win/virtual/gpu/fast/canvas/canvas-arc-circumference-expected.png [delete] https://crrev.com/e8227a0e1c5fc7f230fe575086e1816a4e9fa6ae/third_party/WebKit/LayoutTests/platform/win/virtual/gpu/fast/canvas/canvas-arc-circumference-fill-expected.png [delete] https://crrev.com/e8227a0e1c5fc7f230fe575086e1816a4e9fa6ae/third_party/WebKit/LayoutTests/platform/win/virtual/gpu/fast/canvas/canvas-ellipse-circumference-expected.png [delete] https://crrev.com/e8227a0e1c5fc7f230fe575086e1816a4e9fa6ae/third_party/WebKit/LayoutTests/platform/win/virtual/gpu/fast/canvas/canvas-ellipse-circumference-fill-expected.png [modify] https://crrev.com/3182feed58c8d7838cf85f3f4b620606ea06f7a5/third_party/WebKit/LayoutTests/platform/win/virtual/gpu/fast/canvas/canvas-incremental-repaint-expected.png [delete] https://crrev.com/e8227a0e1c5fc7f230fe575086e1816a4e9fa6ae/third_party/WebKit/LayoutTests/virtual/gpu/fast/canvas/canvas-arc-circumference-expected.png [add] https://crrev.com/3182feed58c8d7838cf85f3f4b620606ea06f7a5/third_party/WebKit/LayoutTests/virtual/gpu/fast/canvas/canvas-arc-circumference-fill-expected.png [modify] https://crrev.com/3182feed58c8d7838cf85f3f4b620606ea06f7a5/third_party/WebKit/LayoutTests/virtual/gpu/fast/canvas/canvas-ellipse-circumference-expected.png [modify] https://crrev.com/3182feed58c8d7838cf85f3f4b620606ea06f7a5/third_party/WebKit/LayoutTests/virtual/gpu/fast/canvas/canvas-ellipse-circumference-fill-expected.png
Comment 1 by bugdroid1@chromium.org
, Aug 30 2016