New issue
Advanced search Search tips

Issue 642371 link

Starred by 1 user
Status: Fixed
Owner:
droger@chromium.org
Closed: Oct 2016
Cc:
droger@chromium.org
mattcary@chromium.org
pasko@chromium.org
chrome-perf-bugs@google.com
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocking:
issue 632361



Sign in to add a comment

Histograms for nostate-prefetch

Project Member Reported by pasko@chromium.org, Aug 30 2016 
These popped up in our conversations:

* Histograms should, when possible, be split by origin, like Prerender.* ones

* Most of FinalStatus-es do not make sense, and extending them will make it harder to clean up, so will probably be something like PrefetchFinalStatus

* A few unique histograms will provide nice insights, such as: "how much no-store is there on the 'critical' path"?

We will certainly have more ideas.

Comment 1 by pasko@chromium.org, Aug 30 2016

Labels: Performance
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/81a292f669a97f97087a18c54558ae65efd094f7

commit 81a292f669a97f97087a18c54558ae65efd094f7
Author: droger <droger@chromium.org>
Date: Wed Sep 07 09:33:52 2016

[NoStatePrefetch] Add UMA histogram to count prefetch requests

The prefetches are split into 4 categories:
- main resource, cacheable
- main resource, no-store
- sub-resource, cacheable
- sub-resource, no-store

This will allow to count the number of prefetched pages, count how many
sub resources are discovered on average, and how much no-store is
prevalent.

BUG= 642371 

Review-Url: https://codereview.chromium.org/2287993003
Cr-Commit-Position: refs/heads/master@{#416889}

[modify] https://crrev.com/81a292f669a97f97087a18c54558ae65efd094f7/chrome/browser/prerender/prerender_histograms.cc
[modify] https://crrev.com/81a292f669a97f97087a18c54558ae65efd094f7/chrome/browser/prerender/prerender_histograms.h
[modify] https://crrev.com/81a292f669a97f97087a18c54558ae65efd094f7/chrome/browser/prerender/prerender_manager.cc
[modify] https://crrev.com/81a292f669a97f97087a18c54558ae65efd094f7/chrome/browser/prerender/prerender_manager.h
[modify] https://crrev.com/81a292f669a97f97087a18c54558ae65efd094f7/chrome/browser/prerender/prerender_resource_throttle.cc
[modify] https://crrev.com/81a292f669a97f97087a18c54558ae65efd094f7/chrome/browser/prerender/prerender_resource_throttle.h
[modify] https://crrev.com/81a292f669a97f97087a18c54558ae65efd094f7/tools/metrics/histograms/histograms.xml
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 20 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c154315d263486c4ecd1cc9b1f73e82efeb2468a

commit c154315d263486c4ecd1cc9b1f73e82efeb2468a
Author: droger <droger@chromium.org>
Date: Tue Sep 20 13:03:37 2016

[NoStatePrefetch] Add performance histograms.

This CL adds histograms to record performance of NoStatePrefetch.

The histograms added are:

NoStatePrefetchAge: age of the prefetch when it is used

NoStatePrefetchTTFCP: Time To First Contentful Paint, with variations:
- Cold/Warm/Reference:
    * Warm: Prefetch is recent enough to skip revalidation
    * Cold: Prefetch is old and does not skip revalidation
    * Reference: there was no prefetch
- Cacheable/NoStore: whether the main resource had "no-store" headers.

BUG= 642371 
TBR=jochen

Review-Url: https://codereview.chromium.org/2321083002
Cr-Commit-Position: refs/heads/master@{#419733}

[modify] https://crrev.com/c154315d263486c4ecd1cc9b1f73e82efeb2468a/chrome/browser/BUILD.gn
[modify] https://crrev.com/c154315d263486c4ecd1cc9b1f73e82efeb2468a/chrome/browser/android/offline_pages/prerender_adapter.cc
[modify] https://crrev.com/c154315d263486c4ecd1cc9b1f73e82efeb2468a/chrome/browser/android/offline_pages/prerender_adapter_unittest.cc
[modify] https://crrev.com/c154315d263486c4ecd1cc9b1f73e82efeb2468a/chrome/browser/android/tab_android.cc
[modify] https://crrev.com/c154315d263486c4ecd1cc9b1f73e82efeb2468a/chrome/browser/android/tab_web_contents_delegate_android.cc
[modify] https://crrev.com/c154315d263486c4ecd1cc9b1f73e82efeb2468a/chrome/browser/browsing_data/browsing_data_remover.cc
[modify] https://crrev.com/c154315d263486c4ecd1cc9b1f73e82efeb2468a/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/c154315d263486c4ecd1cc9b1f73e82efeb2468a/chrome/browser/extensions/activity_log/activity_log.cc
[modify] https://crrev.com/c154315d263486c4ecd1cc9b1f73e82efeb2468a/chrome/browser/extensions/activity_log/activity_log_browsertest.cc
[modify] https://crrev.com/c154315d263486c4ecd1cc9b1f73e82efeb2468a/chrome/browser/extensions/activity_log/activity_log_unittest.cc
[modify] https://crrev.com/c154315d263486c4ecd1cc9b1f73e82efeb2468a/chrome/browser/history/history_tab_helper.cc
[modify] https://crrev.com/c154315d263486c4ecd1cc9b1f73e82efeb2468a/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
[modify] https://crrev.com/c154315d263486c4ecd1cc9b1f73e82efeb2468a/chrome/browser/page_load_metrics/metrics_web_contents_observer.h
[add] https://crrev.com/c154315d263486c4ecd1cc9b1f73e82efeb2468a/chrome/browser/page_load_metrics/observers/no_state_prefetch_page_load_metrics_observer.cc
[add] https://crrev.com/c154315d263486c4ecd1cc9b1f73e82efeb2468a/chrome/browser/page_load_metrics/observers/no_state_prefetch_page_load_metrics_observer.h
[modify] https://crrev.com/c154315d263486c4ecd1cc9b1f73e82efeb2468a/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
[modify] https://crrev.com/c154315d263486c4ecd1cc9b1f73e82efeb2468a/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc
[modify] https://crrev.com/c154315d263486c4ecd1cc9b1f73e82efeb2468a/chrome/browser/page_load_metrics/page_load_metrics_observer.cc
[modify] https://crrev.com/c154315d263486c4ecd1cc9b1f73e82efeb2468a/chrome/browser/page_load_metrics/page_load_metrics_observer.h
[modify] https://crrev.com/c154315d263486c4ecd1cc9b1f73e82efeb2468a/chrome/browser/predictors/autocomplete_action_predictor.cc
[modify] https://crrev.com/c154315d263486c4ecd1cc9b1f73e82efeb2468a/chrome/browser/prerender/external_prerender_handler_android.cc
[modify] https://crrev.com/c154315d263486c4ecd1cc9b1f73e82efeb2468a/chrome/browser/prerender/prerender_browsertest.cc
[modify] https://crrev.com/c154315d263486c4ecd1cc9b1f73e82efeb2468a/chrome/browser/prerender/prerender_contents.cc
[modify] https://crrev.com/c154315d263486c4ecd1cc9b1f73e82efeb2468a/chrome/browser/prerender/prerender_histograms.cc
[modify] https://crrev.com/c154315d263486c4ecd1cc9b1f73e82efeb2468a/chrome/browser/prerender/prerender_histograms.h
[modify] https://crrev.com/c154315d263486c4ecd1cc9b1f73e82efeb2468a/chrome/browser/prerender/prerender_link_manager_factory.cc
[modify] https://crrev.com/c154315d263486c4ecd1cc9b1f73e82efeb2468a/chrome/browser/prerender/prerender_manager.cc
[modify] https://crrev.com/c154315d263486c4ecd1cc9b1f73e82efeb2468a/chrome/browser/prerender/prerender_manager.h
[modify] https://crrev.com/c154315d263486c4ecd1cc9b1f73e82efeb2468a/chrome/browser/prerender/prerender_manager_factory.cc
[modify] https://crrev.com/c154315d263486c4ecd1cc9b1f73e82efeb2468a/chrome/browser/prerender/prerender_manager_factory.h
[modify] https://crrev.com/c154315d263486c4ecd1cc9b1f73e82efeb2468a/chrome/browser/prerender/prerender_tab_helper.cc
[modify] https://crrev.com/c154315d263486c4ecd1cc9b1f73e82efeb2468a/chrome/browser/prerender/prerender_test_utils.cc
[modify] https://crrev.com/c154315d263486c4ecd1cc9b1f73e82efeb2468a/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc
[modify] https://crrev.com/c154315d263486c4ecd1cc9b1f73e82efeb2468a/chrome/browser/ui/browser_navigator.cc
[modify] https://crrev.com/c154315d263486c4ecd1cc9b1f73e82efeb2468a/chrome/browser/ui/search/instant_search_prerenderer.cc
[modify] https://crrev.com/c154315d263486c4ecd1cc9b1f73e82efeb2468a/chrome/browser/ui/search/instant_search_prerenderer_unittest.cc
[modify] https://crrev.com/c154315d263486c4ecd1cc9b1f73e82efeb2468a/chrome/browser/ui/webui/net_internals/net_internals_ui.cc
[modify] https://crrev.com/c154315d263486c4ecd1cc9b1f73e82efeb2468a/chrome/browser/ui/webui/net_internals/net_internals_ui_browsertest.cc
[add] https://crrev.com/c154315d263486c4ecd1cc9b1f73e82efeb2468a/chrome/test/data/nostore.html
[add] https://crrev.com/c154315d263486c4ecd1cc9b1f73e82efeb2468a/chrome/test/data/nostore.html.mock-http-headers
[modify] https://crrev.com/c154315d263486c4ecd1cc9b1f73e82efeb2468a/tools/metrics/histograms/histograms.xml

Comment 5 by pasko@chromium.org, Oct 28 2016

Cc: pasko@chromium.org
Owner: droger@chromium.org
Status: Fixed (was: Available)
I believe this is fixed by droger@
►

Sign in to add a comment