New issue
Advanced search Search tips

Issue 642351 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug

Blocking:
issue 82385



Sign in to add a comment

All ClangToTWin bots red

Project Member Reported by thakis@chromium.org, Aug 30 2016

Issue description

https://build.chromium.org/p/chromium.fyi/builders/ClangToTWin(dbg)

[223/42568] CC obj/base/base/precompile.c.obj
FAILED: obj/base/base/precompile.c.obj 
../../third_party/llvm-build/Release+Asserts/bin/clang-cl.exe /nologo /showIncludes /FC @obj/base/base/precompile.c.obj.rsp /c ../../build/precompile.cc /Foobj/base/base/precompile.c.obj /Fd"obj/base/base_c.pdb"
error: C99 was disabled in PCH file but is currently enabled
1 error generated.


The pinned bots are happy 'cause they use goma which disables pchs. I don't see a chrome-side change that looks super related; maybe the pch code changed in clang.
 

Comment 1 by thakis@chromium.org, Aug 30 2016

`ninja -C out\gn obj/base/base/precompile.c.obj` works fine in my pinned checkout.

Comment 2 by thakis@chromium.org, Aug 30 2016

Short repro on trunk:

thakis@thakis:~/src/llvm-build$ touch pch.h pch.c
thakis@thakis:~/src/llvm-build$ bin/clang-cl /FIpch.h /Ycpch.h pch.c
error: C99 was disabled in PCH file but is currently enabled
1 error generated.

Comment 3 by thakis@chromium.org, Aug 30 2016

Status: Fixed (was: Untriaged)
https://llvm.org/bugs/show_bug.cgi?id=30195 -- it was 280035

Sign in to add a comment