Issue metadata
Sign in to add a comment
|
Regression:Black patch is observed on clicking the drop down list in "nkgsb-bank.com"
Reported by
adha...@etouch.net,
Aug 30 2016
|
||||||||||||||||||||||||
Issue descriptionChrome Version: 54.0.2840.6 (Official Build) 913de510430509b3a185e36e6ad568fe29392df6-refs/branch-heads/2840@{#28} (32/64-bit) OS: Windows (7,8,8.1,10) TEST URL:http://www.nkgsb-bank.com/Main/index.html What steps will reproduce the problem? (1)Launch chrome and navigate to the above url. (2)Open devtools window( Press F12) and select "toggle device toolbar" mode.(Kindly refer the video) (3)Now click on the drop down list of Quicklinks at top R.H.S and observe. Actual:Black patch is observed on clicking the drop down list. Expected:Drop down list should be seen properly. This is a Regression issue broken in M-54,below is the Narrow bisect info: https://chromium.googlesource.com/chromium/src/+log/f2c7b56f4a4f2c16b2f7062f60ad3041217e9f20..49dab440c63881d09a313824a345ec1f8574b025?pretty=fuller&n=100 Suspecting:r413276? Good build:54.0.2833.0 Bad build:54.0.2835.0 Kindly help to re-assign if your change is not the cause for this issue. Note:Above issue is not seen on Linux and Mac OS.
,
Sep 4 2016
,
Sep 4 2016
,
Sep 6 2016
,
Sep 7 2016
,
Sep 13 2016
Actually, it looks like the dev tools case is separate. Deduping.
,
Sep 13 2016
Issue 645863 has been merged into this issue.
,
Sep 15 2016
M54 Stable release is scheduled for the first week of OCT, please have the fix baked/verified in canary and request a merge to M54 ASAP.
,
Sep 20 2016
I don't think this should block shipping. It's a minor regression only in dev tools emulation mode and, while unfortunate, shouldn't impact ordinary users or too many developers. Additionally, the fix will likely be significant enough that a merge would be risky. I'll look to fix for M55 though.
,
Sep 30 2016
Issue 650892 has been merged into this issue.
,
Sep 30 2016
,
Sep 30 2016
,
Oct 2 2016
Issue 651723 has been merged into this issue.
,
Oct 3 2016
I am also getting the same issue in mobile mode. The dropdown is not opened in mobile mode using dev tool simulator but it works in Desktop mode. In addition in chrome 53, I am trying to open a dropdown using keyboard event in Desktop mode but it does not work and it works as expected in chrome 49.
This is the code i am using for dropdown keyboard functionality.
element.on("keydown", onKeyDown);
function onKeyDown() {
var elem=angular.element(element.find('select'));
var e = document.createEvent("MouseEvents");
e.initMouseEvent("mousedown", true, true, window, 0, 0, 0, 0, 0,false, false, false, false, 0, null);
elem.dispatchEvent(e);
}
any ideas?
,
Oct 3 2016
Issue 651699 has been merged into this issue.
,
Oct 3 2016
Issue 651004 has been merged into this issue.
,
Oct 3 2016
Issue 648944 has been merged into this issue.
,
Oct 3 2016
Issue 647144 has been merged into this issue.
,
Oct 3 2016
Issue 648543 has been merged into this issue.
,
Oct 3 2016
This is a major issue. Mobile device emulation is of this moment, broken on the latest stable release of Chrome - Windows 10, Chrome 53 - (unless your site doesn't have any <select> elements.). You've basically written off all of the device emulation feature with this bug. 1. Open this html in Chrome 53. <html> <select style="font-size: 1.5em"> <option selected="selected">1</option> <option>2</option> <option>3</option> </select> </html> 2. F12 - device mode. 3. Try clicking the select.
,
Oct 3 2016
Yes, the reproduction is clear. I think the issue needs to be closed for further comments, they are just noise.
,
Oct 3 2016
Please only STAR this issue if you have also experienced it. It was originally reported a month ago, has been reproduced/confirmed and is being investigated for a fix.
,
Oct 3 2016
I'll take a look today.
,
Oct 3 2016
Issue 652248 has been merged into this issue.
,
Oct 3 2016
Thanks for investigation. This is marked as a stable blocker. We're looking to ship that very soon, so please try to have this bug fixed ASAP so that it can be merged to branch 2840.
,
Oct 4 2016
Just to update, I've found the problem and have a fix ready, just need to add a test. Should have a patch up for review tomorrow.
,
Oct 4 2016
Issue 651297 has been merged into this issue.
,
Oct 4 2016
Issue 652595 has been merged into this issue.
,
Oct 5 2016
We have started observing user feedback about this issue starting from M53.0.2785.116 to M55.
,
Oct 5 2016
Thanks David for working on a fix. Can we have the latest update of the patch? FYI: We are close to M54 Stable promotion, so we need have the patch baked and verified in canary ASAP so that it can be merged to M54 branch.
,
Oct 5 2016
Working on test at the moment, should have that done shortly and up for review by EOD. I'll try to land tonight.
,
Oct 5 2016
Is this fix addressing also the fact that the dropdown is showing up at the wrong location? Or just that it is shown as a black patch?
,
Oct 5 2016
Both, the fix should make the dropdown appear correctly.
,
Oct 5 2016
Ok, fix published @ https://codereview.chromium.org/2394073002/, just waiting on review now.
,
Oct 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/841fdc7222eefdaf63e97f3c57dfe6ea16b6b2b0 commit 841fdc7222eefdaf63e97f3c57dfe6ea16b6b2b0 Author: bokan <bokan@chromium.org> Date: Thu Oct 06 00:16:35 2016 RenderWidget::windowRect and viewRect should apply device emulation transform. Since Blink's popup menus now rely on the RenderWidget keeping track of the view rect, the rect must return the emulated position of the popup. This is symmetric with how setWindowRect applies the transformation when setting the rect. BUG= 642349 Review-Url: https://codereview.chromium.org/2394073002 Cr-Commit-Position: refs/heads/master@{#423350} [modify] https://crrev.com/841fdc7222eefdaf63e97f3c57dfe6ea16b6b2b0/content/renderer/devtools/render_widget_screen_metrics_emulator.h [modify] https://crrev.com/841fdc7222eefdaf63e97f3c57dfe6ea16b6b2b0/content/renderer/render_widget.cc [modify] https://crrev.com/841fdc7222eefdaf63e97f3c57dfe6ea16b6b2b0/content/renderer/render_widget.h [modify] https://crrev.com/841fdc7222eefdaf63e97f3c57dfe6ea16b6b2b0/content/renderer/render_widget_unittest.cc
,
Oct 6 2016
The fix is in, I'll wait until it hits canary and request a merge to 54. Please note, the fix for a related issue 638671 should also be merged to 54 with this patch.
,
Oct 6 2016
Above issue is not reproducible on latest canary version i.e 55.0.2882.0 and seems to be working as intended.
,
Oct 6 2016
Hi Team, My chrome Version 53.0.2785.143 m (64-bit) and I am getting the same issue of drop down box. Request to fix it. Thanks!
,
Oct 6 2016
,
Oct 6 2016
Requesting merge based on #37 (my Canary won't update yet).
,
Oct 6 2016
Issue 653057 has been merged into this issue.
,
Oct 6 2016
Your change meets the bar and is auto-approved for M54 (branch: 2840)
,
Oct 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a3bd89f6ac532af8dafda2b264a1fcb1175756ab commit a3bd89f6ac532af8dafda2b264a1fcb1175756ab Author: David Bokan <bokan@chromium.org> Date: Fri Oct 07 02:18:50 2016 RenderWidget::windowRect and viewRect should apply device emulation transform. Since Blink's popup menus now rely on the RenderWidget keeping track of the view rect, the rect must return the emulated position of the popup. This is symmetric with how setWindowRect applies the transformation when setting the rect. BUG= 642349 Review-Url: https://codereview.chromium.org/2394073002 Cr-Commit-Position: refs/heads/master@{#423350} (cherry picked from commit 841fdc7222eefdaf63e97f3c57dfe6ea16b6b2b0) Review URL: https://codereview.chromium.org/2400883003 . Cr-Commit-Position: refs/branch-heads/2840@{#675} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/a3bd89f6ac532af8dafda2b264a1fcb1175756ab/content/renderer/devtools/render_widget_screen_metrics_emulator.h [modify] https://crrev.com/a3bd89f6ac532af8dafda2b264a1fcb1175756ab/content/renderer/render_widget.cc [modify] https://crrev.com/a3bd89f6ac532af8dafda2b264a1fcb1175756ab/content/renderer/render_widget.h [modify] https://crrev.com/a3bd89f6ac532af8dafda2b264a1fcb1175756ab/content/renderer/render_widget_unittest.cc
,
Oct 7 2016
,
Oct 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8d80e81fca6f5f524de74697814520272de617ad commit 8d80e81fca6f5f524de74697814520272de617ad Author: David Bokan <bokan@chromium.org> Date: Fri Oct 07 17:07:02 2016 Build fix for #675 Merged patch at #675 included some name changes that were made in ToT since the branch. BUG=653778, 642349 Review URL: https://codereview.chromium.org/2404473002 . Cr-Commit-Position: refs/branch-heads/2840@{#677} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/8d80e81fca6f5f524de74697814520272de617ad/content/renderer/render_widget_unittest.cc
,
Oct 12 2016
Verified the issue on Windows-10 using chrome latest Beta M54-54.0.2840.59 by following steps mentioned in the original comment. Observed no black patch while clicking drop down box in dev tools. Hence adding TE_Verified label.
,
Oct 12 2016
Ack. #645478 (DevTools: <select>s broken in device emulation) is also fixed in the Linux daily builds (which reports as Version 56.0.2889.0 (64-bit) )
,
Oct 14 2016
Issue 654136 has been merged into this issue.
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/841fdc7222eefdaf63e97f3c57dfe6ea16b6b2b0 commit 841fdc7222eefdaf63e97f3c57dfe6ea16b6b2b0 Author: bokan <bokan@chromium.org> Date: Thu Oct 06 00:16:35 2016 RenderWidget::windowRect and viewRect should apply device emulation transform. Since Blink's popup menus now rely on the RenderWidget keeping track of the view rect, the rect must return the emulated position of the popup. This is symmetric with how setWindowRect applies the transformation when setting the rect. BUG= 642349 Review-Url: https://codereview.chromium.org/2394073002 Cr-Commit-Position: refs/heads/master@{#423350} [modify] https://crrev.com/841fdc7222eefdaf63e97f3c57dfe6ea16b6b2b0/content/renderer/devtools/render_widget_screen_metrics_emulator.h [modify] https://crrev.com/841fdc7222eefdaf63e97f3c57dfe6ea16b6b2b0/content/renderer/render_widget.cc [modify] https://crrev.com/841fdc7222eefdaf63e97f3c57dfe6ea16b6b2b0/content/renderer/render_widget.h [modify] https://crrev.com/841fdc7222eefdaf63e97f3c57dfe6ea16b6b2b0/content/renderer/render_widget_unittest.cc
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a3bd89f6ac532af8dafda2b264a1fcb1175756ab commit a3bd89f6ac532af8dafda2b264a1fcb1175756ab Author: David Bokan <bokan@chromium.org> Date: Fri Oct 07 02:18:50 2016 RenderWidget::windowRect and viewRect should apply device emulation transform. Since Blink's popup menus now rely on the RenderWidget keeping track of the view rect, the rect must return the emulated position of the popup. This is symmetric with how setWindowRect applies the transformation when setting the rect. BUG= 642349 Review-Url: https://codereview.chromium.org/2394073002 Cr-Commit-Position: refs/heads/master@{#423350} (cherry picked from commit 841fdc7222eefdaf63e97f3c57dfe6ea16b6b2b0) Review URL: https://codereview.chromium.org/2400883003 . Cr-Commit-Position: refs/branch-heads/2840@{#675} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/a3bd89f6ac532af8dafda2b264a1fcb1175756ab/content/renderer/devtools/render_widget_screen_metrics_emulator.h [modify] https://crrev.com/a3bd89f6ac532af8dafda2b264a1fcb1175756ab/content/renderer/render_widget.cc [modify] https://crrev.com/a3bd89f6ac532af8dafda2b264a1fcb1175756ab/content/renderer/render_widget.h [modify] https://crrev.com/a3bd89f6ac532af8dafda2b264a1fcb1175756ab/content/renderer/render_widget_unittest.cc
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8d80e81fca6f5f524de74697814520272de617ad commit 8d80e81fca6f5f524de74697814520272de617ad Author: David Bokan <bokan@chromium.org> Date: Fri Oct 07 17:07:02 2016 Build fix for #675 Merged patch at #675 included some name changes that were made in ToT since the branch. BUG=653778, 642349 Review URL: https://codereview.chromium.org/2404473002 . Cr-Commit-Position: refs/branch-heads/2840@{#677} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/8d80e81fca6f5f524de74697814520272de617ad/content/renderer/render_widget_unittest.cc |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by ranjitkan@chromium.org
, Aug 30 2016