New issue
Advanced search Search tips

Issue 642334 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Feature

Blocking:
issue 510028
issue 627147



Sign in to add a comment

Add time scoped deletion for browsing data on iOS

Project Member Reported by ioanap@google.com, Aug 30 2016

Issue description

Time scoped browsing data deletion currently exists in the Clear Browsing Data dialog on Desktop (chrome://settings/clearBrowsingData) and Android (Settings>Privacy>Clear Browsing Data).

Add it to iOS.


 
Project Member

Comment 1 by sheriffbot@chromium.org, Aug 30 2016

Labels: Hotlist-Google
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f433931685d2eefb27a0e987c4361dea6fbb5e22

commit f433931685d2eefb27a0e987c4361dea6fbb5e22
Author: ioanap <ioanap@google.com>
Date: Mon Sep 19 12:13:12 2016

Add support for time based deletion of browsing data on iOS

Change existing browsing data deletion methods to take a browsing_data::TimePeriod as a parameter.

Keep old methods around until all call sites are changed downstream.

BUG=642334

Review-Url: https://codereview.chromium.org/2270063005
Cr-Commit-Position: refs/heads/master@{#419433}

[modify] https://crrev.com/f433931685d2eefb27a0e987c4361dea6fbb5e22/components/signin/ios/browser/account_consistency_service.h
[modify] https://crrev.com/f433931685d2eefb27a0e987c4361dea6fbb5e22/ios/chrome/browser/browsing_data/browsing_data_remover_helper.cc
[modify] https://crrev.com/f433931685d2eefb27a0e987c4361dea6fbb5e22/ios/chrome/browser/browsing_data/browsing_data_remover_helper.h
[modify] https://crrev.com/f433931685d2eefb27a0e987c4361dea6fbb5e22/ios/chrome/browser/browsing_data/ios_chrome_browsing_data_remover.h
[modify] https://crrev.com/f433931685d2eefb27a0e987c4361dea6fbb5e22/ios/chrome/browser/browsing_data/ios_chrome_browsing_data_remover.mm
[modify] https://crrev.com/f433931685d2eefb27a0e987c4361dea6fbb5e22/ios/chrome/browser/signin/browser_state_data_remover.mm
[modify] https://crrev.com/f433931685d2eefb27a0e987c4361dea6fbb5e22/ios/chrome/browser/ui/commands/clear_browsing_data_command.h
[modify] https://crrev.com/f433931685d2eefb27a0e987c4361dea6fbb5e22/ios/chrome/browser/ui/commands/clear_browsing_data_command.mm
[modify] https://crrev.com/f433931685d2eefb27a0e987c4361dea6fbb5e22/ios/crnet/crnet_environment.mm
[modify] https://crrev.com/f433931685d2eefb27a0e987c4361dea6fbb5e22/ios/net/http_cache_helper.cc
[modify] https://crrev.com/f433931685d2eefb27a0e987c4361dea6fbb5e22/ios/net/http_cache_helper.h

Labels: Hotlist-Recharge-BouncingOwner
Owner: ----
Status: Untriaged (was: Started)
This owner is not able to receive e-mails, please re-triage.
Cc: michaeldo@chromium.org
Owner: lpromero@chromium.org
Status: Assigned (was: Untriaged)
lpromero@ can you see if this should be marked fix?
Labels: -Hotlist-Recharge-BouncingOwner
Owner: msramek@chromium.org
Reassigning to myself.

This has been implemented, but I think not yet fully covered by tests.
Cc: huanzhong@chromium.org
Owner: huanzhong@chromium.org

Sign in to add a comment