New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 642330 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 615892



Sign in to add a comment

Non-Regression : Tab Focus is not seen on 'Add Supervised User' Button instead seen on 3 dot menu

Project Member Reported by mm00333...@techmahindra.com, Aug 30 2016

Issue description

Version: 54.0.2840.6
OS: Chrome
Platform : 8743.4.0 dev-channel Daisy,Peppy,Blaze,Quawks

What steps will reproduce the problem?
1.Sign in to user -> Sign out -> Now in Profiles page -> Click on 3 dot menu so that 'Add Supervised User' Button is seen
2.Now click on tab  button until focus is on 3 dot menu

Expected: Focus should be seen on  'Add Supervised User' Button
Actual: Instead Focus is seen on 3 dot menu (Please refer screenshot)


This is Non-Regression Issue seen from M-53
 
Actual_Focus.jpg
1.4 MB View Download

Comment 1 by ajha@chromium.org, Aug 30 2016

Status: Untriaged (was: Unconfirmed)
Reproducible on 54.0.2840.6/8743.4.0 dev-channel Blaze

Comment 2 by tkent@chromium.org, Sep 2 2016

Components: -Blink>Focus

Comment 3 by fi...@chromium.org, Sep 27 2016

Cc: pam@chromium.org
Status: Available (was: Untriaged)
Pam, do you know who owns this?
Cc: elizabethchiu@chromium.org
Owner: glevin@chromium.org
Status: Started (was: Available)
What I'm currently seeing is a little different.  When the "Add supervised user" button is visible, TAB order goes
  ... > Add person > [...] > Add supervised user > Sys Tray > ...
When focus is on [...], the blue focus highlight is drawn around the button, but is partially hidden by the "Add supervised user" button (see 1st attached image).  When focus moves to "Add supervised user", that focus highlight disappears, and there is no visible focus anywhere.

I have a draft fix where "Add supervised user" focus is indicated with a 1px blue border (see 2nd attached image).  It's a little hard to see, but somewhat more obvious when it appears and disappears as focus is changing.  I'll need to know if this is an acceptable focus style, or what should be done instead.

+elizabethchiu@, who's been giving UX advice on other login page focus questions (Issue 412616).

NOTE: I think the original report is implying that focus should skip [...] when "Add supervised user" is visible.  I'm not sure this is correct, as focusing [...] + ENTER is currently the only way to hide "Add supervised user" with the keyboard.  When  Issue 525651  gets fixed, skipping [...] in this case would make more sense.
focus_more.png
3.5 KB View Download
focus_addsu.png
3.4 KB View Download
The attached is what the harmony focused mode looks like and if we can make the change to the other UI on the shelf, it would be good. Also please center the button with "add person" and the shelf. It looks off to me right now. 

https://docs.google.com/a/google.com/presentation/d/17CDjsa8u0rhgjV0zTCJMwY1z5BbaaXKiJqBL_N1s-9A/edit?usp=sharing
Screen Shot 2016-12-09 at 4.18.12 PM.png
73.9 KB View Download
Blocking: 615892
Labels: -M-54 M-57
There's a CL in the works:
https://codereview.chromium.org/2610193002
It adds a focus rect and vertically aligns the box, as described in Comment 5 (see attached).

There's also a CL under review for  Issue 525651  to activate the ESC key on the menu:
https://codereview.chromium.org/2609393003
(It also has TAB order skip the [...] button while [Add supervised user] is visible).

We're blocking Issue 615892, as that includes matching styles for other login shelf button focus rects.
focus_addsu2.png
9.6 KB View Download
Regarding Comment 5... the [Add supervised user] menu/button appears to have been deliberately offset up and to the right by 5px.  Does anyone know why this was done?  The current draft of my CL is removing this offset, placing [Add supervised user] directly on top of the [...] button.  This can be seen in the attached screenshot, where it sits directly adjacent to the focus rect around [Add person].  When [Add supervised user] is visible, it may be closed by the ESC key, and [...] is removed from the TAB order (see Comment 6), so I see no problem with [...] being completely hidden.

elizabethchiu@ - Does this all look reasonable?
focus_addsu3.png
10.1 KB View Download
That's reasonable to me. Is it possible to add space between the two for 8dp?
It's certainly possible... just want to verify that it's desirable.  The focus rects for all the other login shelf buttons (e.g., [Shut down][Browse as Guest][Add person][...]) are all adjacent (have no space between them).  I certainly don't know the specifics of MD design aesthetics, but here's what I was thinking:

When [Add supervised user] was offset up/right by 5px, it felt more like a menu.  By moving it down to cover [...], it feels more like a button, so my inclination would be to place it more like a button (i.e. exactly overlay [...]).

Also, adding that 8px space means restoring some special-case RTL code that I had removed as unnecessary.

All that said, if adding the 8px is the right design decision, it's no real problem :-)
Project Member

Comment 10 by bugdroid1@chromium.org, Feb 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c5a91c9388a44ff129f6234a84a399b1abd97cba

commit c5a91c9388a44ff129f6234a84a399b1abd97cba
Author: glevin <glevin@chromium.org>
Date: Mon Feb 06 20:35:29 2017

Focus style for Add supervised user btn

BUG= 642330 
TEST=On login page, click More options [...] button, and TAB through
elements.  Blue focus rect should be seen on Add supervised user button.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2610193002
Cr-Commit-Position: refs/heads/master@{#448377}

[modify] https://crrev.com/c5a91c9388a44ff129f6234a84a399b1abd97cba/chrome/browser/resources/chromeos/login/header_bar.css

Labels: -M-57 M-58
Status: Fixed (was: Started)
I went ahead and committed this w/o the 8px space mentioned in Comment 8.  It can be added back separately if the desire for it outweighs the thoughts in Comment 9.
Sounds good to me.
Status: Verified (was: Fixed)
Verified on ChromeOS 9287.0.0, 58.0.3011.0

Sign in to add a comment