New issue
Advanced search Search tips

Issue 642327 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Sep 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Feature



Sign in to add a comment

Add option for kill tab

Reported by oliverj...@gmail.com, Aug 30 2016

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/52.0.2743.116 Safari/537.36

Steps to reproduce the problem:
1. Open a website that drains the CPU
2. Try to close it

What is the expected behavior?
The tab can't be closed. You have to open task manager and kill the process.

What went wrong?
It would be handy to have an option to kill the tab when right clicking to open the context menu on a given tab.

Did this work before? N/A 

Chrome version: 52.0.2743.116  Channel: stable
OS Version: OS X 10.11.6
Flash Version: Shockwave Flash 22.0 r0
 
Labels: OS-Linux OS-Windows
Labels: -Type-Bug Type-Feature
Status: Untriaged (was: Unconfirmed)
Marking it as Untriaged as the issue is of Type feature.

Thanks,
For now, you can open chrome://discards and manually kill tabs or enable Chrome's tab discarding feature and let Chrome automatically do the work.
Owner: rpop@chromium.org
Status: Assigned (was: Untriaged)
rpop@: over to you for desktop PM expertise. Do you think this feature is worth exposing in the tab context menu?

Comment 6 by rpop@chromium.org, Sep 21 2016

Please provide a URL that produces this issue.

I'd prefer we address the root cause here. Can we do more to make sure close tab works in this scenario? Should the sab tab be showing up earlier?

Comment 7 by dandv@google.com, Oct 18 2016

@lemon: chrome://discards doesn't work on Linux - see issue 650158

@rpop: I've filed a bug that shows a tab being hard to close, and not releasing CPU cycles after it was closed:  issue 653783 . I've also seen tabs that were impossible to close, but reproducing that was more difficult. See also issue 630840.


Comment 8 by gab@chromium.org, Oct 18 2016

Cc: georgesak@chromium.org

Comment 9 by rpop@chromium.org, Oct 26 2016

Cc: ellyjo...@chromium.org
Owner: ----
Status: Available (was: Assigned)
Thanks for the examples. We should make the existing UI for close tab more resilient if possible. I don't want to introduce a new UI entry point for "kill tab" because most users won't know the difference between this and close (and for those who do, there's task manager.)

Defer to eng on whether there are changes to close tab that make sense here.
This was discussed a while back and the consensus was that it was not worth cluttering the context menu with that option. Our hope was that extensions could add that option (since now we have discard API), however it doesn't look like extensions have the ability to modify the tab strip context menu.

As for chrome://discards not available on Linux, this will be fixed soon (I have a CL ready for review). Stay tuned!
Project Member

Comment 11 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d2ee5e6f646b503fcb77a0597d8d38774e36aaa8

commit d2ee5e6f646b503fcb77a0597d8d38774e36aaa8
Author: georgesak <georgesak@chromium.org>
Date: Thu Oct 27 22:47:45 2016

Enable chrome://discards on Linux.

Tab manager was enabled on Linux a while ago but  chrome://discards was never made available on that platform. This CL fixes that.

Note that automatic discarding is still not available on Linux due to the lack of memory pressure subsystem on that platform.

BUG=551995, 642327 ,650158

Review-Url: https://codereview.chromium.org/2453453002
Cr-Commit-Position: refs/heads/master@{#428173}

[modify] https://crrev.com/d2ee5e6f646b503fcb77a0597d8d38774e36aaa8/chrome/browser/ui/webui/about_ui.cc
[modify] https://crrev.com/d2ee5e6f646b503fcb77a0597d8d38774e36aaa8/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
[modify] https://crrev.com/d2ee5e6f646b503fcb77a0597d8d38774e36aaa8/chrome/common/url_constants.cc
[modify] https://crrev.com/d2ee5e6f646b503fcb77a0597d8d38774e36aaa8/chrome/common/url_constants.h

Project Member

Comment 12 by sheriffbot@chromium.org, Oct 30 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Archived (was: Untriaged)
Archiving old bugs that haven't been actively assigned in over 180 days.

If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks!
Archiving old bugs that haven't been actively assigned in over 180 days.

If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks!
Archiving old bugs that haven't been actively assigned in over 180 days.

If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks!
Archiving old bugs that haven't been actively assigned in over 180 days.

If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks!
This should not be archived.
Status: WontFix (was: Archived)
The product-side decision in #9 still stands so this bug is still WontFix.

Sign in to add a comment