Regression: Distorted context menu is seen for youtube video after selecting 'Copy video URL' option.
Reported by
rk...@etouch.net,
Aug 30 2016
|
||||||||||||||||||
Issue descriptionChrome Version: 55.0.2844.0 Revision 2496c83eb444228b4c161c9ef24db2f0171d2fe5-refs/heads/master@{#415023} OS: Windows(7,8,10), Mac(10.10.5,10.11.4),Linux (14.04 LTS) What steps will reproduce the problem? (1) Launch chrome, navigate to https://www.youtube.com/watch?v=UC1_zGg6heE (2) Right click on video then select 'Copy video URL' option, again right click on video and observe. Actual: Distorted context menu is seen for youtube video. Expected: Context menu should seen properly for youtube video. This is a regression issue, broken in 'M-55', will soon update the other info:
,
Aug 30 2016
Adding release block dev label, Please reduce priority or undo if not the case. Issue is broken in dev candidate 54.0.2840.6 and also seen on 54.0.2840.0.
,
Aug 30 2016
,
Aug 30 2016
r414010 should not be the cause. @hiroshige: can you please have a look.
,
Aug 30 2016
Issue is reproducible on Chrome OS: 54.0.2840.6/8743.4.0_Dev_channel_Blaze as well. hiroshige's change: https://codereview.chromium.org/2208073004 was reverted https://codereview.chromium.org/2278953002 here. But this issue is still reproducible on the latest canary(55.0.2844.0) as tested on Windows-10. https://codereview.chromium.org/2256593002 looks more likely and related change. ericwilligers@: Could you please take a look at this and help in further investigation. Thank you!
,
Aug 30 2016
Is this issue seen without context menu (right click)? Is the video playing properly once context menu is dismissed?
,
Aug 30 2016
The video plays fine without context menu or right click operation. The video plays properly when the context menu is dismissed and even when the distorted context menu is present.
,
Aug 30 2016
Doesn't look like a Dev blocker since the distortion happens only after selecting copy url. Moving to RB Beta.
,
Aug 31 2016
I ran another bisect. "You are probably looking for a change made after 413998 (known good), but no later than 414002 (first known bad)." Suspect #414000 https://codereview.chromium.org/2266733002 Also in the range is ##414002 https://codereview.chromium.org/2268243002/
,
Aug 31 2016
un-ccing myself because my CL was not related (Comment #5).
,
Aug 31 2016
Mine looks suspicious. It might have changed input.select() behavior accidentally.
,
Aug 31 2016
Minimum repro: <!DOCTYPE html> <div style="overflow:scroll; width:100px; height:40px;"> <div>line1</div> <div style="width:100px; display:inline-block;"></div><input value="https://www.youtube.com/watch?v=UC1_zGg6heE" size=20> </div> <script> document.querySelector('input').select(); </script> 52 stable: Show "line1" 55 canary: Show the INPUT box.
,
Aug 31 2016
I confirm the change arrives in tkent's #414002
,
Aug 31 2016
,
Aug 31 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/abecde4851098d8ffdb1f682b5f8745d73757b22 commit abecde4851098d8ffdb1f682b5f8745d73757b22 Author: tkent <tkent@chromium.org> Date: Wed Aug 31 12:47:40 2016 Do not scroll by input.select(). This CL fixes a regression by crrev.com/414002. It accidentally changed select() behavior because focus() scrolls element's containers so that the selection is visible. Focus by select() should not scroll. BUG= 642320 Review-Url: https://codereview.chromium.org/2295083002 Cr-Commit-Position: refs/heads/master@{#415619} [add] https://crrev.com/abecde4851098d8ffdb1f682b5f8745d73757b22/third_party/WebKit/LayoutTests/fast/forms/text/text-select-noscroll-expected.html [add] https://crrev.com/abecde4851098d8ffdb1f682b5f8745d73757b22/third_party/WebKit/LayoutTests/fast/forms/text/text-select-noscroll.html [modify] https://crrev.com/abecde4851098d8ffdb1f682b5f8745d73757b22/third_party/WebKit/Source/core/html/HTMLTextFormControlElement.cpp
,
Sep 1 2016
,
Sep 1 2016
Verified the fix with 55.0.2846.0 canary.
,
Sep 1 2016
Your change meets the bar and is auto-approved for M54 (branch: 2840)
,
Sep 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/212a7811565b74ac5df815a5cd2b849077a23be5 commit 212a7811565b74ac5df815a5cd2b849077a23be5 Author: Kent Tamura <tkent@chromium.org> Date: Thu Sep 01 23:53:30 2016 Merge "Do not scroll by input.select()." to M54 branch This CL fixes a regression by crrev.com/414002. It accidentally changed select() behavior because focus() scrolls element's containers so that the selection is visible. Focus by select() should not scroll. BUG= 642320 Review-Url: https://codereview.chromium.org/2295083002 Cr-Commit-Position: refs/heads/master@{#415619} (cherry picked from commit abecde4851098d8ffdb1f682b5f8745d73757b22) Review URL: https://codereview.chromium.org/2301323002 . Cr-Commit-Position: refs/branch-heads/2840@{#115} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [add] https://crrev.com/212a7811565b74ac5df815a5cd2b849077a23be5/third_party/WebKit/LayoutTests/fast/forms/text/text-select-noscroll-expected.html [add] https://crrev.com/212a7811565b74ac5df815a5cd2b849077a23be5/third_party/WebKit/LayoutTests/fast/forms/text/text-select-noscroll.html [modify] https://crrev.com/212a7811565b74ac5df815a5cd2b849077a23be5/third_party/WebKit/Source/core/html/HTMLTextFormControlElement.cpp
,
Sep 6 2016
Fix is not landed yet for the Chrome Dev Version - 54.0.2840.14, hence couldn't verity it. Would monitor this issue and update it accordingly. Base Commit Position for Chrome Dev Version - 54.0.2840.14 is 414607
,
Oct 13 2016
Verified on build 8743.65.0
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/212a7811565b74ac5df815a5cd2b849077a23be5 commit 212a7811565b74ac5df815a5cd2b849077a23be5 Author: Kent Tamura <tkent@chromium.org> Date: Thu Sep 01 23:53:30 2016 Merge "Do not scroll by input.select()." to M54 branch This CL fixes a regression by crrev.com/414002. It accidentally changed select() behavior because focus() scrolls element's containers so that the selection is visible. Focus by select() should not scroll. BUG= 642320 Review-Url: https://codereview.chromium.org/2295083002 Cr-Commit-Position: refs/heads/master@{#415619} (cherry picked from commit abecde4851098d8ffdb1f682b5f8745d73757b22) Review URL: https://codereview.chromium.org/2301323002 . Cr-Commit-Position: refs/branch-heads/2840@{#115} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [add] https://crrev.com/212a7811565b74ac5df815a5cd2b849077a23be5/third_party/WebKit/LayoutTests/fast/forms/text/text-select-noscroll-expected.html [add] https://crrev.com/212a7811565b74ac5df815a5cd2b849077a23be5/third_party/WebKit/LayoutTests/fast/forms/text/text-select-noscroll.html [modify] https://crrev.com/212a7811565b74ac5df815a5cd2b849077a23be5/third_party/WebKit/Source/core/html/HTMLTextFormControlElement.cpp |
||||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||||
Comment 1 by rk...@etouch.net
, Aug 30 2016Labels: hasbisect
Owner: asapersson@chromium.org
Status: Assigned (was: Unconfirmed)
603 KB
603 KB View Download
438 KB
438 KB View Download