New issue
Advanced search Search tips

Issue 642315 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Oct 2016
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

layoutObject == node->layoutObject()tree should not changed in CaretBase.cpp

Project Member Reported by ClusterFuzz, Aug 30 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=4625137179820032

Fuzzer: bj_broddelwerk
Job Type: mac_asan_chrome
Platform Id: mac

Crash Type: CHECK failure
Crash Address: 
Crash State:
  layoutObject == node->layoutObject()tree should not changed in CaretBase.cpp
  blink::CaretBase::caretLayoutObject
  blink::CaretBase::invalidateLocalCaretRect
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=mac_asan_chrome&range=395786:395828

Minimized Testcase (3.58 Kb): https://cluster-fuzz.appspot.com/download/AMIfv94Wn-a0eJ0rKjztqsUy1BuGoHm4D7gs_pZjtW0zRJWmkId5-WjaBf5Tn1b2tIpuxkH_Qjoq23WK_YpHxSEYqs40JHxsPRG4ovnNBz7QK5hkAegIsfLwM8du4KMJz_JCxuUfZC21pSvKAujekGv7DywWvQCjDw?testcase_id=4625137179820032

Issue manually filed by: msrchandra

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Components: Tools>Test>FindIt>NoResult
Labels: findit-wrong Te-Logged
Owner: yoichio@chromium.org
Status: Assigned (was: Untriaged)
Providing Findit results for internal purpose,
Suspected CLs	No line information available in stacktrace.

Using Code Search for the file Caretbase.cpp assigning it to the concern owner.
Suspecting Commit# e4edfb63d1b068c5ab5dc6b91edf75c108ebc433
Suspecting Review URL# https://codereview.chromium.org/1972523002

@yoichio -- Could you please look into the issue, pardon me if it has nothing to do with your changes.
Thank You.
Labels: -Pri-1 Pri-2
I introduced this CHECK to avoid use-after-free.
Fixing root issue needs redesign in caret layout.
Since the bug comes from Cluster Fuzz with strange usage of METER, which is rate
in real-world.
Project Member

Comment 3 by ClusterFuzz, Oct 13 2016

ClusterFuzz has detected this issue as fixed in range 424153:424892.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=4625137179820032

Fuzzer: bj_broddelwerk
Job Type: mac_asan_chrome
Platform Id: mac

Crash Type: CHECK failure
Crash Address: 
Crash State:
  layoutObject == node->layoutObject()tree should not changed in CaretBase.cpp
  blink::CaretBase::caretLayoutObject
  blink::CaretBase::invalidateLocalCaretRect
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=mac_asan_chrome&range=395786:395828
Fixed: https://cluster-fuzz.appspot.com/revisions?job=mac_asan_chrome&range=424153:424892

Minimized Testcase (3.58 Kb): https://cluster-fuzz.appspot.com/download/AMIfv94Wn-a0eJ0rKjztqsUy1BuGoHm4D7gs_pZjtW0zRJWmkId5-WjaBf5Tn1b2tIpuxkH_Qjoq23WK_YpHxSEYqs40JHxsPRG4ovnNBz7QK5hkAegIsfLwM8du4KMJz_JCxuUfZC21pSvKAujekGv7DywWvQCjDw?testcase_id=4625137179820032

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 4 by ClusterFuzz, Oct 13 2016

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase is verified as fixed, closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Components: -Tools>Test>FindIt>NoResult
Project Member

Comment 6 by sheriffbot@chromium.org, Nov 22 2016

Labels: -Restrict-View-EditIssue
Removing EditIssue view restrictions from ClusterFuzz filed bugs. If you believe that this issue should still be restricted, please reapply the label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by ClusterFuzz, Feb 25 2017

ClusterFuzz has detected this issue as fixed in range 424153:424892.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=4625137179820032

Fuzzer: bj_broddelwerk
Job Type: mac_asan_chrome
Platform Id: mac

Crash Type: CHECK failure
Crash Address: 
Crash State:
  layoutObject == node->layoutObject()tree should not changed in CaretBase.cpp
  blink::CaretBase::caretLayoutObject
  blink::CaretBase::invalidateLocalCaretRect
  
Sanitizer: address (ASAN)

Regressed: https://cluster-fuzz.appspot.com/revisions?job=mac_asan_chrome&range=395786:395828
Fixed: https://cluster-fuzz.appspot.com/revisions?job=mac_asan_chrome&range=424153:424892

Reproducer Testcase: https://cluster-fuzz.appspot.com/download/AMIfv94Wn-a0eJ0rKjztqsUy1BuGoHm4D7gs_pZjtW0zRJWmkId5-WjaBf5Tn1b2tIpuxkH_Qjoq23WK_YpHxSEYqs40JHxsPRG4ovnNBz7QK5hkAegIsfLwM8du4KMJz_JCxuUfZC21pSvKAujekGv7DywWvQCjDw?testcase_id=4625137179820032


See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.

Sign in to add a comment