New issue
Advanced search Search tips

Issue 642302 link

Starred by 1 user
Status: Fixed
Owner:
a...@chromium.org
Closed: Sep 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Favicon reloads on triggering location.replace or history.replaceState

Reported by str...@gmail.com, Aug 30 2016 
UserAgent: Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/52.0.2743.116 Safari/537.36

Steps to reproduce the problem:
1. Open website with favicon and with '#something' in the end of URL, e.g. https://google.com/#
2. Open developers JavaScript console
3. Execute 
location.replace('#')
or
history.replaceState({}, '', '#')

What is the expected behavior?
If location.replace or history.replaceState did not cause page reloading then favicon should not reload and should be always visible 

What went wrong?
Page does not reload (correct) but  favicon reloads - see on tab

Did this work before? N/A 

Chrome version: 52.0.2743.116  Channel: stable
OS Version: 10.0
Flash Version: Shockwave Flash 22.0 r0

Comment 1 by kavvaru@chromium.org, Sep 1 2016

Components: UI>Browser
Labels: -Type-Bug M-55 hasbisect OS-Linux OS-Mac Type-Bug-Regression
Owner: a...@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue on windows 7, Linux Ubuntu 14.04 and Mac 10.11.6 using chrome version 53.0.2785.89 and 55.0.2845.0 with the below steps

1. Opened the URL https://google.com/#
2. Execute "location.replace('#')"  in dev tools console
3.Observed that favicon reloads.

This is regression issue broken in M45.Please find the bisect information as below

Narrow Bisect::
================
Good :: 45.0.2450.0  --  (official build revision 337529)
Bad::  45.0.2451.0  --   (official build revision 337721)

CHANGELOG URL:
================  https://chromium.googlesource.com/chromium/src/+log/56d81712f8d817277957f44bdb756119a38b76f5..d5433f68e9a8c6a5ba09de89fb4a824623e16ad8

Possible suspect from the above CL
https://chromium.googlesource.com/chromium/src/+/259dc79058886a5b109ff65431bc1a19e854469e

avi@ Could you please look into this issue if it is related to your change,else please help us in finding the appropriate owner for this issue.

Thanks,

Comment 2 Deleted

Comment 3 by a...@chromium.org, Sep 13 2016 

OK, definitely my change.

The change removed the "in-page" navigation type in favor of "existing page" plus an "in-page" bit. The code that handles "existing page" does a bit more than the old "in-page" code, namely resetting the favicon for redirect page transitions.

I'm not sure what that means. Investigating.
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cba7c6edb3c1eee02484e62e91c080b0603b41be

commit cba7c6edb3c1eee02484e62e91c080b0603b41be
Author: avi <avi@chromium.org>
Date: Thu Sep 15 04:15:26 2016

Do not clear the favicon for an in-page navigation.

BUG= 642302 , 28515 
TEST=as in  bug 642302 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2339673002
Cr-Commit-Position: refs/heads/master@{#418775}

[modify] https://crrev.com/cba7c6edb3c1eee02484e62e91c080b0603b41be/content/browser/frame_host/navigation_controller_impl.cc
[modify] https://crrev.com/cba7c6edb3c1eee02484e62e91c080b0603b41be/content/browser/frame_host/navigation_controller_impl_browsertest.cc

Comment 5 by a...@chromium.org, Sep 15 2016

Status: Fixed (was: Assigned)
That should fix it!
►

Sign in to add a comment