New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 642289 link

Starred by 1 user
Status: WontFix
Owner: ----
Closed: Aug 2016
Cc:
█ akalin@chromium.org
█ yoshiki@chromium.org
█ tim@chromium.org
█ munjal@chromium.org
skare@chromium.org
isherman@chromium.org
asvitk...@chromium.org
█ rkaplow@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 640921



Sign in to add a comment

Histogram Gaia.BadRequestTypeForOAuth2AccessToken is unmapped

Project Member Reported by ricea@chromium.org, Aug 30 2016 
The histogram 'Gaia.BadRequestTypeForOAuth2AccessToken' is present in
Chromium source code but does not appear in histograms.xml. This means that
data is collected for the histogram but nothing useful is done with it.

The histogram was defined in
google_apis/gaia/oauth2_access_token_fetcher_impl.cc at line 201.

https://cs.chromium.org/chromium/src/google_apis/gaia/oauth2_access_token_fetcher_impl.cc?l=201

It may have moved by the time you read this.

Please remove the histogram 'Gaia.BadRequestTypeForOAuth2AccessToken' from
the source code. If it was very recently added, it may be worth adding it to
histograms.xml instead, but probably not.

This bug was automatically assigned based on git blame information. If you
are not the correct assignee for this bug, please delete the histogram
anyway.

Comment 1 by asvitk...@chromium.org, Aug 30 2016 

This histogram appears to be documented in the internal (non-open source) histograms.xml file:

http://cs/analysis/uma/configs/chrome/histograms.xml

Having said that, it has no owners listed, so should likely be removed still.

Comment 2 by ricea@chromium.org, Aug 31 2016 

Sorry. I was under the impression that the find_unmapped_histograms.py script checked that automatically if you had a src-internal checkout. I should have actually checked.

I will re-run the script before I file any more bugs.

Comment 3 by ricea@chromium.org, Aug 31 2016

Status: WontFix (was: Available)
I am closing this issue as it's not actually true that it's unmapped.

I have rerun find_unmapped_histograms.py so I won't be filing any more bugs against histograms that are defined internally.

However, please consider deleting the histogram or moving it to the public histograms.xml. I can't see any compelling reason for the histogram mapping to be considered non-public.
►

Sign in to add a comment