Histogram Download.DatabaseInvalidState is unmapped |
|||||
Issue descriptionThe histogram 'Download.DatabaseInvalidState' is present in Chromium source code but does not appear in histograms.xml. This means that data is collected for the histogram but nothing useful is done with it. The histogram was defined in components/history/core/browser/download_database.cc at line 390. https://cs.chromium.org/chromium/src/components/history/core/browser/download_database.cc?l=390 It may have moved by the time you read this. Please remove the histogram 'Download.DatabaseInvalidState' from the source code. If it was very recently added, it may be worth adding it to histograms.xml instead, but probably not. This bug was automatically assigned based on git blame information. If you are not the correct assignee for this bug, please delete the histogram anyway.
,
Mar 9 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 9 2018
Arbitrarily assigning to someone who works on downloads.
,
Mar 14 2018
We can probably just remove it if we weren't using it.
,
Mar 14 2018
Ack.
,
Mar 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4ea99e0a120b83bbb82046661605faa42ae1f381 commit 4ea99e0a120b83bbb82046661605faa42ae1f381 Author: Xing Liu <xingliu@chromium.org> Date: Thu Mar 15 16:58:14 2018 Remove Download.DatabaseInvalidState histogram. Remove Download.DatabaseInvalidState, it's not used and not in histograms.xml. Bug: 642288 Change-Id: I586701a9e20f10e483bb4b3b524eefafed5ea0c2 Reviewed-on: https://chromium-review.googlesource.com/963692 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#543406} [modify] https://crrev.com/4ea99e0a120b83bbb82046661605faa42ae1f381/components/history/core/browser/download_database.cc
,
Mar 15 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by phajdan.jr@chromium.org
, Jan 5 2017