New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 642287 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 640921



Sign in to add a comment

Histogram ResourceBundle.LoadLocaleResourcesError is unmapped

Project Member Reported by ricea@chromium.org, Aug 30 2016

Issue description

The histogram 'ResourceBundle.LoadLocaleResourcesError' is present in
Chromium source code but does not appear in histograms.xml. This means that
data is collected for the histogram but nothing useful is done with it.

The histogram was defined in ui/base/resource/resource_bundle_android.cc at
line 112.

https://cs.chromium.org/chromium/src/ui/base/resource/resource_bundle_android.cc?l=112

It may have moved by the time you read this.

Please remove the histogram 'ResourceBundle.LoadLocaleResourcesError' from
the source code. If it was very recently added, it may be worth adding it to
histograms.xml instead, but probably not.

This bug was automatically assigned based on git blame information. If you
are not the correct assignee for this bug, please delete the histogram
anyway.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 31 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/604aab6941881e425c26d899d147f60eacb8312f

commit 604aab6941881e425c26d899d147f60eacb8312f
Author: agrieve <agrieve@chromium.org>
Date: Wed Aug 31 18:52:22 2016

Remove unmapped histogram ResourceBundle.LoadLocaleResourcesError

It was never added to histograms.xml

BUG= 642287 

Review-Url: https://codereview.chromium.org/2298513002
Cr-Commit-Position: refs/heads/master@{#415703}

[modify] https://crrev.com/604aab6941881e425c26d899d147f60eacb8312f/ui/base/resource/resource_bundle.cc
[modify] https://crrev.com/604aab6941881e425c26d899d147f60eacb8312f/ui/base/resource/resource_bundle_android.cc

Status: Fixed (was: Assigned)

Sign in to add a comment