New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 642286 link

Starred by 1 user

Issue metadata

Status: Verified
Owner: ----
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 640921



Sign in to add a comment

Histogram Net.UnknownTypeRequestTimeMs is unmapped

Project Member Reported by ricea@chromium.org, Aug 30 2016

Issue description

The histogram 'Net.UnknownTypeRequestTimeMs' is present in Chromium source
code but does not appear in histograms.xml. This means that data is collected
for the histogram but nothing useful is done with it.

The histogram was defined in net/cert_net/nss_ocsp.cc at line 828.

https://cs.chromium.org/chromium/src/net/cert_net/nss_ocsp.cc?l=828

It may have moved by the time you read this.

Please remove the histogram 'Net.UnknownTypeRequestTimeMs' from the source
code. If it was very recently added, it may be worth adding it to
histograms.xml instead, but probably not.

This bug was automatically assigned based on git blame information. If you
are not the correct assignee for this bug, please delete the histogram
anyway.

 
Components: Internals>Network

Comment 2 by ricea@chromium.org, Apr 21 2017

Components: Internals>Network>Certificate
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b895b796ee38469212557eb5ca1b7f8ab970cb09

commit b895b796ee38469212557eb5ca1b7f8ab970cb09
Author: rsleevi <rsleevi@chromium.org>
Date: Sat Apr 22 00:39:54 2017

Remove unused histograms

Remove histograms used for tracking Linux/ChromeOS OCSP and CRL success
rates.

BUG=614106,  642286 

Review-Url: https://codereview.chromium.org/2831393004
Cr-Commit-Position: refs/heads/master@{#466512}

[modify] https://crrev.com/b895b796ee38469212557eb5ca1b7f8ab970cb09/net/cert_net/nss_ocsp.cc
[modify] https://crrev.com/b895b796ee38469212557eb5ca1b7f8ab970cb09/tools/metrics/histograms/histograms.xml

Status: Verified (was: Available)

Sign in to add a comment