New issue
Advanced search Search tips

Issue 642281 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 640921



Sign in to add a comment

Histogram PrintPreview.ManageCloudPrinters is unmapped

Project Member Reported by ricea@chromium.org, Aug 30 2016

Issue description

The histogram 'PrintPreview.ManageCloudPrinters' is present in Chromium
source code but does not appear in histograms.xml. This means that data is
collected for the histogram but nothing useful is done with it.

The histogram was defined in
chrome/browser/ui/webui/print_preview/print_preview_handler.cc at line 1190.

https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/print_preview/print_preview_handler.cc?l=1190

It may have moved by the time you read this.

Please remove the histogram 'PrintPreview.ManageCloudPrinters' from the
source code. If it was very recently added, it may be worth adding it to
histograms.xml instead, but probably not.

This bug was automatically assigned based on git blame information. If you
are not the correct assignee for this bug, please delete the histogram
anyway.

 

Comment 1 by holte@chromium.org, Aug 22 2017

Components: -Internals>Metrics
Labels: Hotlist-Metrics
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bbee90bb07eb09215c234539ac39ead3c38c333b

commit bbee90bb07eb09215c234539ac39ead3c38c333b
Author: Albert Bodenhamer <abodenha@chromium.org>
Date: Tue Nov 14 18:05:20 2017

Remove PrintPreview.ManageCloudPrinters histogram

Bug:  642281 
Change-Id: Ie61b86046e7691bc049a36a5ed2a5d46392919fc
Reviewed-on: https://chromium-review.googlesource.com/767017
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Albert Bodenhamer <abodenha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516354}
[modify] https://crrev.com/bbee90bb07eb09215c234539ac39ead3c38c333b/chrome/browser/ui/webui/print_preview/print_preview_handler.cc
[modify] https://crrev.com/bbee90bb07eb09215c234539ac39ead3c38c333b/chrome/browser/ui/webui/print_preview/print_preview_handler.h

Status: Fixed (was: Assigned)

Sign in to add a comment