New issue
Advanced search Search tips

Issue 642265 link

Starred by 1 user
Status: Fixed
Owner:
calamity@chromium.org
Closed: Sep 2016
Cc:
dominickn@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Bug
Team-Security-UX



Sign in to add a comment

Setting site engagement params to 0 doesn't work properly

Project Member Reported by calamity@chromium.org, Aug 30 2016 
If we try setting any of the values used by AddPoints to 0, there'll be a DCHECK in debug and it will incorrectly update the last engagement time for the service.

This is a useful way to turn off an engagement source for all users so we should support this a bit better.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 5 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f73cdba299e7e52a15d6bffbf874a94732dc47cb

commit f73cdba299e7e52a15d6bffbf874a94732dc47cb
Author: calamity <calamity@chromium.org>
Date: Mon Sep 05 02:45:52 2016

Make Site Engagement behave for adding 0 points.

This CL changes the site engagement service to allow adding 0 points as
a no-op. This will allow us to turn off engagement sources via Finch by
setting them to 0.

BUG= 642265 

Review-Url: https://codereview.chromium.org/2293793002
Cr-Commit-Position: refs/heads/master@{#416488}

[modify] https://crrev.com/f73cdba299e7e52a15d6bffbf874a94732dc47cb/chrome/browser/engagement/site_engagement_service.cc
[modify] https://crrev.com/f73cdba299e7e52a15d6bffbf874a94732dc47cb/chrome/browser/engagement/site_engagement_service_unittest.cc

Comment 2 by calamity@chromium.org, Sep 21 2016

Status: Fixed (was: Started)

Comment 3 by lgar...@chromium.org, Nov 22 2016

Components: -Security>UX Internals>Permissions>SiteEngagement
►

Sign in to add a comment