New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 642254 link

Starred by 1 user
Status: Fixed
Owner:
jonr...@chromium.org
Closed: Aug 2016
Cc:
nyerramilli@chromium.org
█ tkonch...@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression:List doesn't closes after clicking on options button twice from translate bubble.

Reported by vku...@etouch.net, Aug 30 2016 
Chrome Version: 54.0.2840.6 Revision 913de510430509b3a185e36e6ad568fe29392df6-refs/branch-heads/2840@{#28}(32/64 bit)
OS:Windows (7,8,8.1,10)

Precondition: Make sure "Translate 2016Q2 UI " flag is enabled from chrome://flags

What steps will reproduce the problem?
(1)Launch chrome and navigate to https://vimeo.com/create
(2)Scroll at bottom of page and change page language to 'francais' from L.H.S
(3)Now click on options arrow button 2-3 times from translate bubble and observe.

Actual: List doesn't closes after clicking on options button twice.

Expected: List should close after clicking on options button twice.

This is a regression issue broken in 'M54' and will soon update other info.

Comment 1 by vku...@etouch.net, Aug 30 2016

Components: -UI>Browser>Translate UI>Browser>Bubbles
Labels: hasbisect
Owner: jonr...@chromium.org
Status: Assigned (was: Unconfirmed)
Manual regression range:
Good Build: 54.0.2830.0
Bad Build:  54.0.2831.0

Narrow bisect:
https://chromium.googlesource.com/chromium/src/+log/2846fc559943461bfbfd2048b9b6e2665d0ea821..3b655b7c9f468b1e1fb79bda3d0a468dc2a07d93?pretty=fuller&n=10

Suspecting: 412367 ?

Note: Issue not seen on Mac & Linux OS.
Actual_Translate.mp4
761 KB View Download
Expected_Translate.mp4
831 KB View Download

Comment 2 by ranjitkan@chromium.org, Aug 30 2016

Labels: ReleaseBlock-Stable
Adding release block label, please undo if not the case.

Comment 3 by jonr...@chromium.org, Aug 30 2016

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 31 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df1837b274e20b9ce31a03acd625bdd1775d71c7

commit df1837b274e20b9ce31a03acd625bdd1775d71c7
Author: jonross <jonross@chromium.org>
Date: Wed Aug 31 15:17:43 2016

Update MenuButton closing time for async

MenuButton rejects openning new menus when a reposted event arrives too
close to the closing time of the menu. However this calculation was based
on menus always being synchronous.

Updating MenuButton to set the closed time based on the pressed state being
decremented to 0. This works for both synchronous and async menus.

TEST=manual testing of translate bubble, and other menu buttons, views_unittests
BUG= 642254 

Review-Url: https://codereview.chromium.org/2299443002
Cr-Commit-Position: refs/heads/master@{#415636}

[modify] https://crrev.com/df1837b274e20b9ce31a03acd625bdd1775d71c7/ui/views/controls/button/menu_button.cc

Comment 5 by jonr...@chromium.org, Aug 31 2016

Status: Fixed (was: Started)

Comment 6 by tkonch...@chromium.org, Sep 8 2016

Cc: tkonch...@chromium.org
Labels: TE-Verified-55.0.2853.0 TE-Verified-M55
Tested the same on win10 chrome version 55.0.2853.0 with "Translate 2016Q2 UI " flag enabled - Clicking on options button multiple times the list opens and closes as expected.

Please find the screencast

Adding TE-Verified labels
Recording #4.mp4
1.2 MB View Download
►

Sign in to add a comment