SessionManagerClientImpl::CallRestartJobWithValidFd may crash on a D-Bus error |
||||||||||
Issue descriptionhttps://codereview.chromium.org/2277803005/ introduced a new function which looks like this: void HandleDBusError(dbus::ErrorResponse* response) { LOG(ERROR) << "DBus error " << response->ToString(); } This may crash because ObjectProxy::CallMethodWithErrorCallback can pass a nullptr to the error callback when an error response is not available (i.e. an error happening locally because of a bad D-Bus connection.) Also, IIUC this logging is unnecessary because ObjectProxy::CallMethod calls ObjectProxy::LogMethodCallFailure on an error.
,
Aug 31 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b159d73f7098b1d36aff32c4ff593495a3c710b7 commit b159d73f7098b1d36aff32c4ff593495a3c710b7 Author: hashimoto <hashimoto@chromium.org> Date: Wed Aug 31 09:20:58 2016 chromeos: Fix potential crash in SessionManagerClient ErrorResponse can be null when an error happens locally. Also, this logging is unnecessary as ObjectProxy::CallMethod is already doing that. BUG= 642241 Review-Url: https://codereview.chromium.org/2291453006 Cr-Commit-Position: refs/heads/master@{#415591} [modify] https://crrev.com/b159d73f7098b1d36aff32c4ff593495a3c710b7/chromeos/dbus/session_manager_client.cc
,
Sep 5 2016
,
Oct 7 2016
,
Nov 19 2016
,
Jan 21 2017
,
Mar 4 2017
,
Apr 17 2017
,
May 30 2017
,
Aug 1 2017
,
Oct 14 2017
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by hashimoto@chromium.org
, Aug 30 2016