New issue
Advanced search Search tips

Issue 642240 link

Starred by 1 user
Status: Fixed
Owner:
pdr@chromium.org
Closed: Sep 2016
Cc:
vmp...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 630691



Sign in to add a comment

11 high-dpi failures with spv2 and layer-lists

Project Member Reported by pdr@chromium.org, Aug 30 2016 
When running tests with --additional-drt-flag=--enable-slimming-paint-v2 --additional-drt-flag=--enable-layer-lists, 11 tests fail:
fast/backgrounds/gradient-background-leakage-hidpi.html
fast/canvas/canvas-hidpi-blurry.html
fast/hidpi/broken-image-icon-hidpi.html
fast/hidpi/broken-image-with-size-hidpi.html
fast/hidpi/clip-text-in-hidpi.html
fast/hidpi/device-scale-factor-paint.html
fast/hidpi/focus-rings.html
fast/hidpi/gradient-with-scaled-ancestor.html
fast/hidpi/resize-corner-hidpi.html
fast/sub-pixel/shadows-hidpi.html
svg/as-image/image-respects-deviceScaleFactor.html

https://storage.googleapis.com/chromium-layout-test-archives/linux_layout_tests_slimming_paint_v2/224/layout-test-results/results.html
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 8 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/73249085cf0d583b3267d500e3a48aaf514596c7

commit 73249085cf0d583b3267d500e3a48aaf514596c7
Author: pdr <pdr@chromium.org>
Date: Thu Sep 08 20:54:57 2016

[SPV2] Add the device scale factor to the root transform node

This patch sets the device scale factor on cc's root transform node,
fixing several layout tests. This approach is different from how
cc builds property trees (see post_local_scale_factor in
property_tree_builder's AddTransformNodeIfNeeded) where a post_local
transform is used, but aligns closer to blink's approach of using a
single transform per transform node.

This approach is temporary and will need to be refactored when we
begin supporting viewport transforms such as pinch-zoom.

BUG= 642240 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2318933006
Cr-Commit-Position: refs/heads/master@{#417394}

[modify] https://crrev.com/73249085cf0d583b3267d500e3a48aaf514596c7/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
[modify] https://crrev.com/73249085cf0d583b3267d500e3a48aaf514596c7/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp

Comment 2 by pdr@chromium.org, Sep 8 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment