New issue
Advanced search Search tips

Issue 642228 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Show timeline event for microtasks execution.

Project Member Reported by alph@chromium.org, Aug 30 2016

Issue description

Currently microtasks execution falls into the "other" category.
It should be Scripting instead.
 
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b0a1867f5afec2d8b8e456116613ee294f5e1c42

commit b0a1867f5afec2d8b8e456116613ee294f5e1c42
Author: alph <alph@chromium.org>
Date: Thu Sep 01 21:38:22 2016

DevTools: Introduce RunMicrotasks event.

The event belongs to the Scripting category. It enables JS sample
events being displayed when they fall into RunMicrotasks event.

BUG= 642228 

Review-Url: https://codereview.chromium.org/2282403006
Cr-Commit-Position: refs/heads/master@{#416065}

[add] https://crrev.com/b0a1867f5afec2d8b8e456116613ee294f5e1c42/third_party/WebKit/LayoutTests/inspector/tracing/timeline-js/timeline-microtasks-expected.txt
[add] https://crrev.com/b0a1867f5afec2d8b8e456116613ee294f5e1c42/third_party/WebKit/LayoutTests/inspector/tracing/timeline-js/timeline-microtasks.html
[modify] https://crrev.com/b0a1867f5afec2d8b8e456116613ee294f5e1c42/third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-receive-response-event-expected.txt
[modify] https://crrev.com/b0a1867f5afec2d8b8e456116613ee294f5e1c42/third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js
[modify] https://crrev.com/b0a1867f5afec2d8b8e456116613ee294f5e1c42/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js
[modify] https://crrev.com/b0a1867f5afec2d8b8e456116613ee294f5e1c42/third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineJSProfile.js
[modify] https://crrev.com/b0a1867f5afec2d8b8e456116613ee294f5e1c42/third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineModel.js

Comment 3 by alph@chromium.org, Sep 1 2016

Status: Fixed (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ca795eba291a30486050b1732b412ed56ced633

commit 3ca795eba291a30486050b1732b412ed56ced633
Author: alph <alph@chromium.org>
Date: Tue Sep 13 17:26:44 2016

DevTools: Do not include RunMicrotasks event into FunctionCall.

It's not needed to enclose MicrotasksScope into FunctionCall trace
event as microtasks now have a dedicated event.

BUG= 642228 

Review-Url: https://codereview.chromium.org/2331363002
Cr-Commit-Position: refs/heads/master@{#418283}

[modify] https://crrev.com/3ca795eba291a30486050b1732b412ed56ced633/third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-receive-response-event-expected.txt
[modify] https://crrev.com/3ca795eba291a30486050b1732b412ed56ced633/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp

Sign in to add a comment