New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 642218 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Turn flag opt-in-ime-menu on.

Project Member Reported by azurewei@chromium.org, Aug 30 2016

Issue description

The command flag "opt-in-ime-menu" for the feature Bug: 570761, should be turned on by default, as the launch targets for M54.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b29d4f1e7e9110dd63646bd6196aac3be81dfa34

commit b29d4f1e7e9110dd63646bd6196aac3be81dfa34
Author: azurewei <azurewei@chromium.org>
Date: Tue Aug 30 05:02:09 2016

Turn flag: opt-in-ime-menu on by default, which aims to launch on M54.

BUG= 642218 
TEST=Verified on local build.

Review-Url: https://codereview.chromium.org/2282403004
Cr-Commit-Position: refs/heads/master@{#415130}

[modify] https://crrev.com/b29d4f1e7e9110dd63646bd6196aac3be81dfa34/chrome/common/chrome_features.cc

Labels: Merge-Request-54
Components: UI>Input>Text>IME
Status: Fixed (was: Assigned)

Comment 4 by dimu@chromium.org, Aug 31 2016

Labels: -Merge-Request-54 Merge-Approved-54 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M54 (branch: 2840)
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 31 2016

Labels: -merge-approved-54 merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb15c6f6a8ded7c21ed377584ed09848febfa419

commit cb15c6f6a8ded7c21ed377584ed09848febfa419
Author: azurewei <azurewei@chromium.org>
Date: Wed Aug 31 13:48:10 2016

Turn flag: opt-in-ime-menu on by default, which aims to launch on M54.

TBR=shuchen@chromium.org
NOPRESUBMIT=true
NOTRY=true
BUG= 642218 
TEST=Verified on local build.

Review-Url: https://codereview.chromium.org/2282403004
Cr-Commit-Position: refs/heads/master@{#415130}
(cherry picked from commit b29d4f1e7e9110dd63646bd6196aac3be81dfa34)

Review-Url: https://codereview.chromium.org/2295063003
Cr-Commit-Position: refs/branch-heads/2840@{#69}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/cb15c6f6a8ded7c21ed377584ed09848febfa419/chrome/common/chrome_features.cc

Status: Assigned (was: Fixed)
Flags are not turned on by default on M54

Tested on 54.0.2840.15/8743.18.0
Tested that the flag has been turned on.

Note that if the flag 'opt-in-ime-menu' is turned on, users could see the check box 'Show input options in the shelf' in'Language and input' settings page. While, users still needs to check the checkbox to enable the opt-in IME menu.

If the flag 'opt-in-ime-menu' is turned off, the checkbox 'Show input options in the shelf' will be hidden.
Status: Verified (was: Assigned)
Verified the checkbox 'Show input options in the shelf' under setting available
54.0.2849.33/8743.35.0
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb15c6f6a8ded7c21ed377584ed09848febfa419

commit cb15c6f6a8ded7c21ed377584ed09848febfa419
Author: azurewei <azurewei@chromium.org>
Date: Wed Aug 31 13:48:10 2016

Turn flag: opt-in-ime-menu on by default, which aims to launch on M54.

TBR=shuchen@chromium.org
NOPRESUBMIT=true
NOTRY=true
BUG= 642218 
TEST=Verified on local build.

Review-Url: https://codereview.chromium.org/2282403004
Cr-Commit-Position: refs/heads/master@{#415130}
(cherry picked from commit b29d4f1e7e9110dd63646bd6196aac3be81dfa34)

Review-Url: https://codereview.chromium.org/2295063003
Cr-Commit-Position: refs/branch-heads/2840@{#69}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/cb15c6f6a8ded7c21ed377584ed09848febfa419/chrome/common/chrome_features.cc

Sign in to add a comment