Restrict number of BlimpContents to [0,1] |
||||
Issue descriptionCurrently we only want to be able to have only a single BlimpContents. This means that we want the BlimpContentsManager to only ever return a single one. If one exists, it should just return nullptr instead of a new BlimpContents. Notes: - Update documentation that this can happen. - Right now, in Tab.java, we check if this is a blimp tab or not, and if we have a BlimpContents. If that if-check is true, we go on creating BlimpContents. If that ends up returning null (nativeInitBlimpContents which calls through to CreateBlimpContents()), we should not add the TabBlimpContentsObserver, and we should also reset mBlimp to false to ensure that a WebContents is later created correctly, and that the tab works as expected.
,
Aug 30 2016
,
Aug 31 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/10044bb32baafa8bb90026bb30e66387822d7102 commit 10044bb32baafa8bb90026bb30e66387822d7102 Author: mlliu <mlliu@chromium.org> Date: Wed Aug 31 01:37:46 2016 Restrict number of BlimpContents to [0, 1] Currently, if CreateBlimpContents() is called more than once, multiple BlimpContents are created with the same kDummyTabId. In this CL, 1. BlimpContentsManager will return nullptr if CreateBlimpContents() is called when there's an existing BlimpContents. 2. If BlimpContentsManager returns nullptr, BlimpClientContextImpl won't set the delegate. 2. TabBlimpContentsObserver won't be added in Tab.java BUG= 642216 Review-Url: https://codereview.chromium.org/2299453002 Cr-Commit-Position: refs/heads/master@{#415532} [modify] https://crrev.com/10044bb32baafa8bb90026bb30e66387822d7102/blimp/client/core/blimp_client_context_impl.cc [modify] https://crrev.com/10044bb32baafa8bb90026bb30e66387822d7102/blimp/client/core/contents/blimp_contents_manager.cc [modify] https://crrev.com/10044bb32baafa8bb90026bb30e66387822d7102/blimp/client/core/contents/blimp_contents_manager.h [modify] https://crrev.com/10044bb32baafa8bb90026bb30e66387822d7102/blimp/client/core/contents/blimp_contents_manager_unittest.cc [modify] https://crrev.com/10044bb32baafa8bb90026bb30e66387822d7102/blimp/client/public/blimp_client_context.h [modify] https://crrev.com/10044bb32baafa8bb90026bb30e66387822d7102/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
,
Aug 31 2016
,
Dec 9 2016
|
||||
►
Sign in to add a comment |
||||
Comment 1 by candr...@chromium.org
, Aug 30 2016