"enable_webrtc=false" should exclude all content media stream files
Reported by
liushou...@xiaomi.com,
Aug 30 2016
|
|||||
Issue descriptionSteps to reproduce the problem: Set "enable_webrtc=false" in GN build, media stream files should be moved to webrtc catetory and not be include in this build What is the expected behavior? What went wrong? build failed with "enable_webrtc=false" Did this work before? N/A Chrome version: 52.0.2743.116 Channel: canary OS Version: All Flash Version: Shockwave Flash 22.0 r0
,
Aug 30 2016
,
Aug 30 2016
,
Sep 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/46224dddfc39d6ebaa9c3660fdd2808eb3ce861e commit 46224dddfc39d6ebaa9c3660fdd2808eb3ce861e Author: liushouqun <liushouqun@xiaomi.com> Date: Thu Sep 01 01:59:17 2016 Fix build failure with "enable_webrtc = false". BUG= 642210 TEST= Review-Url: https://codereview.chromium.org/2287263003 Cr-Commit-Position: refs/heads/master@{#415846} [modify] https://crrev.com/46224dddfc39d6ebaa9c3660fdd2808eb3ce861e/content/public/renderer/BUILD.gn [modify] https://crrev.com/46224dddfc39d6ebaa9c3660fdd2808eb3ce861e/content/renderer/BUILD.gn [modify] https://crrev.com/46224dddfc39d6ebaa9c3660fdd2808eb3ce861e/content/renderer/renderer_blink_platform_impl.cc
,
Sep 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/517b1298eb6d07a30f07eade189a792c880c00df commit 517b1298eb6d07a30f07eade189a792c880c00df Author: liushouqun <liushouqun@xiaomi.com> Date: Wed Sep 14 05:58:59 2016 Clean up WebRTC related includes files in content. AecDumpMessageFilter should not be included if enable_webrtc=false. BUG= 642210 TEST= Review-Url: https://codereview.chromium.org/2334173002 Cr-Commit-Position: refs/heads/master@{#418499} [modify] https://crrev.com/517b1298eb6d07a30f07eade189a792c880c00df/content/renderer/BUILD.gn [modify] https://crrev.com/517b1298eb6d07a30f07eade189a792c880c00df/content/renderer/media/user_media_client_impl.h [modify] https://crrev.com/517b1298eb6d07a30f07eade189a792c880c00df/content/renderer/render_thread_impl.cc [modify] https://crrev.com/517b1298eb6d07a30f07eade189a792c880c00df/content/renderer/render_thread_impl.h [modify] https://crrev.com/517b1298eb6d07a30f07eade189a792c880c00df/content/renderer/renderer_blink_platform_impl.cc
,
Dec 13 2016
,
Jan 23 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by shouqun@chromium.org
, Aug 30 2016