Issue metadata
Sign in to add a comment
|
Android chrome showing download progress notification after swiping browser away |
||||||||||||||||||
Issue descriptionDevice name: Nexus 4 From "Settings > About Chrome" Application version: tot OS: kitkat Steps to reproduce: (1) just download some file (2) while the download notification starts, immediately kill the browser by swiping it away from the recent apps drawer (3) notification changes to paused, then immediately changes back to progress Expected result: Notification should be paused when browser gets killed, until resumption kicks in later Actual result: notification changes to paused, then immediately changes back to progress
,
Sep 2 2016
https://codereview.chromium.org/2296913002/ should have fixed the issue. Somehow it didn't show up here.
,
Sep 2 2016
,
Sep 3 2016
Your change meets the bar and is auto-approved for M54 (branch: 2840)
,
Sep 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1319e021631140e015810e7ab989212700cecc3c commit 1319e021631140e015810e7ab989212700cecc3c Author: Min Qin <qinmin@chromium.org> Date: Tue Sep 06 17:55:17 2016 Fix an issue that download progress notification is shown when killing browser When browser gets killed, we should show a paused notification. However, onTaskRemoved() is often called too early before process fully stops. As a result, a progress notification can arrive after Chrome changes all the notification to paused. This may cause chrome to show a paused notification and then immediately change it to progress while killing the browser. Only progress notification matters, cancel/pause doesn't really matter. BUG= 642191 TBR=dfalcantara@chromium.org Review-Url: https://codereview.chromium.org/2296913002 Cr-Commit-Position: refs/heads/master@{#415439} (cherry picked from commit 540399d5f34abfcae1828e2c36835ffae391e319) Review URL: https://codereview.chromium.org/2311253003 . Cr-Commit-Position: refs/branch-heads/2840@{#176} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/1319e021631140e015810e7ab989212700cecc3c/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java
,
Sep 6 2016
,
Sep 7 2016
Verified in 54.0.2840.15
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1319e021631140e015810e7ab989212700cecc3c commit 1319e021631140e015810e7ab989212700cecc3c Author: Min Qin <qinmin@chromium.org> Date: Tue Sep 06 17:55:17 2016 Fix an issue that download progress notification is shown when killing browser When browser gets killed, we should show a paused notification. However, onTaskRemoved() is often called too early before process fully stops. As a result, a progress notification can arrive after Chrome changes all the notification to paused. This may cause chrome to show a paused notification and then immediately change it to progress while killing the browser. Only progress notification matters, cancel/pause doesn't really matter. BUG= 642191 TBR=dfalcantara@chromium.org Review-Url: https://codereview.chromium.org/2296913002 Cr-Commit-Position: refs/heads/master@{#415439} (cherry picked from commit 540399d5f34abfcae1828e2c36835ffae391e319) Review URL: https://codereview.chromium.org/2311253003 . Cr-Commit-Position: refs/branch-heads/2840@{#176} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/1319e021631140e015810e7ab989212700cecc3c/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java |
|||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||
Comment 1 by krav...@chromium.org
, Sep 1 2016Status: Assigned (was: Unconfirmed)