New issue
Advanced search Search tips

Issue 642170 link

Starred by 4 users
Status: Fixed
Owner:
dmazz...@chromium.org
Closed: Sep 2016
Cc:
dmazz...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug
Team-Accessibility

Blocking:
issue 607290
issue 638175
issue 639264
issue 640859



Sign in to add a comment

RenderAccessibilityImpl::SnapshotAccessibilityTree needs to update layout

Project Member Reported by dmazz...@chromium.org, Aug 29 2016 
I think this is the underlying cause of several bugs (see blocking bugs).

When RenderAccessibilityImpl::SnapshotAccessibilityTree is called, we're building an accessibility tree, which assumes that layout is clean, but that may not necessarily be the case.

We need an explicit call to WebAXObject::updateLayoutAndCheckValidity() just before serialization.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 30 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/934c7bc4689a313f5e62123a61929755bac5ff6a

commit 934c7bc4689a313f5e62123a61929755bac5ff6a
Author: dmazzoni <dmazzoni@chromium.org>
Date: Tue Aug 30 21:10:55 2016

RenderAccessibilityImpl::SnapshotAccessibilityTree should ensure layout clean.

BUG= 642170 

Review-Url: https://codereview.chromium.org/2294623002
Cr-Commit-Position: refs/heads/master@{#415426}

[modify] https://crrev.com/934c7bc4689a313f5e62123a61929755bac5ff6a/content/renderer/accessibility/render_accessibility_impl.cc

Comment 2 by dmazz...@chromium.org, Sep 1 2016

Status: Fixed (was: Assigned)

Comment 3 by awhalley@chromium.org, Oct 7 2016

Labels: Merge-Request-54
Requesting merge to M54 due to this being a fix for 640859

Comment 4 by dimu@chromium.org, Oct 7 2016

Labels: -Merge-Request-54 Merge-Review-54 Hotlist-Merge-Review
[Automated comment] Less than 2 weeks to go before stable on M54, manual review required.

Comment 5 by awhalley@chromium.org, Oct 7 2016 

(and 638175)

Comment 6 by bustamante@google.com, Oct 10 2016

Labels: -Merge-Review-54 Merge-Approved-54
Merge approved for M54

Comment 7 by dmazz...@chromium.org, Oct 11 2016 

Merging to branch 2840 now
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 11 2016

Labels: -merge-approved-54 merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dfc5e8bb4d41f9fe226f168560a56e84db43d937

commit dfc5e8bb4d41f9fe226f168560a56e84db43d937
Author: Dominic Mazzoni <dmazzoni@chromium.org>
Date: Tue Oct 11 18:40:00 2016

Merge to M54: RenderAccessibilityImpl::SnapshotAccessibilityTree should ensure layout clean.

BUG= 642170 

Review-Url: https://codereview.chromium.org/2294623002
Cr-Commit-Position: refs/heads/master@{#415426}
(cherry picked from commit 934c7bc4689a313f5e62123a61929755bac5ff6a)

Review URL: https://codereview.chromium.org/2413453002 .

Cr-Commit-Position: refs/branch-heads/2840@{#717}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/dfc5e8bb4d41f9fe226f168560a56e84db43d937/content/renderer/accessibility/render_accessibility_impl.cc

Comment 9 by dmazz...@chromium.org, Oct 25 2016

Cc: dmazz...@chromium.org
 Issue 501622  has been merged into this issue.
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dfc5e8bb4d41f9fe226f168560a56e84db43d937

commit dfc5e8bb4d41f9fe226f168560a56e84db43d937
Author: Dominic Mazzoni <dmazzoni@chromium.org>
Date: Tue Oct 11 18:40:00 2016

Merge to M54: RenderAccessibilityImpl::SnapshotAccessibilityTree should ensure layout clean.

BUG= 642170 

Review-Url: https://codereview.chromium.org/2294623002
Cr-Commit-Position: refs/heads/master@{#415426}
(cherry picked from commit 934c7bc4689a313f5e62123a61929755bac5ff6a)

Review URL: https://codereview.chromium.org/2413453002 .

Cr-Commit-Position: refs/branch-heads/2840@{#717}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/dfc5e8bb4d41f9fe226f168560a56e84db43d937/content/renderer/accessibility/render_accessibility_impl.cc
►

Sign in to add a comment