[cr-toolbar] Incorrect padding in RTL narrow mode |
||||||
Issue description
,
Sep 2 2016
Dan: this affects MD Downloads in M54. Should I merge this fix back?
,
Sep 2 2016
ehhhhhhhhhhhhh, I suppose so
,
Sep 4 2016
With that vote of support, requesting merge of #1 to M54.
,
Sep 4 2016
Your change meets the bar and is auto-approved for M54 (branch: 2840)
,
Sep 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5272a81bc1a3b7403ceb33e5bfb2c30aaccbc3be commit 5272a81bc1a3b7403ceb33e5bfb2c30aaccbc3be Author: Tim Sergeant <tsergeant@chromium.org> Date: Sun Sep 04 23:36:27 2016 MD Downloads/History: Fix CSS selector that was mistakenly LTR-only This fixes incorrect padding in the toolbar search field for RTL languages. BUG= 642169 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2294613002 Cr-Commit-Position: refs/heads/master@{#415206} (cherry picked from commit fe32a27d5519cfeec388333ebc091af07a58c8b1) Review URL: https://codereview.chromium.org/2311693002 . Cr-Commit-Position: refs/branch-heads/2840@{#144} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/5272a81bc1a3b7403ceb33e5bfb2c30aaccbc3be/chrome/browser/resources/md_downloads/vulcanized.html [modify] https://crrev.com/5272a81bc1a3b7403ceb33e5bfb2c30aaccbc3be/chrome/browser/resources/md_history/app.vulcanized.html [modify] https://crrev.com/5272a81bc1a3b7403ceb33e5bfb2c30aaccbc3be/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html
,
Sep 4 2016
,
Sep 6 2016
Tested the same on win10 chrome version 54.0.2840.14 - Navigated to chrome://history and observed the search field as shown in the screenshot. Could you please let us know the expected behavior to verify the fix from test team end.
,
Sep 6 2016
,
Sep 7 2016
Screenshot of the intended behavior attached. 1. Open downloads in RTL language 2. Resize window to less than 900px wide 3. Click search icon There should be 18px of padding on the right side of the screen, as shown. The bug caused there to no padding to the right of the search icon.
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5272a81bc1a3b7403ceb33e5bfb2c30aaccbc3be commit 5272a81bc1a3b7403ceb33e5bfb2c30aaccbc3be Author: Tim Sergeant <tsergeant@chromium.org> Date: Sun Sep 04 23:36:27 2016 MD Downloads/History: Fix CSS selector that was mistakenly LTR-only This fixes incorrect padding in the toolbar search field for RTL languages. BUG= 642169 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2294613002 Cr-Commit-Position: refs/heads/master@{#415206} (cherry picked from commit fe32a27d5519cfeec388333ebc091af07a58c8b1) Review URL: https://codereview.chromium.org/2311693002 . Cr-Commit-Position: refs/branch-heads/2840@{#144} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/5272a81bc1a3b7403ceb33e5bfb2c30aaccbc3be/chrome/browser/resources/md_downloads/vulcanized.html [modify] https://crrev.com/5272a81bc1a3b7403ceb33e5bfb2c30aaccbc3be/chrome/browser/resources/md_history/app.vulcanized.html [modify] https://crrev.com/5272a81bc1a3b7403ceb33e5bfb2c30aaccbc3be/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Aug 30 2016