New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 642169 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Not on Chrome
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

[cr-toolbar] Incorrect padding in RTL narrow mode

Project Member Reported by tsergeant@chromium.org, Aug 29 2016

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Aug 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fe32a27d5519cfeec388333ebc091af07a58c8b1

commit fe32a27d5519cfeec388333ebc091af07a58c8b1
Author: tsergeant <tsergeant@chromium.org>
Date: Tue Aug 30 06:12:45 2016

MD Downloads/History: Fix CSS selector that was mistakenly LTR-only

This fixes incorrect padding in the toolbar search field for RTL
languages.

BUG= 642169 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2294613002
Cr-Commit-Position: refs/heads/master@{#415206}

[modify] https://crrev.com/fe32a27d5519cfeec388333ebc091af07a58c8b1/chrome/browser/resources/md_downloads/vulcanized.html
[modify] https://crrev.com/fe32a27d5519cfeec388333ebc091af07a58c8b1/chrome/browser/resources/md_history/app.vulcanized.html
[modify] https://crrev.com/fe32a27d5519cfeec388333ebc091af07a58c8b1/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html

Dan: this affects MD Downloads in M54. Should I merge this fix back?

Comment 3 by dbeam@chromium.org, Sep 2 2016

ehhhhhhhhhhhhh, I suppose so
Labels: Merge-Request-54
With that vote of support, requesting merge of #1 to M54.

Comment 5 by dimu@chromium.org, Sep 4 2016

Labels: -Merge-Request-54 Merge-Approved-54 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M54 (branch: 2840)
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 4 2016

Labels: -merge-approved-54 merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5272a81bc1a3b7403ceb33e5bfb2c30aaccbc3be

commit 5272a81bc1a3b7403ceb33e5bfb2c30aaccbc3be
Author: Tim Sergeant <tsergeant@chromium.org>
Date: Sun Sep 04 23:36:27 2016

MD Downloads/History: Fix CSS selector that was mistakenly LTR-only

This fixes incorrect padding in the toolbar search field for RTL
languages.

BUG= 642169 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2294613002
Cr-Commit-Position: refs/heads/master@{#415206}
(cherry picked from commit fe32a27d5519cfeec388333ebc091af07a58c8b1)

Review URL: https://codereview.chromium.org/2311693002 .

Cr-Commit-Position: refs/branch-heads/2840@{#144}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/5272a81bc1a3b7403ceb33e5bfb2c30aaccbc3be/chrome/browser/resources/md_downloads/vulcanized.html
[modify] https://crrev.com/5272a81bc1a3b7403ceb33e5bfb2c30aaccbc3be/chrome/browser/resources/md_history/app.vulcanized.html
[modify] https://crrev.com/5272a81bc1a3b7403ceb33e5bfb2c30aaccbc3be/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html

Status: Fixed (was: Started)
Cc: tkonch...@chromium.org
Labels: Needs-Feedback
Tested the same on win10 chrome version 54.0.2840.14 - Navigated to chrome://history and observed the search field as shown in the screenshot.

Could you please let us know the expected behavior to verify the fix from test team end.
642169.png
44.0 KB View Download
Screenshot of the intended behavior attached.

1. Open downloads in RTL language
2. Resize window to less than 900px wide
3. Click search icon

There should be 18px of padding on the right side of the screen, as shown. The bug caused there to no padding to the right of the search icon.
9TGQewVNG9e.png
54.8 KB View Download
Project Member

Comment 11 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5272a81bc1a3b7403ceb33e5bfb2c30aaccbc3be

commit 5272a81bc1a3b7403ceb33e5bfb2c30aaccbc3be
Author: Tim Sergeant <tsergeant@chromium.org>
Date: Sun Sep 04 23:36:27 2016

MD Downloads/History: Fix CSS selector that was mistakenly LTR-only

This fixes incorrect padding in the toolbar search field for RTL
languages.

BUG= 642169 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2294613002
Cr-Commit-Position: refs/heads/master@{#415206}
(cherry picked from commit fe32a27d5519cfeec388333ebc091af07a58c8b1)

Review URL: https://codereview.chromium.org/2311693002 .

Cr-Commit-Position: refs/branch-heads/2840@{#144}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/5272a81bc1a3b7403ceb33e5bfb2c30aaccbc3be/chrome/browser/resources/md_downloads/vulcanized.html
[modify] https://crrev.com/5272a81bc1a3b7403ceb33e5bfb2c30aaccbc3be/chrome/browser/resources/md_history/app.vulcanized.html
[modify] https://crrev.com/5272a81bc1a3b7403ceb33e5bfb2c30aaccbc3be/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html

Sign in to add a comment