New issue
Advanced search Search tips

Issue 642165 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

Delete Net GYP files

Project Member Reported by brettw@chromium.org, Aug 29 2016

Issue description

At a simple level, the variables from net/net.gypi need to be inlined into BUILD.gn.

This is more tricky some some of these lists seem to be autogenerated by a script net/data/update_net_gypi.py

On a related note, the network build is pretty out-of-control. The obviuos cleanup is to make many separate build files for the different components, so that //net would conditionally depend on //net/websockets instead of having //net have a huge list of all websocket files inline. However, the dependencies may be too tangled to make a proper DAG out of the build
 

Comment 1 by mmenke@chromium.org, Aug 31 2016

Cc: mmenke@chromium.org
//net/websockets would have to depend on //net/, not the other way around.  The only dependencies //net/ has on //net/websockets is a couple interfaces, so I think that particular dependency wouldn't be too hard to unwrangle into a net_websockets component.
Status: Available (was: Unconfirmed)
Status: Fixed (was: Available)
That has already been done by 
https://codereview.chromium.org/2641413003
https://codereview.chromium.org/2655093002

Marking as fixed.

Sign in to add a comment