New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 642155 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Call setAllowsAutomaticWindowTabbing:NO on all Chrome-related Windows.

Project Member Reported by erikc...@chromium.org, Aug 29 2016

Issue description

From https://docs.google.com/document/d/1IYcQhT4h21AdICAAj4q2AjOtnJllppdkyofzR3iN0h4/edit#
"""
Tabbing
Applications that already support tabbing should explicitly opt-out of automatic window tabbing by calling [NSWindow setAllowsAutomaticWindowTabbing:NO].... The default value for allowsAutomaticWindowTabbing will be YES for all applications except for some that are specifically black-listed out.
"""

 
Cc: erikc...@chromium.org
Owner: ----
Status: Untriaged (was: Assigned)
Summary: Call setAllowsAutomaticWindowTabbing:NO on all Chrome-related Windows. (was: Call setAllowsAutomaticWindowTabbing:NO.)

Comment 2 by shrike@chromium.org, Aug 29 2016

Labels: -Pri-3 M-55 Pri-2
Owner: sdy@chromium.org
Status: Assigned (was: Untriaged)
It seems that we're already on Sierra's tabbing blacklist but we should explicitly exempt ourselves using this API.

Comment 3 by sdy@chromium.org, Sep 10 2016

Status: Started (was: Assigned)
CL is out:
https://codereview.chromium.org/2325313002/
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 12 2016

Comment 5 by sdy@chromium.org, Sep 12 2016

Status: Fixed (was: Started)
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b9c29dbbb6aea2261a452b31725ecdd97dce5c43

commit b9c29dbbb6aea2261a452b31725ecdd97dce5c43
Author: sdy <sdy@chromium.org>
Date: Wed Sep 14 02:57:08 2016

Move NSWindow.allowsAutomaticWindowTabbing forward declaration to the right place.

When I added it in this CL:
https://codereview.chromium.org/2325313002/

…it worked for 10.11 (coincidentally) but not for the 10.12 SDK.

BUG= 642155 

Review-Url: https://codereview.chromium.org/2339563004
Cr-Commit-Position: refs/heads/master@{#418466}

[modify] https://crrev.com/b9c29dbbb6aea2261a452b31725ecdd97dce5c43/base/mac/sdk_forward_declarations.h

Comment 7 by sdy@chromium.org, Oct 13 2016

Cc: sdy@chromium.org
 Issue 624062  has been merged into this issue.

Sign in to add a comment