New issue
Advanced search Search tips

Issue 642148 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 624128



Sign in to add a comment

DefaultComponentInstaller::FinishRegistration does not update CrxComponent::supports_group_policy_enable_component_updates

Project Member Reported by sorin@chromium.org, Aug 29 2016

Issue description

The code in DefaultComponentInstaller::FinishRegistration is not updating the value of CrxComponent::supports_group_policy_enable_component_updates with the value provided by the specific installer traits. Therefore, the components using the DefaultComponentInstaller for their installer ignore the group policy settings for controlling the update behavior.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/098a4a79496d92de9f1740b84cc45bd2b2713292

commit 098a4a79496d92de9f1740b84cc45bd2b2713292
Author: sorin <sorin@chromium.org>
Date: Tue Aug 30 04:43:24 2016

Fix DefaultComponentInstaller::FinishRegistration and group policy.

The code in DefaultComponentInstaller::FinishRegistration is not updating
the value of CrxComponent::supports_group_policy_enable_component_updates
with the value provided by the specific installer traits.

Therefore, the components using the DefaultComponentInstaller for their
installer ignore the group policy settings for controlling the update behavior.

BUG= 642148 

Review-Url: https://codereview.chromium.org/2292463004
Cr-Commit-Position: refs/heads/master@{#415110}

[modify] https://crrev.com/098a4a79496d92de9f1740b84cc45bd2b2713292/components/component_updater/default_component_installer.cc
[modify] https://crrev.com/098a4a79496d92de9f1740b84cc45bd2b2713292/components/component_updater/default_component_installer_unittest.cc

Comment 2 by sorin@chromium.org, Aug 30 2016

Status: Fixed (was: Started)

Comment 3 by sorin@chromium.org, Aug 30 2016

I verified that the group policies are effective by inspecting the update check. 

Comment 4 by sorin@chromium.org, Sep 1 2016

Labels: Merge-Request-54

Comment 5 by dimu@chromium.org, Sep 1 2016

Labels: -Merge-Request-54 Merge-Approved-54 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M54 (branch: 2840)
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 2 2016

Labels: -merge-approved-54 merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f5ea24ca3d49b213b7be2b25538d82321c13903

commit 3f5ea24ca3d49b213b7be2b25538d82321c13903
Author: sorin <sorin@chromium.org>
Date: Fri Sep 02 18:44:42 2016

Fix DefaultComponentInstaller::FinishRegistration and group policy.

The code in DefaultComponentInstaller::FinishRegistration is not updating
the value of CrxComponent::supports_group_policy_enable_component_updates
with the value provided by the specific installer traits.

Therefore, the components using the DefaultComponentInstaller for their
installer ignore the group policy settings for controlling the update behavior.

BUG= 642148 
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2292463004
Cr-Commit-Position: refs/heads/master@{#415110}
(cherry picked from commit 098a4a79496d92de9f1740b84cc45bd2b2713292)

Merging into M54 branch 2840

Review-Url: https://codereview.chromium.org/2310493002
Cr-Commit-Position: refs/branch-heads/2840@{#128}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/3f5ea24ca3d49b213b7be2b25538d82321c13903/components/component_updater/default_component_installer.cc
[modify] https://crrev.com/3f5ea24ca3d49b213b7be2b25538d82321c13903/components/component_updater/default_component_installer_unittest.cc

Project Member

Comment 7 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f5ea24ca3d49b213b7be2b25538d82321c13903

commit 3f5ea24ca3d49b213b7be2b25538d82321c13903
Author: sorin <sorin@chromium.org>
Date: Fri Sep 02 18:44:42 2016

Fix DefaultComponentInstaller::FinishRegistration and group policy.

The code in DefaultComponentInstaller::FinishRegistration is not updating
the value of CrxComponent::supports_group_policy_enable_component_updates
with the value provided by the specific installer traits.

Therefore, the components using the DefaultComponentInstaller for their
installer ignore the group policy settings for controlling the update behavior.

BUG= 642148 
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2292463004
Cr-Commit-Position: refs/heads/master@{#415110}
(cherry picked from commit 098a4a79496d92de9f1740b84cc45bd2b2713292)

Merging into M54 branch 2840

Review-Url: https://codereview.chromium.org/2310493002
Cr-Commit-Position: refs/branch-heads/2840@{#128}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/3f5ea24ca3d49b213b7be2b25538d82321c13903/components/component_updater/default_component_installer.cc
[modify] https://crrev.com/3f5ea24ca3d49b213b7be2b25538d82321c13903/components/component_updater/default_component_installer_unittest.cc

Sign in to add a comment