New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 642117 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Feb 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 537368



Sign in to add a comment

LLVM: libnih doesn't work with clang -mthumb

Project Member Reported by laszio@chromium.org, Aug 29 2016

Issue description

The resulted image failed to boot.
 
Owner: laszio@chromium.org
Status: Assigned (was: Untriaged)
Summary: LLVM: libnih doesn't work with clang -mthumb (was: libnih doesn't work with clang -mthumb)
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/e87ccfb2130095282705b769d2d6f9a2be7627ba

commit e87ccfb2130095282705b769d2d6f9a2be7627ba
Author: Ting-Yuan Huang <laszio@chromium.org>
Date: Mon Aug 29 22:07:23 2016

sys-libs/libnih: always use gcc to build libnih

clang's having trouble building libnih with -mthumb.
The image doesn't boot.

BUG= chromium:642117 
TEST=compiles and boots

Change-Id: I5a7498901e1be56166be8f113131b14042e453c4
Reviewed-on: https://chromium-review.googlesource.com/377598
Commit-Ready: Ting-Yuan Huang <laszio@chromium.org>
Tested-by: Ting-Yuan Huang <laszio@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[add] https://crrev.com/e87ccfb2130095282705b769d2d6f9a2be7627ba/chromeos/config/env/sys-libs/libnih

Labels: llvm-runtime
Owner: yunlian@chromium.org
Status: Started (was: Assigned)
llvm-next does not have this problem.
Will mark this as fixed and remove the workaround once the llvm upgrade completes.

Comment 6 by laszio@chromium.org, Jan 25 2017

Cc: laszio@chromium.org
 Issue 638998  has been merged into this issue.
Project Member

Comment 7 by bugdroid1@chromium.org, Feb 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/176484cd9e11ed7f1bcfa1c07c106240773929fd

commit 176484cd9e11ed7f1bcfa1c07c106240773929fd
Author: Yunlian Jiang <yunlian@google.com>
Date: Tue Feb 14 22:50:42 2017

libnih: use clang to build it.

We upgraded llvm and libnih works with new llvm on
arm now.

BUG= chromium:642117 
TEST=build libnih for veyron_jaq and it boots.

Change-Id: I085ba300ae9a65a0bdbca1c80ff059a68bf5a1c8
Reviewed-on: https://chromium-review.googlesource.com/442008
Commit-Ready: Yunlian Jiang <yunlian@chromium.org>
Tested-by: Yunlian Jiang <yunlian@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>

[delete] https://crrev.com/4b25e9b6d2bdb796a318429cd492d296c6c9e654/chromeos/config/env/sys-libs/libnih

Status: Fixed (was: Started)
Status: Verified (was: Fixed)

Sign in to add a comment