New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 642092 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Merging CLD3 CL into M54

Project Member Reported by abakalov@chromium.org, Aug 29 2016

Issue description

We'd like to merge the following CL into M54. This CL updates the language identification model (CLD3):
https://codereview.chromium.org/2283683002/
 

Comment 1 by zkoch@chromium.org, Aug 29 2016

Cc: groby@chromium.org
Labels: Merge-Request-54
Owner: abakalov@chromium.org
Status: Started (was: Untriaged)
Requesting to mege https://crrev.com/e73e1a1f69d9ac7dc8216f930544aa5650d74ef2 to M-54.

Comment 3 by zkoch@chromium.org, Aug 30 2016

Cc: rouslan@chromium.org

Comment 4 by zkoch@chromium.org, Aug 30 2016

Cc: zkoch@chromium.org

Comment 5 by dimu@chromium.org, Aug 30 2016

Labels: -Merge-Request-54 Merge-Approved-54 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M54 (branch: 2840)
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 31 2016

Labels: -merge-approved-54 merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c61682761c85cab9278605284c93f2c7dc3d0eed

commit c61682761c85cab9278605284c93f2c7dc3d0eed
Author: Rouslan Solomakhin <rouslan@chromium.org>
Date: Wed Aug 31 02:29:20 2016

[Merge M-54] Updating the CLD3 GitHub commit hash in DEPS

This change results in chunks from the input getting removed if they
contain repetitive strings or mostly spaces.

BUG= 642092 

Review-Url: https://codereview.chromium.org/2283683002
Cr-Commit-Position: refs/heads/master@{#414767}
(cherry picked from commit e73e1a1f69d9ac7dc8216f930544aa5650d74ef2)

Review URL: https://codereview.chromium.org/2295033002 .

Cr-Commit-Position: refs/branch-heads/2840@{#58}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/c61682761c85cab9278605284c93f2c7dc3d0eed/DEPS

Status: Fixed (was: Started)
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c61682761c85cab9278605284c93f2c7dc3d0eed

commit c61682761c85cab9278605284c93f2c7dc3d0eed
Author: Rouslan Solomakhin <rouslan@chromium.org>
Date: Wed Aug 31 02:29:20 2016

[Merge M-54] Updating the CLD3 GitHub commit hash in DEPS

This change results in chunks from the input getting removed if they
contain repetitive strings or mostly spaces.

BUG= 642092 

Review-Url: https://codereview.chromium.org/2283683002
Cr-Commit-Position: refs/heads/master@{#414767}
(cherry picked from commit e73e1a1f69d9ac7dc8216f930544aa5650d74ef2)

Review URL: https://codereview.chromium.org/2295033002 .

Cr-Commit-Position: refs/branch-heads/2840@{#58}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/c61682761c85cab9278605284c93f2c7dc3d0eed/DEPS

Sign in to add a comment