Issue 642086 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	█ jwd@chromium.org Last visit > 30 days ago
Closed:	Jan 2017
Cc:	gayane@chromium.org asvitk...@chromium.org skare@chromium.org isherman@chromium.org █ rkaplow@chromium.org
Components:	Internals>Metrics
EstimatedDays:	----
NextAction:	----
OS:	Android , Windows
Pri:	1
Type:	Feature
M-54 Hotlist-Merge-Approved merge-merged-2840

Blocking:
issue 609987

Support first-run when controlling metrics/crash sampling with a field trial.

Project Member Reported by jwd@chromium.org, Aug 29 2016

Issue description

Support first-run when controlling metrics/crash sampling with a field trial.

This will be by creating a local field trial that gets created when no Variation seed was applied. 

It's needed because otherwise, clients can start in an unsampled state on first-run, then be switched into a sampled out state on the next run. This would look like client stopped using chrome, and would affect retention analysis.

We only support sampling on Windows and Android.

Comment 1 by jwd@chromium.org, Aug 29 2016

Labels: M-54

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/34f77fad8128e9b51db959a4a1f9ab6bfcb08257

commit 34f77fad8128e9b51db959a4a1f9ab6bfcb08257
Author: jwd <jwd@chromium.org>
Date: Tue Aug 30 22:53:03 2016

Adding local field trial for metrics/crash reports sampling.

This is to support the first-run case, if no first-run variations seed was available.

BUG= 642086 

Review-Url: https://codereview.chromium.org/2288853003
Cr-Commit-Position: refs/heads/master@{#415473}

[modify] https://crrev.com/34f77fad8128e9b51db959a4a1f9ab6bfcb08257/chrome/browser/chrome_browser_field_trials.cc
[modify] https://crrev.com/34f77fad8128e9b51db959a4a1f9ab6bfcb08257/chrome/browser/chrome_browser_field_trials.h
[modify] https://crrev.com/34f77fad8128e9b51db959a4a1f9ab6bfcb08257/chrome/browser/chrome_browser_main.cc
[modify] https://crrev.com/34f77fad8128e9b51db959a4a1f9ab6bfcb08257/chrome/browser/metrics/chrome_metrics_services_manager_client.cc
[modify] https://crrev.com/34f77fad8128e9b51db959a4a1f9ab6bfcb08257/chrome/browser/metrics/chrome_metrics_services_manager_client.h

Comment 3 by jwd@chromium.org, Sep 1 2016

Labels: Merge-Request-54

Comment 4 by dimu@chromium.org, Sep 1 2016

Labels: -Merge-Request-54 Merge-Approved-54 Hotlist-Merge-Approved

Your change meets the bar and is auto-approved for M54 (branch: 2840)

Project Member

Comment 5 by bugdroid1@chromium.org, Sep 1 2016

Labels: -merge-approved-54 merge-merged-2840

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e158024699e3cb4950bd95e0fc977126569fee66

commit e158024699e3cb4950bd95e0fc977126569fee66
Author: Jesse Doherty <jwd@chromium.org>
Date: Thu Sep 01 15:12:08 2016

Adding local field trial for metrics/crash reports sampling.

This is to support the first-run case, if no first-run variations seed was available.

BUG= 642086 

Review-Url: https://codereview.chromium.org/2288853003
Cr-Commit-Position: refs/heads/master@{#415473}
(cherry picked from commit 34f77fad8128e9b51db959a4a1f9ab6bfcb08257)

Review URL: https://codereview.chromium.org/2302043002 .

Cr-Commit-Position: refs/branch-heads/2840@{#97}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/e158024699e3cb4950bd95e0fc977126569fee66/chrome/browser/chrome_browser_field_trials.cc
[modify] https://crrev.com/e158024699e3cb4950bd95e0fc977126569fee66/chrome/browser/chrome_browser_field_trials.h
[modify] https://crrev.com/e158024699e3cb4950bd95e0fc977126569fee66/chrome/browser/chrome_browser_main.cc
[modify] https://crrev.com/e158024699e3cb4950bd95e0fc977126569fee66/chrome/browser/metrics/chrome_metrics_services_manager_client.cc
[modify] https://crrev.com/e158024699e3cb4950bd95e0fc977126569fee66/chrome/browser/metrics/chrome_metrics_services_manager_client.h

Comment 6 by jwd@chromium.org, Sep 1 2016

Status: Fixed (was: Started)

Comment 7 by jwd@chromium.org, Sep 2 2016

Status: Started (was: Fixed)

Re-opening to add sampling on non-stable channels.

Project Member

Comment 8 by bugdroid1@chromium.org, Sep 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a4be06b817d63f6461d5b6191040b298ae22437

commit 1a4be06b817d63f6461d5b6191040b298ae22437
Author: jwd <jwd@chromium.org>
Date: Tue Sep 06 17:46:01 2016

Adding client side field trial for sampling on non-stable channels.

BUG= 642086 

Review-Url: https://codereview.chromium.org/2307953002
Cr-Commit-Position: refs/heads/master@{#416653}

[modify] https://crrev.com/1a4be06b817d63f6461d5b6191040b298ae22437/chrome/browser/chrome_browser_field_trials.cc
[modify] https://crrev.com/1a4be06b817d63f6461d5b6191040b298ae22437/chrome/browser/metrics/chrome_metrics_services_manager_client.cc
[modify] https://crrev.com/1a4be06b817d63f6461d5b6191040b298ae22437/chrome/browser/metrics/chrome_metrics_services_manager_client.h

Project Member

Comment 9 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e158024699e3cb4950bd95e0fc977126569fee66

commit e158024699e3cb4950bd95e0fc977126569fee66
Author: Jesse Doherty <jwd@chromium.org>
Date: Thu Sep 01 15:12:08 2016

Adding local field trial for metrics/crash reports sampling.

This is to support the first-run case, if no first-run variations seed was available.

BUG= 642086 

Review-Url: https://codereview.chromium.org/2288853003
Cr-Commit-Position: refs/heads/master@{#415473}
(cherry picked from commit 34f77fad8128e9b51db959a4a1f9ab6bfcb08257)

Review URL: https://codereview.chromium.org/2302043002 .

Cr-Commit-Position: refs/branch-heads/2840@{#97}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/e158024699e3cb4950bd95e0fc977126569fee66/chrome/browser/chrome_browser_field_trials.cc
[modify] https://crrev.com/e158024699e3cb4950bd95e0fc977126569fee66/chrome/browser/chrome_browser_field_trials.h
[modify] https://crrev.com/e158024699e3cb4950bd95e0fc977126569fee66/chrome/browser/chrome_browser_main.cc
[modify] https://crrev.com/e158024699e3cb4950bd95e0fc977126569fee66/chrome/browser/metrics/chrome_metrics_services_manager_client.cc
[modify] https://crrev.com/e158024699e3cb4950bd95e0fc977126569fee66/chrome/browser/metrics/chrome_metrics_services_manager_client.h

Comment 10 by asvitk...@chromium.org, Jan 29 2017

Status: Fixed (was: Started)

►

Issue 642086 link

Issue metadata

Support first-run when controlling metrics/crash sampling with a field trial.

Issue description

Comment 1 by jwd@chromium.org, Aug 29 2016

Comment 1 Deleted

Comment 2 by bugdroid1@chromium.org, Aug 30 2016

Comment 2 Deleted

Comment 3 by jwd@chromium.org, Sep 1 2016

Comment 3 Deleted

Comment 4 by dimu@chromium.org, Sep 1 2016

Comment 4 Deleted

Comment 5 by bugdroid1@chromium.org, Sep 1 2016

Comment 5 Deleted

Comment 6 by jwd@chromium.org, Sep 1 2016

Comment 6 Deleted

Comment 7 by jwd@chromium.org, Sep 2 2016

Comment 7 Deleted

Comment 8 by bugdroid1@chromium.org, Sep 6 2016

Comment 8 Deleted

Comment 9 by bugdroid1@chromium.org, Oct 27 2016

Comment 9 Deleted

Comment 10 by asvitk...@chromium.org, Jan 29 2017

Comment 10 Deleted

Sign in to add a comment