New issue
Advanced search Search tips

Issue 642085 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 621721



Sign in to add a comment

OOBE Welcome screen should display icons matching screen DPI.

Project Member Reported by alemate@chromium.org, Aug 29 2016

Issue description

OOBE Welcome screen should display icons matching screen DPI.
 
Components: UI>Shell>OOBE
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a4c32ce963c3ff25beb2edbd857f8906c22ad6ac

commit a4c32ce963c3ff25beb2edbd857f8906c22ad6ac
Author: alemate <alemate@chromium.org>
Date: Wed Mar 15 19:39:58 2017

ChromeOS OOBE: display icons specific to screen DPI.

BUG= 642085 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2753513002
Cr-Commit-Position: refs/heads/master@{#457170}

[modify] https://crrev.com/a4c32ce963c3ff25beb2edbd857f8906c22ad6ac/chrome/browser/resources/chromeos/login/custom_elements_oobe.html
[modify] https://crrev.com/a4c32ce963c3ff25beb2edbd857f8906c22ad6ac/chrome/browser/resources/chromeos/login/custom_elements_oobe.js
[add] https://crrev.com/a4c32ce963c3ff25beb2edbd857f8906c22ad6ac/chrome/browser/resources/chromeos/login/hd-iron-icon.css
[add] https://crrev.com/a4c32ce963c3ff25beb2edbd857f8906c22ad6ac/chrome/browser/resources/chromeos/login/hd-iron-icon.html
[add] https://crrev.com/a4c32ce963c3ff25beb2edbd857f8906c22ad6ac/chrome/browser/resources/chromeos/login/hd-iron-icon.js
[modify] https://crrev.com/a4c32ce963c3ff25beb2edbd857f8906c22ad6ac/chrome/browser/resources/chromeos/login/oobe_buttons.html
[modify] https://crrev.com/a4c32ce963c3ff25beb2edbd857f8906c22ad6ac/chrome/browser/resources/chromeos/login/oobe_buttons.js
[modify] https://crrev.com/a4c32ce963c3ff25beb2edbd857f8906c22ad6ac/chrome/browser/resources/chromeos/login/oobe_dialog.html
[modify] https://crrev.com/a4c32ce963c3ff25beb2edbd857f8906c22ad6ac/chrome/browser/resources/chromeos/login/oobe_dialog_parameters.css
[modify] https://crrev.com/a4c32ce963c3ff25beb2edbd857f8906c22ad6ac/chrome/browser/resources/chromeos/login/oobe_eula.html
[modify] https://crrev.com/a4c32ce963c3ff25beb2edbd857f8906c22ad6ac/chrome/browser/resources/chromeos/login/oobe_welcome.html
[modify] https://crrev.com/a4c32ce963c3ff25beb2edbd857f8906c22ad6ac/chrome/browser/resources/chromeos/login/oobe_welcome_dialog.html
[modify] https://crrev.com/a4c32ce963c3ff25beb2edbd857f8906c22ad6ac/chrome/browser/resources/chromeos/login/oobe_welcome_secondary_button.css

Labels: -Pri-3 Merge-Request-58 M-58 Pri-1
Status: Fixed (was: Assigned)
Project Member

Comment 4 by sheriffbot@chromium.org, Mar 16 2017

Labels: -Merge-Request-58 Hotlist-Merge-Approved Merge-Approved-58
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 17 2017

Labels: -merge-approved-58 merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/103c785967163fe1f1e77566c7032e6fe9c0f17c

commit 103c785967163fe1f1e77566c7032e6fe9c0f17c
Author: Alexander Alekseev <alemate@chromium.org>
Date: Fri Mar 17 06:25:08 2017

ChromeOS OOBE: display icons specific to screen DPI.

BUG= 642085 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2753513002
Cr-Commit-Position: refs/heads/master@{#457170}
(cherry picked from commit a4c32ce963c3ff25beb2edbd857f8906c22ad6ac)

Review-Url: https://codereview.chromium.org/2759433004 .
Cr-Commit-Position: refs/branch-heads/3029@{#255}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/103c785967163fe1f1e77566c7032e6fe9c0f17c/chrome/browser/resources/chromeos/login/custom_elements_oobe.html
[modify] https://crrev.com/103c785967163fe1f1e77566c7032e6fe9c0f17c/chrome/browser/resources/chromeos/login/custom_elements_oobe.js
[add] https://crrev.com/103c785967163fe1f1e77566c7032e6fe9c0f17c/chrome/browser/resources/chromeos/login/hd-iron-icon.css
[add] https://crrev.com/103c785967163fe1f1e77566c7032e6fe9c0f17c/chrome/browser/resources/chromeos/login/hd-iron-icon.html
[add] https://crrev.com/103c785967163fe1f1e77566c7032e6fe9c0f17c/chrome/browser/resources/chromeos/login/hd-iron-icon.js
[modify] https://crrev.com/103c785967163fe1f1e77566c7032e6fe9c0f17c/chrome/browser/resources/chromeos/login/oobe_buttons.html
[modify] https://crrev.com/103c785967163fe1f1e77566c7032e6fe9c0f17c/chrome/browser/resources/chromeos/login/oobe_buttons.js
[modify] https://crrev.com/103c785967163fe1f1e77566c7032e6fe9c0f17c/chrome/browser/resources/chromeos/login/oobe_dialog.html
[modify] https://crrev.com/103c785967163fe1f1e77566c7032e6fe9c0f17c/chrome/browser/resources/chromeos/login/oobe_dialog_parameters.css
[modify] https://crrev.com/103c785967163fe1f1e77566c7032e6fe9c0f17c/chrome/browser/resources/chromeos/login/oobe_eula.html
[modify] https://crrev.com/103c785967163fe1f1e77566c7032e6fe9c0f17c/chrome/browser/resources/chromeos/login/oobe_welcome.html
[modify] https://crrev.com/103c785967163fe1f1e77566c7032e6fe9c0f17c/chrome/browser/resources/chromeos/login/oobe_welcome_dialog.html
[modify] https://crrev.com/103c785967163fe1f1e77566c7032e6fe9c0f17c/chrome/browser/resources/chromeos/login/oobe_welcome_secondary_button.css

Status: Verified (was: Fixed)

Sign in to add a comment