New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 642084 link

Starred by 13 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature


Participants' hotlists:
auth-polish


Sign in to add a comment

Always prompted for security code when users are hidden on login screen

Project Member Reported by derat@chromium.org, Aug 29 2016

Issue description

Present from at least M52 to ToT M55:

1. Make sure that 2FA (two-factor authentication a.k.a. 2SV a.k.a. 2-step verification) is enabled for your Google account.
2. At chrome://settings, click the "Manage other users..." button and uncheck "Show usernames and photos on the sign-in screen".
3. Log out and enter your email address and password on the login screen.

When I do this, I get prompted for a security code every single time I sign in. I can't see a good reason for this:

- If the user pods are shown on the login screen, I'm able to sign in with just my username and password.
- If the device is offline, I'm able to sign in with just my username and password.

Is this an unintentional artifact of us using the GAIA signin page here? Is there any way to tell it to not always ask for a security code?

(I'm not sure who knows the most about this nowadays.)
 
Cc: zalcorn@chromium.org alemate@chromium.org
Owner: zalcorn@chromium.org
Status: Assigned (was: Untriaged)
Interesting that I've also seen complaints from users in this setup that they DON'T get 2FA prompt on every sign in.

zalcorn@ AFAIK this is controlled from the GAIA side. We should decide what we want the behavior to actually be and work with GAIA to make it happen.

Comment 2 by derat@chromium.org, Aug 29 2016

Could you go into those complaints, and the perceived threat, in more detail? Do the users want their locally-synced data to be protected by 2FA? (If so, that doesn't really work, since taking the device offline prevents from being able to use 2FA, and I assume that we don't want to break offline signin...)
Labels: M-58
Labels: PM-zalcorn
Labels: -M-58 M-59

Comment 6 by dymp...@gmail.com, Feb 2 2017

#CBC-RS/TC-watchlist This has been the 2FA behaviour since forever and has confused many users in the forum.
Labels: Hotlist-auth-polish
Let me chat with GAIA and security about what the desired behavior is.
Owner: r...@chromium.org
@rkc, any thoughts about what we can do to bring consistency here? I think not requiring 2FA upon sign-in without pods unless GAIA asks for a re-auth is the right UX here.
Blocking: 702391

Comment 11 by r...@chromium.org, Apr 21 2017

Owner: wzang@chromium.org

Comment 12 by wzang@chromium.org, Apr 25 2017

Cc: r...@chromium.org
zalcorn@, we basically can't disable 2FA, because after user turns off 'show user name and photos on the sign-in screen', each time at sign-in screen they need to go through the 'Add new user' flow, which is controlled by the GAIA side. Another side effect is, if the device goes offline, because GAIA page is unavailable, no one is able to sign in anymore until it gets online again. 

What is the rational of hiding user name and photos? If it's different from adding a new user from scratch then we need to change its implementation, but first we need to have a new UI to replace the GAIA page.

Comment 13 by derat@chromium.org, Apr 25 2017

> Another side effect is, if the device goes offline,
> because GAIA page is unavailable, no one is able to
> sign in anymore until it gets online again.

IIRC, this isn't what I saw. When I was in offline mode, I was able to sign in using just my username and password.

> What is the rational of hiding user name and photos?

I think the main motivation is privacy, specifically not wanting to disclose your account name(s) to an attacker who gains access to your device while it's turned off.

Comment 14 by wzang@chromium.org, Apr 25 2017

derat@, I tried several times, but I only see the network selection page at the sign-in screen, after turning off 'show username and photos..' and going offline. I think that's because the current implementation of hiding username and photos is simply to call 'add new user'. I think we actually need a UI to hide username and photos but still use normal login user flow behind the scene.

Comment 15 by derat@chromium.org, Apr 25 2017

Thanks for testing it! Do you know if the implementation changed recently? I haven't needed to enable this setting since M55.

If the implementation now prevents offline signin, that's unfortunate, because it seems like it makes the device unusable until there's an available network once the setting has been enabled. Do we still allow guest sessions?

Comment 16 by wzang@chromium.org, Apr 25 2017

derat@, you are right. The network selection page still provides offline sign-in and guest session links. Then do you think we can replace the HandleShowAddUser() call here:
https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc?type=cs&l=1063

with HandleOfflineLogin() (or a new function with similar logic):
https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc?type=cs&l=1224

AFAIK, offline GAIA works both offline and online and it only allows existing users to sign in without showing username and photo, which might be more appropriate here. What do you think? (One downside I can think is that, we need to show 'Add new user' button at the bottom, however users might ignore that and think they can add new user by using the offline GAIA because it appears to be the same with normal GAIA)

Comment 17 by wzang@chromium.org, Apr 25 2017

Owner: zalcorn@chromium.org
@zalcorn, after offline discussion we think showing offline GAIA and 'add new user' button together is confusing. If you think the above solution is fine though please reassign it back to me, otherwise we'll remain the current implementation for now.

Comment 18 by wzang@chromium.org, Apr 25 2017

Cc: -r...@chromium.org wzang@chromium.org
Labels: -M-59 -Hotlist-auth-polish M-63
Agree it's confusing. Let's look at a more comprehensive solution at a later date, we have many higher priorities at the moment.
Blocking: -702391
Labels: -M-63 M-64
Labels: -Type-Bug Type-Feature
 Issue 749726  has been merged into this issue.
 Issue 793597  has been merged into this issue.

Comment 25 by tic...@gmail.com, Mar 3 2018

Just a heads up that some users would like this method of forcing 2FA to remain.

This user visiting the Pixelbook forum just this week was looking for just this solution, for example:

https://productforums.google.com/forum/?utm_medium=email&utm_source=footer#!msg/pixelbook/Bf8pEPcaBL0/wINcs7sXBAAJ

- Mike
Cc: jorgelo@chromium.org
If we want to provide a way for users to request that two-factor auth always be used when signing in (which will make it impossible to sign in while offline), there should be a separate setting for that. It shouldn't be tied to the unrelated concept of whether usernames are shown on the login screen or not. The fact that these are correlated right now sounds like it's just an artifact of the way that username-hiding was implemented.

Tangentially, I don't know what the implications of requiring 2FA are for on-disk user data. Won't it still only be protected by the user's password, limiting the utility of this? Would an "Always use ephemeral accounts" setting that discards the cryptohome on logout be a more effective way to force 2FA?
I would definitely prefer to have my Pixelbook prompt me for my second form of auth when I initially sign onto my Pixelbook. It is nice to have the extra layer of security at login in case my Pixelbook gets lost or stolen. It'll take more than just my password for a malicious user to get into my account.
I agree with Dan, these are two orthogonal concerns. Hiding or showing the pods should be independent of asking for 2SV for logging in.

This issue is concerned with the fact that hiding user pods changes the way we authenticate users, which sounds like a bug that should be fixed.

Independent of this, we should consider giving users the option to have the system always ask for 2SV when logging in. Dan is correct that this doesn't change the protection level of on-disk data -- the key for that does not take any input from the second factor.

It's weird that hiding user pods would put you in a situation where you would not be able to log in again until you're online. That is a bug. We should fix it.
So in fact you can log-in offline with hidden pods, and it skips 2SV - so all the current pods setting is currently providing is the illusion of 2SV on sign-in.

One way to fix this would be to always default to the offline sign-in when pods are hidden and only go through the full GAIA flow on password change or expired credentials.
Ah interesting thanks for the context. If we're not putting the user in an non-login-able situation, I think this is less urgent.

Ideally we'd still be able to completely detach 2SV from showing or hiding the pods. Is there a reason why we cannot do that?
Labels: Hotlist-ConOps-CrOS
(Bulk Edit) Adding the new conops Chrome OS hotlist to all open issues with the "#CBC-RS/TC-watchlist" tag, our former tracking tag.
Owner: jessejames@chromium.org
[bulk edit] moving OOBE/Login Feature Requests to Jesse.
Still an  issue 71 .0.3578.94
11151.59.0 (Official Build) beta-channel samus


Yep, this is still making 71.0.3578.94 (on the stable channel) harder to use for me too.

Sign in to add a comment