Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 1 user
Status: Duplicate
Merged: issue 640999
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment
Heap-use-after-free in base::ObserverListBase<content::RenderThreadObserver>::RemoveObserver
Project Member Reported by clusterf...@chromium.org, Aug 29 2016 Back to list
Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5765792664911872

Fuzzer: attekett_dom_fuzzer
Job Type: linux_asan_chrome_chromeos
Platform Id: linux

Crash Type: Heap-use-after-free READ 8
Crash Address: 0x6110000796c0
Crash State:
  base::ObserverListBase<content::RenderThreadObserver>::RemoveObserver
  content::ImageDownloaderImpl::~ImageDownloaderImpl
  content::ImageDownloaderImpl::~ImageDownloaderImpl
  
Recommended Security Severity: Medium


Unminimized Testcase: https://cluster-fuzz.appspot.com/download/AMIfv97XBdSQa4ic-T1XTMXXX8QDiUSjMLC_vXsEyzeyVwVYtTWfPilc8OLzP4QZxnasuXqSzCF7UY7YCq4jbMAKZ3cRF1BYgbnmSnJ4GaDbpcXqiUqp5QE74TPss__s5ztCqQT6ZQhGndhJXBVKfSfZpvxERID-OA?testcase_id=5765792664911872


Additional requirements: Requires Gestures

Issue filed automatically.

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Cc: roc...@chromium.org halton....@intel.com
Status: Assigned
Looks like regression from https://chromium.googlesource.com/chromium/src/+/ca2eabdc854a972db31fec01af6bb22ae643af4c

Author: halton.huo
Project: chromium
Changelist: https://chromium.googlesource.com/chromium/src/+/ca2eabdc854a972db31fec01af6bb22ae643af4c
Time: Mon Jul 06 08:17:40 2015
The CL last changed line 132 of file image_downloader_impl.cc, which is stack frame 4.
Owner: leon....@intel.com
I think https://chromium.googlesource.com/chromium/src.git/+/d2ac649bc631233f4355860a011d3d30f985bb67 should fix it, than CF will auto-close this. If not closed within a day, we should look more into this, might be another bug.
Components: Internals
Project Member Comment 4 by sheriffbot@chromium.org, Aug 30 2016
Labels: M-53
Project Member Comment 5 by sheriffbot@chromium.org, Aug 30 2016
Labels: Pri-1
Comment 6 by leon....@intel.com, Sep 6 2016
Hi, I suppose this bug has been fixed. Would you please help to confirm whether this crash can still be observed? If not, I'd like to close this. Thanks.
Project Member Comment 7 by clusterf...@chromium.org, Sep 6 2016
ClusterFuzz has detected this issue as fixed in range 416466:416526.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5765792664911872

Fuzzer: attekett_dom_fuzzer
Job Type: linux_asan_chrome_chromeos
Platform Id: linux

Crash Type: Heap-use-after-free READ 8
Crash Address: 0x6110000796c0
Crash State:
  base::ObserverListBase<content::RenderThreadObserver>::RemoveObserver
  content::ImageDownloaderImpl::~ImageDownloaderImpl
  content::ImageDownloaderImpl::~ImageDownloaderImpl
  
Recommended Security Severity: Medium

Fixed: https://cluster-fuzz.appspot.com/revisions?job=linux_asan_chrome_chromeos&range=416466:416526

Unminimized Testcase: https://cluster-fuzz.appspot.com/download/AMIfv97XBdSQa4ic-T1XTMXXX8QDiUSjMLC_vXsEyzeyVwVYtTWfPilc8OLzP4QZxnasuXqSzCF7UY7YCq4jbMAKZ3cRF1BYgbnmSnJ4GaDbpcXqiUqp5QE74TPss__s5ztCqQT6ZQhGndhJXBVKfSfZpvxERID-OA?testcase_id=5765792664911872


Additional requirements: Requires Gestures

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member Comment 8 by clusterf...@chromium.org, Sep 6 2016
Labels: ClusterFuzz-Verified
Status: Verified
ClusterFuzz testcase is verified as fixed, closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member Comment 9 by sheriffbot@chromium.org, Sep 7 2016
Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Project Member Comment 10 by sheriffbot@chromium.org, Sep 9 2016
Labels: Merge-Request-54
Comment 11 by dimu@chromium.org, Sep 10 2016
Labels: -Merge-Request-54 Merge-Approved-54 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M54 (branch: 2840)
Comment 12 by leon....@intel.com, Sep 12 2016
Will pick commit d2ac649bc631233f4355860a011d3d30f985bb67 into M54 branch soon.
Comment 13 by vabr@chromium.org, Sep 13 2016
Labels: -Merge-Approved-54 merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a64d2294bbe77cf839715bfefa407d61147e79d6

commit a64d2294bbe77cf839715bfefa407d61147e79d6
Author: Vaclav Brozek <vabr@chromium.org>
Date: Tue Sep 13 10:15:30 2016

Forbid ImageDownloaderImpl from accessing RenderThread instance after message loop shutdown.

This CL fixes the crash caused by following possible scenario:
- the message loop is shutdown.
- during its destructor it calls connection error on ImageDownloaderImpl.
- the strong binding of ImageDownloaderImpl causes it to be destructed.
- the destructor calls RenderThread::Get()->RemoveObserver(this),
  which is not valid any more.

BUG=  640999  
TBR=jochen@chromium.org

Review-Url: https://codereview.chromium.org/2286603002
Cr-Commit-Position: refs/heads/master@{#414985}
(cherry picked from commit d2ac649bc631233f4355860a011d3d30f985bb67)

Review URL: https://codereview.chromium.org/2335173002 .

Cr-Commit-Position: refs/branch-heads/2840@{#324}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/a64d2294bbe77cf839715bfefa407d61147e79d6/content/renderer/image_downloader/image_downloader_impl.cc

Labels: -Hotlist-Merge-Approved
Labels: Release-0-M54
Labels: CVE-2016-5190
Comment 17 by aarya@google.com, Oct 12 2016
Mergedinto: 640999
Status: Duplicate
Project Member Comment 18 by sheriffbot@chromium.org, Oct 12 2016
Labels: -reward-topanel reward-ineligible
Project Member Comment 19 by sheriffbot@chromium.org, Dec 14 2016
Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Sign in to add a comment