New issue
Advanced search Search tips

Issue 642058 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Feature
Proj-VR
Proj-XR
Proj-XR-VR

Blocked on:
issue 641461

Blocking:
issue 641038



Sign in to add a comment

VR: 3DOF controller: Reticle

Project Member Reported by girard@chromium.org, Aug 29 2016

Issue description

For 3DOF and 6DOF controllers, we want to show the user what the controller is pointed at. 

The current model is for a "laser pointer" to emerge from the controller's location (for a 3DOF controller, this will be an approximate location based on the "hand model") and track along the controller's orientation until it connects to a surface plane (such as a browser window or ui control).

Colour and intensity for the pointer should be controlled from the html5 ui interface. See issue 641413. This gives our ui designers an option to disable the reticle during video playback, for example.
 
Components: UI>Browser>VR
Summary: VR: Show reticle (was: Hoverboard: Show reticle)
Current plan is to adopt what we can from Daydream first-party reticle UX convention, modified for our unique use case: arbitrary web content, small target sizes, cursor conventions from desktop, etc.
Blockedon: -641413
Blocking: 641461
Summary: VR: Daydream controller: Reticle (was: VR: Show reticle)
Blocking: -641461
Blockedon: 641461
Summary: VR: 3DOF controller: Reticle (was: VR: Daydream controller: Reticle)
Labels: -M-55 M-56
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/07d8a34ed9c1f4292888b50a0f31797ccd0d39d6

commit 07d8a34ed9c1f4292888b50a0f31797ccd0d39d6
Author: cjgrant <cjgrant@chromium.org>
Date: Thu Oct 06 15:24:11 2016

Incorporate 15 degree laser beam angle on pointer.

- Point the beam 15 degrees down from where the controller is pointing, for wrist comfort.
- Fix the beam to point directly at the reticle.

BUG= 642058 

Review-Url: https://codereview.chromium.org/2392333003
Cr-Commit-Position: refs/heads/master@{#423539}

[modify] https://crrev.com/07d8a34ed9c1f4292888b50a0f31797ccd0d39d6/chrome/browser/android/vr_shell/vr_shell.cc

Project Member

Comment 9 by bugdroid1@chromium.org, Oct 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/07d8a34ed9c1f4292888b50a0f31797ccd0d39d6

commit 07d8a34ed9c1f4292888b50a0f31797ccd0d39d6
Author: cjgrant <cjgrant@chromium.org>
Date: Thu Oct 06 15:24:11 2016

Incorporate 15 degree laser beam angle on pointer.

- Point the beam 15 degrees down from where the controller is pointing, for wrist comfort.
- Fix the beam to point directly at the reticle.

BUG= 642058 

Review-Url: https://codereview.chromium.org/2392333003
Cr-Commit-Position: refs/heads/master@{#423539}

[modify] https://crrev.com/07d8a34ed9c1f4292888b50a0f31797ccd0d39d6/chrome/browser/android/vr_shell/vr_shell.cc

Labels: -Restrict-View-Google
Owner: cjgrant@chromium.org
Status: Assigned (was: Available)
Labels: -M-56
Labels: -Pri-2 VR-Demo M-56 Pri-1
Status: Fixed (was: Assigned)
As of now, the ToT reticle:

- Renders on the element it hits, parallel to that element
- If no element, it hits the content quad plane, or a bounding sphere, whichever is closer (keeps the reticle in site when looking backwards, sideways, up, down)
- Moves (visually) smoothly across elements (no lateral jumping, only depth jumping)
- 15-degree angle between controller axis and beam
- Beam is rendered as two perpendicular surfaces, so it stays visible at all angles

Hence, I'll close this issue.  I will create separate bugs (if not already in existence) for:

- HTML UI control of reticle and beam rendering (eg. color/style change if hovering over text field).  This should probably be delivered along with virtual keyboard support.
- Elbow model
- A visible controller model (if we want this)

Project Member

Comment 14 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/07d8a34ed9c1f4292888b50a0f31797ccd0d39d6

commit 07d8a34ed9c1f4292888b50a0f31797ccd0d39d6
Author: cjgrant <cjgrant@chromium.org>
Date: Thu Oct 06 15:24:11 2016

Incorporate 15 degree laser beam angle on pointer.

- Point the beam 15 degrees down from where the controller is pointing, for wrist comfort.
- Fix the beam to point directly at the reticle.

BUG= 642058 

Review-Url: https://codereview.chromium.org/2392333003
Cr-Commit-Position: refs/heads/master@{#423539}

[modify] https://crrev.com/07d8a34ed9c1f4292888b50a0f31797ccd0d39d6/chrome/browser/android/vr_shell/vr_shell.cc

Comment 15 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840

Sign in to add a comment