New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 642054 link

Starred by 2 users
Status: Fixed
Owner:
█ jaydasika@chromium.org
Last visit > 30 days ago
Closed: Mar 2017
Cc:
weiliangc@chromium.org
ajuma@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Feature

Blocking:
issue 594675



Sign in to add a comment

Calculate visible layer rect using clip tree without cached target information

Project Member Reported by weiliangc@chromium.org, Aug 29 2016 
Calculate visible layer rect dynamically. The main CL would look something like this: 
https://codereview.chromium.org/2285363002/

Without verifying there are currently 30 unittest failures. 

TODO:
- Fix/update current unittest failures
- Add verify calculation.
- Fix any more unittest failures that come up.

Comment 1 by jaydasika@chromium.org, Aug 30 2016

Cc: -jaydasika@chromium.org
Owner: jaydasika@chromium.org

Comment 2 by weiliangc@chromium.org, Aug 31 2016

Status: Assigned (was: Available)
One possible way to investigate the test failures is to use combined_clip_in_target_space for calculating visible rects in current code path. The behavior would be close to what we are trying to achieve, and it is easier to see what the edge cases might be. Something like https://codereview.chromium.org/2295463002/.

Comment 3 by weiliangc@chromium.org, Aug 31 2016

Components: Internals>Compositing
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 2 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/526eae0ac56bb041ad4304d4e7bfc66853c66e2b

commit 526eae0ac56bb041ad4304d4e7bfc66853c66e2b
Author: jaydasika <jaydasika@chromium.org>
Date: Fri Sep 02 01:47:59 2016

cc: Include viewport clip in visible rect of unclipped surfaces

BUG= 642054 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2305873002
Cr-Commit-Position: refs/heads/master@{#416160}

[modify] https://crrev.com/526eae0ac56bb041ad4304d4e7bfc66853c66e2b/cc/trees/draw_property_utils.cc
[modify] https://crrev.com/526eae0ac56bb041ad4304d4e7bfc66853c66e2b/cc/trees/layer_tree_host_common_unittest.cc
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 2 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/526eae0ac56bb041ad4304d4e7bfc66853c66e2b

commit 526eae0ac56bb041ad4304d4e7bfc66853c66e2b
Author: jaydasika <jaydasika@chromium.org>
Date: Fri Sep 02 01:47:59 2016

cc: Include viewport clip in visible rect of unclipped surfaces

BUG= 642054 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2305873002
Cr-Commit-Position: refs/heads/master@{#416160}

[modify] https://crrev.com/526eae0ac56bb041ad4304d4e7bfc66853c66e2b/cc/trees/draw_property_utils.cc
[modify] https://crrev.com/526eae0ac56bb041ad4304d4e7bfc66853c66e2b/cc/trees/layer_tree_host_common_unittest.cc
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 13 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b4df40340a70a533e1aaf5464fee53bfc2621fa2

commit b4df40340a70a533e1aaf5464fee53bfc2621fa2
Author: jaydasika <jaydasika@chromium.org>
Date: Tue Sep 13 18:38:49 2016

cc: Include viewport clip in visible rect of clip children

BUG= 642054 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2336923002
Cr-Commit-Position: refs/heads/master@{#418312}

[modify] https://crrev.com/b4df40340a70a533e1aaf5464fee53bfc2621fa2/cc/trees/draw_property_utils.cc
[modify] https://crrev.com/b4df40340a70a533e1aaf5464fee53bfc2621fa2/cc/trees/layer_tree_host_common_unittest.cc
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 20 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5237db09cd8a30328742e4f6b1ee2edb692e936b

commit 5237db09cd8a30328742e4f6b1ee2edb692e936b
Author: jaydasika <jaydasika@chromium.org>
Date: Tue Sep 20 01:34:30 2016

cc : Compute visible rects dynamically (1)

This CL computes visible rects dynamically for all cases we don't early
out in draw_property_utils::CalculateVisibleRects (we early out for
copy requests, singular transforms etc) and compares it with the
current computation. This dynamic computation is behind the
'verify_visible_rectcalculations' flag. This CL also skips
verify_visible_rect_calculations for some test where we expect the
visible rects computed by the two methods to be different

BUG= 642054 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2334003003
Cr-Commit-Position: refs/heads/master@{#419628}

[modify] https://crrev.com/5237db09cd8a30328742e4f6b1ee2edb692e936b/cc/output/bsp_tree_perftest.cc
[modify] https://crrev.com/5237db09cd8a30328742e4f6b1ee2edb692e936b/cc/test/fake_layer_tree_host_impl.cc
[modify] https://crrev.com/5237db09cd8a30328742e4f6b1ee2edb692e936b/cc/test/fake_layer_tree_host_impl.h
[modify] https://crrev.com/5237db09cd8a30328742e4f6b1ee2edb692e936b/cc/trees/damage_tracker_unittest.cc
[modify] https://crrev.com/5237db09cd8a30328742e4f6b1ee2edb692e936b/cc/trees/draw_property_utils.cc
[modify] https://crrev.com/5237db09cd8a30328742e4f6b1ee2edb692e936b/cc/trees/draw_property_utils.h
[modify] https://crrev.com/5237db09cd8a30328742e4f6b1ee2edb692e936b/cc/trees/layer_tree_host_common.cc
[modify] https://crrev.com/5237db09cd8a30328742e4f6b1ee2edb692e936b/cc/trees/layer_tree_host_common.h
[modify] https://crrev.com/5237db09cd8a30328742e4f6b1ee2edb692e936b/cc/trees/layer_tree_host_common_perftest.cc
[modify] https://crrev.com/5237db09cd8a30328742e4f6b1ee2edb692e936b/cc/trees/layer_tree_host_common_unittest.cc
[modify] https://crrev.com/5237db09cd8a30328742e4f6b1ee2edb692e936b/cc/trees/layer_tree_impl.cc
[modify] https://crrev.com/5237db09cd8a30328742e4f6b1ee2edb692e936b/cc/trees/layer_tree_impl.h
[modify] https://crrev.com/5237db09cd8a30328742e4f6b1ee2edb692e936b/cc/trees/layer_tree_impl_unittest.cc
Project Member

Comment 9 by bugdroid1@chromium.org, Sep 21 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ed8696692c33df85a9d85aa4c3cf34347b9dae3

commit 6ed8696692c33df85a9d85aa4c3cf34347b9dae3
Author: jaydasika <jaydasika@chromium.org>
Date: Wed Sep 21 14:29:59 2016

cc : Compute visible rects dynamically (2)

This CL computes visible rects dynamically for all cases. It also renames
ExecuteCalculateDrawPropertiesWithPropertyTrees to
ExecuteCalculateDrawPropertiesAndSaveUpdateLayerList

BUG= 642054 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2354753003
Cr-Commit-Position: refs/heads/master@{#420048}

[modify] https://crrev.com/6ed8696692c33df85a9d85aa4c3cf34347b9dae3/cc/trees/draw_property_utils.cc
[modify] https://crrev.com/6ed8696692c33df85a9d85aa4c3cf34347b9dae3/cc/trees/draw_property_utils.h
[modify] https://crrev.com/6ed8696692c33df85a9d85aa4c3cf34347b9dae3/cc/trees/layer_tree_host_common.cc
[modify] https://crrev.com/6ed8696692c33df85a9d85aa4c3cf34347b9dae3/cc/trees/layer_tree_host_common_unittest.cc
[modify] https://crrev.com/6ed8696692c33df85a9d85aa4c3cf34347b9dae3/cc/trees/layer_tree_impl_unittest.cc

Comment 10 by jaydasika@chromium.org, Mar 2 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment