"Detailed build info" subpage not opening in About |
|||||||
Issue descriptionVersion: 54.0.2837.0 OS: Chrome chrome://md-settings/help/details does not open the Details subpage. (Clicking "Detailed build information" in About is supposed to open this subpage.) It routes to the right place, but isSubpage() fails because the parent route is the root About page, so settings-animated-pages ignores it. Tommy, do we need to create a "section" route in between the About page and the Detailed sub-page?
,
Aug 29 2016
Issue 640480 has been merged into this issue.
,
Aug 29 2016
Yes, adding a section route would probably be the best intermediate term fix to this. I think we should eliminate section routes entirely before shipping, but that's still up in the air, since we need to be able to directly get to Internet and Bluetooth.
,
Sep 30 2016
Status on section routes and Details?
,
Sep 30 2016
https://codereview.chromium.org/2384693004
,
Sep 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/51051c6a3faf94f8287f58eb6d0a3b932044bea2 commit 51051c6a3faf94f8287f58eb6d0a3b932044bea2 Author: michaelpg <michaelpg@chromium.org> Date: Fri Sep 30 22:30:39 2016 Show "Detailed build info" subpage in About BUG= 642021 R=tommycli@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2384693004 Cr-Commit-Position: refs/heads/master@{#422245} [modify] https://crrev.com/51051c6a3faf94f8287f58eb6d0a3b932044bea2/chrome/browser/resources/settings/route.js
,
Oct 14 2016
Fixed?
,
Oct 14 2016
,
Oct 14 2016
,
Nov 16 2016
Fixed by me.
,
Nov 22 2016
Verified on ChromeOS 9000.0.0, 56.0.2923.0 |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by michae...@chromium.org
, Aug 29 2016