New issue
Advanced search Search tips

Issue 642017 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

QUIC timeout calculation can keep a connection open much long than expected

Project Member Reported by rch@chromium.org, Aug 29 2016

Issue description

When sending into a blackhole it's important for QUIC connections to time out frequently but the current calculation screws this up.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/10ae460d345bb14f03972f43c253c822e08ed5e2

commit 10ae460d345bb14f03972f43c253c822e08ed5e2
Author: rch <rch@chromium.org>
Date: Tue Aug 30 05:29:09 2016

Set QUIC connection's last_send_for_timeout_ to the send time of the
first sent packet after receiving a packet, even if the sent packet is
not a retransmission. Protected by default enabled
--quic_better_last_send_for_timeout

Merge internal change: 131623416

BUG= 642017 

Review-Url: https://codereview.chromium.org/2288843002
Cr-Commit-Position: refs/heads/master@{#415157}

[modify] https://crrev.com/10ae460d345bb14f03972f43c253c822e08ed5e2/net/quic/core/quic_connection.cc
[modify] https://crrev.com/10ae460d345bb14f03972f43c253c822e08ed5e2/net/quic/core/quic_connection_test.cc
[modify] https://crrev.com/10ae460d345bb14f03972f43c253c822e08ed5e2/net/quic/core/quic_flags.cc
[modify] https://crrev.com/10ae460d345bb14f03972f43c253c822e08ed5e2/net/quic/core/quic_flags.h

Comment 2 by rch@chromium.org, Sep 2 2016

Labels: Merge-Request-54

Comment 3 by dimu@chromium.org, Sep 2 2016

Labels: -Merge-Request-54 Merge-Approved-54 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M54 (branch: 2840)
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 2 2016

Labels: -merge-approved-54 merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/851a953ab4c9ca773977a3c057bb3150bdcc9cde

commit 851a953ab4c9ca773977a3c057bb3150bdcc9cde
Author: Ryan Hamilton <rch@chromium.org>
Date: Fri Sep 02 18:09:19 2016

[m54 merge] Set QUIC connection's last_send_for_timeout_ to the send time of the first sent packet after receiving a packet, even if the sent packet is not a retransmission. Protected by default enabled --quic_better_last_send_for_timeout

Merge internal change: 131623416

BUG= 642017 

Review-Url: https://codereview.chromium.org/2288843002
Cr-Commit-Position: refs/heads/master@{#415157}
(cherry picked from commit 10ae460d345bb14f03972f43c253c822e08ed5e2)

Review URL: https://codereview.chromium.org/2303403002 .

Cr-Commit-Position: refs/branch-heads/2840@{#126}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/851a953ab4c9ca773977a3c057bb3150bdcc9cde/net/quic/core/quic_connection.cc
[modify] https://crrev.com/851a953ab4c9ca773977a3c057bb3150bdcc9cde/net/quic/core/quic_connection_test.cc
[modify] https://crrev.com/851a953ab4c9ca773977a3c057bb3150bdcc9cde/net/quic/core/quic_flags.cc
[modify] https://crrev.com/851a953ab4c9ca773977a3c057bb3150bdcc9cde/net/quic/core/quic_flags.h

Comment 5 by rch@chromium.org, Sep 2 2016

Status: Fixed (was: Started)
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/851a953ab4c9ca773977a3c057bb3150bdcc9cde

commit 851a953ab4c9ca773977a3c057bb3150bdcc9cde
Author: Ryan Hamilton <rch@chromium.org>
Date: Fri Sep 02 18:09:19 2016

[m54 merge] Set QUIC connection's last_send_for_timeout_ to the send time of the first sent packet after receiving a packet, even if the sent packet is not a retransmission. Protected by default enabled --quic_better_last_send_for_timeout

Merge internal change: 131623416

BUG= 642017 

Review-Url: https://codereview.chromium.org/2288843002
Cr-Commit-Position: refs/heads/master@{#415157}
(cherry picked from commit 10ae460d345bb14f03972f43c253c822e08ed5e2)

Review URL: https://codereview.chromium.org/2303403002 .

Cr-Commit-Position: refs/branch-heads/2840@{#126}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/851a953ab4c9ca773977a3c057bb3150bdcc9cde/net/quic/core/quic_connection.cc
[modify] https://crrev.com/851a953ab4c9ca773977a3c057bb3150bdcc9cde/net/quic/core/quic_connection_test.cc
[modify] https://crrev.com/851a953ab4c9ca773977a3c057bb3150bdcc9cde/net/quic/core/quic_flags.cc
[modify] https://crrev.com/851a953ab4c9ca773977a3c057bb3150bdcc9cde/net/quic/core/quic_flags.h

Sign in to add a comment