New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 642014 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit 26 days ago
Closed: Sep 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

Remove gyp-win-tool

Project Member Reported by brettw@chromium.org, Aug 29 2016

Issue description

This vestige of GYP should be removed and replaced with a set of separate wrapper scripts like we have on Mac.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3826c51de883b9beedc92de5c17e9946a92dfe6d

commit 3826c51de883b9beedc92de5c17e9946a92dfe6d
Author: Brett Wilson <brettw@chromium.org>
Date: Mon Aug 29 22:03:58 2016

Move gyp-win-tool to the GN Windows toolchain.

Renames it tool_wrapper.py but otherwise keeps it unchanged from the original
https://chromium.googlesource.com/external/gyp.git/+/master/pylib/gyp/win_tool.py

The copy step of the old tool is currently kept pending a fix to NaCl that references it.

I changed internal references to itself to tool_wrapper.py, and split the internal strings containing the word "Copyright" (which it uses to filter tool output) to avoid triggering the copyright presubmit check.

Changes the build to refer to the file in-place rather than copying it to the build directory which was confusing.

The tool runs itself in the link_manifest step. Since the file is no longer copied to what will be the current directory when linking, I believe this will be broken. But the GN build does not use the manifest linking command. To keep changes minimal, I kept this code in for now.

Reland of http://crrev.com/2287603003 with fixes (keep the tool pending NaCl roll).

BUG= 642014 
R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/2286413002 .

Cr-Commit-Position: refs/heads/master@{#415034}

[modify] https://crrev.com/3826c51de883b9beedc92de5c17e9946a92dfe6d/build/config/win/manifest.gni
[modify] https://crrev.com/3826c51de883b9beedc92de5c17e9946a92dfe6d/build/toolchain/toolchain.gni
[modify] https://crrev.com/3826c51de883b9beedc92de5c17e9946a92dfe6d/build/toolchain/win/BUILD.gn
[modify] https://crrev.com/3826c51de883b9beedc92de5c17e9946a92dfe6d/build/toolchain/win/midl.gni
[add] https://crrev.com/3826c51de883b9beedc92de5c17e9946a92dfe6d/build/toolchain/win/tool_wrapper.py

Project Member

Comment 3 by bugdroid1@chromium.org, Sep 1 2016

Project Member

Comment 4 by bugdroid1@chromium.org, Sep 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cef5f01c6db46b010f401db2b9948511ff758db5

commit cef5f01c6db46b010f401db2b9948511ff758db5
Author: recipe-roller <recipe-roller@chromium.org>
Date: Thu Sep 01 20:22:17 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/8b48b789b84eef6a433f3c8367f0dadbb04a5f00 Remove obsolete refs to gyp-[mac|win]-tool (scottmg@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG= 642014 

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2299323002
Cr-Commit-Position: refs/heads/master@{#416034}

[modify] https://crrev.com/cef5f01c6db46b010f401db2b9948511ff758db5/infra/config/recipes.cfg

Project Member

Comment 5 by bugdroid1@chromium.org, Sep 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/1d05ba9445f56cb62e2dcc8ced79e849c4de50fe

commit 1d05ba9445f56cb62e2dcc8ced79e849c4de50fe
Author: recipe-roller <recipe-roller@chromium.org>
Date: Thu Sep 01 20:24:44 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/8b48b789b84eef6a433f3c8367f0dadbb04a5f00 Remove obsolete refs to gyp-[mac|win]-tool (scottmg@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG= 642014 

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2305483003

[modify] https://crrev.com/1d05ba9445f56cb62e2dcc8ced79e849c4de50fe/infra/config/recipes.cfg

Project Member

Comment 6 by bugdroid1@chromium.org, Sep 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/44a24edbd882d812b3e83a212a0e14e5327a6165

commit 44a24edbd882d812b3e83a212a0e14e5327a6165
Author: brettw <brettw@chromium.org>
Date: Thu Sep 01 21:09:56 2016

Remove gyp-win-tool.

Now that NaCl has rolled and no longer references this script in the build directory, we can stop copying it to the build directory.

BUG= 642014 

Review-Url: https://codereview.chromium.org/2301193002
Cr-Commit-Position: refs/heads/master@{#416052}

[modify] https://crrev.com/44a24edbd882d812b3e83a212a0e14e5327a6165/build/toolchain/win/BUILD.gn
[modify] https://crrev.com/44a24edbd882d812b3e83a212a0e14e5327a6165/build/toolchain/win/setup_toolchain.py

Project Member

Comment 7 by bugdroid1@chromium.org, Sep 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/60020274bacd81b0b4b091405e363ee56d407a42

commit 60020274bacd81b0b4b091405e363ee56d407a42
Author: fgorski <fgorski@chromium.org>
Date: Thu Sep 01 21:48:59 2016

Revert of Remove gyp-win-tool. (patchset #1 id:1 of https://codereview.chromium.org/2301193002/ )

Reason for revert:
Build broken with change:

https://build.chromium.org/p/chromium/builders/Win/builds/46673

Original issue's description:
> Remove gyp-win-tool.
>
> Now that NaCl has rolled and no longer references this script in the build directory, we can stop copying it to the build directory.
>
> BUG= 642014 
>
> Committed: https://crrev.com/44a24edbd882d812b3e83a212a0e14e5327a6165
> Cr-Commit-Position: refs/heads/master@{#416052}

TBR=scottmg@chromium.org,brettw@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 642014 

Review-Url: https://codereview.chromium.org/2296053004
Cr-Commit-Position: refs/heads/master@{#416070}

[modify] https://crrev.com/60020274bacd81b0b4b091405e363ee56d407a42/build/toolchain/win/BUILD.gn
[modify] https://crrev.com/60020274bacd81b0b4b091405e363ee56d407a42/build/toolchain/win/setup_toolchain.py

Project Member

Comment 8 by bugdroid1@chromium.org, Sep 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/3fcd4ab5eab6c5a08c660da62614257fc768f302

commit 3fcd4ab5eab6c5a08c660da62614257fc768f302
Author: scottmg <scottmg@chromium.org>
Date: Tue Sep 06 17:35:18 2016

Revert of Remove obsolete refs to gyp-[mac|win]-tool (patchset #1 id:1 of https://codereview.chromium.org/2299973004/ )

Reason for revert:
http://crbug.com/643577 official.desktop.builder

Original issue's description:
> Remove obsolete refs to gyp-[mac|win]-tool
>
> R=brettw@chromium.org
> BUG= 642014 
>
> Committed: https://chromium.googlesource.com/chromium/tools/build/+/8b48b789b84eef6a433f3c8367f0dadbb04a5f00

TBR=brettw@chromium.org,dpranke@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 642014 

Review-Url: https://codereview.chromium.org/2314163002

[modify] https://crrev.com/3fcd4ab5eab6c5a08c660da62614257fc768f302/scripts/slave/build_directory.py

Project Member

Comment 9 by bugdroid1@chromium.org, Sep 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/80b4f6ddcc6e6889cd6d624e23669d35638ac433

commit 80b4f6ddcc6e6889cd6d624e23669d35638ac433
Author: recipe-roller <recipe-roller@chromium.org>
Date: Tue Sep 06 17:57:54 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/3fcd4ab5eab6c5a08c660da62614257fc768f302 Revert of Remove obsolete refs to gyp-[mac|win]-tool (patchset #1 id:1 of https://codereview.chromium.org/2299973004/ ) (scottmg@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG= 642014 

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2311143003

[modify] https://crrev.com/80b4f6ddcc6e6889cd6d624e23669d35638ac433/infra/config/recipes.cfg

Project Member

Comment 10 by bugdroid1@chromium.org, Sep 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bfa71bfa84058e372b33f7a24c09a7d72a7cdbc0

commit bfa71bfa84058e372b33f7a24c09a7d72a7cdbc0
Author: brettw <brettw@chromium.org>
Date: Tue Sep 06 20:29:39 2016

Remove gyp-win-tool.

Now that NaCl has rolled and no longer references this script in the build directory, we can stop copying it to the build directory.

BUG= 642014 

Committed: https://crrev.com/44a24edbd882d812b3e83a212a0e14e5327a6165
Review-Url: https://codereview.chromium.org/2301193002
Cr-Original-Commit-Position: refs/heads/master@{#416052}
Cr-Commit-Position: refs/heads/master@{#416703}

[modify] https://crrev.com/bfa71bfa84058e372b33f7a24c09a7d72a7cdbc0/build/toolchain/win/BUILD.gn
[modify] https://crrev.com/bfa71bfa84058e372b33f7a24c09a7d72a7cdbc0/build/toolchain/win/setup_toolchain.py

Project Member

Comment 11 by bugdroid1@chromium.org, Sep 7 2016

Status: Fixed (was: Started)

Sign in to add a comment